* [PATCH net-next] cgroup, bpf: remove unnecessary #include
@ 2016-11-26 7:23 Alexei Starovoitov
2016-11-26 18:40 ` Rami Rosen
2016-11-29 10:48 ` Daniel Borkmann
0 siblings, 2 replies; 7+ messages in thread
From: Alexei Starovoitov @ 2016-11-26 7:23 UTC (permalink / raw)
To: David S . Miller; +Cc: Daniel Borkmann, Daniel Mack, Tejun Heo, netdev
this #include is unnecessary and brings whole set of
other headers into cgroup-defs.h. Remove it.
Fixes: 3007098494be ("cgroup: add support for eBPF programs")
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
---
include/linux/bpf-cgroup.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/bpf-cgroup.h b/include/linux/bpf-cgroup.h
index ec80d0c0953e..0cf1adfadd2d 100644
--- a/include/linux/bpf-cgroup.h
+++ b/include/linux/bpf-cgroup.h
@@ -1,7 +1,6 @@
#ifndef _BPF_CGROUP_H
#define _BPF_CGROUP_H
-#include <linux/bpf.h>
#include <linux/jump_label.h>
#include <uapi/linux/bpf.h>
--
2.8.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] cgroup, bpf: remove unnecessary #include
2016-11-26 7:23 [PATCH net-next] cgroup, bpf: remove unnecessary #include Alexei Starovoitov
@ 2016-11-26 18:40 ` Rami Rosen
2016-11-29 10:48 ` Daniel Borkmann
1 sibling, 0 replies; 7+ messages in thread
From: Rami Rosen @ 2016-11-26 18:40 UTC (permalink / raw)
To: Alexei Starovoitov
Cc: David S . Miller, Daniel Borkmann, Daniel Mack, Tejun Heo, Netdev
Acked-by: Rami Rosen <roszenrami@gmail.com>
On 26 November 2016 at 09:23, Alexei Starovoitov <ast@fb.com> wrote:
> this #include is unnecessary and brings whole set of
> other headers into cgroup-defs.h. Remove it.
>
> Fixes: 3007098494be ("cgroup: add support for eBPF programs")
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> ---
> include/linux/bpf-cgroup.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/bpf-cgroup.h b/include/linux/bpf-cgroup.h
> index ec80d0c0953e..0cf1adfadd2d 100644
> --- a/include/linux/bpf-cgroup.h
> +++ b/include/linux/bpf-cgroup.h
> @@ -1,7 +1,6 @@
> #ifndef _BPF_CGROUP_H
> #define _BPF_CGROUP_H
>
> -#include <linux/bpf.h>
> #include <linux/jump_label.h>
> #include <uapi/linux/bpf.h>
>
> --
> 2.8.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] cgroup, bpf: remove unnecessary #include
2016-11-26 7:23 [PATCH net-next] cgroup, bpf: remove unnecessary #include Alexei Starovoitov
2016-11-26 18:40 ` Rami Rosen
@ 2016-11-29 10:48 ` Daniel Borkmann
2016-11-29 14:05 ` Daniel Mack
2016-11-29 19:26 ` Alexei Starovoitov
1 sibling, 2 replies; 7+ messages in thread
From: Daniel Borkmann @ 2016-11-29 10:48 UTC (permalink / raw)
To: Alexei Starovoitov, David S . Miller; +Cc: Daniel Mack, Tejun Heo, netdev
On 11/26/2016 08:23 AM, Alexei Starovoitov wrote:
> this #include is unnecessary and brings whole set of
> other headers into cgroup-defs.h. Remove it.
>
> Fixes: 3007098494be ("cgroup: add support for eBPF programs")
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
This fixes many build errors in samples/bpf/ due to wrong helper
redefinitions (originating from kernel includes conflicting with
samples' helper declarations).
I don't see it pushed out to net-next yet, so:
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] cgroup, bpf: remove unnecessary #include
2016-11-29 10:48 ` Daniel Borkmann
@ 2016-11-29 14:05 ` Daniel Mack
2016-11-29 19:26 ` Alexei Starovoitov
1 sibling, 0 replies; 7+ messages in thread
From: Daniel Mack @ 2016-11-29 14:05 UTC (permalink / raw)
To: Daniel Borkmann, Alexei Starovoitov, David S . Miller; +Cc: Tejun Heo, netdev
On 11/29/2016 11:48 AM, Daniel Borkmann wrote:
> On 11/26/2016 08:23 AM, Alexei Starovoitov wrote:
>> this #include is unnecessary and brings whole set of
>> other headers into cgroup-defs.h. Remove it.
>>
>> Fixes: 3007098494be ("cgroup: add support for eBPF programs")
>> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
>
> This fixes many build errors in samples/bpf/ due to wrong helper
> redefinitions (originating from kernel includes conflicting with
> samples' helper declarations).
>
> I don't see it pushed out to net-next yet, so:
>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
>
FWIW:
Acked-by: Daniel Mack <daniel@zonque.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] cgroup, bpf: remove unnecessary #include
2016-11-29 10:48 ` Daniel Borkmann
2016-11-29 14:05 ` Daniel Mack
@ 2016-11-29 19:26 ` Alexei Starovoitov
1 sibling, 0 replies; 7+ messages in thread
From: Alexei Starovoitov @ 2016-11-29 19:26 UTC (permalink / raw)
To: Daniel Borkmann, David S. Miller; +Cc: Daniel Mack, Tejun Heo, netdev
On Tue, Nov 29, 2016 at 2:48 AM, Daniel Borkmann <daniel@iogearbox.net> wrote:
> On 11/26/2016 08:23 AM, Alexei Starovoitov wrote:
>>
>> this #include is unnecessary and brings whole set of
>> other headers into cgroup-defs.h. Remove it.
>>
>> Fixes: 3007098494be ("cgroup: add support for eBPF programs")
>> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
>
>
> This fixes many build errors in samples/bpf/ due to wrong helper
> redefinitions (originating from kernel includes conflicting with
> samples' helper declarations).
>
> I don't see it pushed out to net-next yet, so:
>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Dave,
this patch is marked as 'accepted', but I don't see in net-next ...
please double check.
Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] cgroup, bpf: remove unnecessary #include
2016-11-30 18:16 Alexei Starovoitov
@ 2016-11-30 18:58 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2016-11-30 18:58 UTC (permalink / raw)
To: ast; +Cc: daniel, daniel, roszenrami, netdev
From: Alexei Starovoitov <ast@fb.com>
Date: Wed, 30 Nov 2016 10:16:08 -0800
> this #include is unnecessary and brings whole set of
> other headers into cgroup-defs.h. Remove it.
>
> Fixes: 3007098494be ("cgroup: add support for eBPF programs")
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> Acked-by: Rami Rosen <roszenrami@gmail.com>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
> Acked-by: Daniel Mack <daniel@zonque.org>
> ---
> Dave,
> this patch got lost somehow (marked accepted, but not in net-next).
> Resending.
Applied, thanks ALexei.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH net-next] cgroup, bpf: remove unnecessary #include
@ 2016-11-30 18:16 Alexei Starovoitov
2016-11-30 18:58 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Alexei Starovoitov @ 2016-11-30 18:16 UTC (permalink / raw)
To: David S . Miller; +Cc: Daniel Borkmann, Daniel Mack, Rami Rosen, netdev
this #include is unnecessary and brings whole set of
other headers into cgroup-defs.h. Remove it.
Fixes: 3007098494be ("cgroup: add support for eBPF programs")
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Rami Rosen <roszenrami@gmail.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Daniel Mack <daniel@zonque.org>
---
Dave,
this patch got lost somehow (marked accepted, but not in net-next).
Resending.
include/linux/bpf-cgroup.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/bpf-cgroup.h b/include/linux/bpf-cgroup.h
index ec80d0c0953e..0cf1adfadd2d 100644
--- a/include/linux/bpf-cgroup.h
+++ b/include/linux/bpf-cgroup.h
@@ -1,7 +1,6 @@
#ifndef _BPF_CGROUP_H
#define _BPF_CGROUP_H
-#include <linux/bpf.h>
#include <linux/jump_label.h>
#include <uapi/linux/bpf.h>
--
2.8.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-11-30 18:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-26 7:23 [PATCH net-next] cgroup, bpf: remove unnecessary #include Alexei Starovoitov
2016-11-26 18:40 ` Rami Rosen
2016-11-29 10:48 ` Daniel Borkmann
2016-11-29 14:05 ` Daniel Mack
2016-11-29 19:26 ` Alexei Starovoitov
2016-11-30 18:16 Alexei Starovoitov
2016-11-30 18:58 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.