* [i-g-t PATCH] lib: add option for running generic tests cases only
@ 2016-11-28 9:37 Abdiel Janulgue
2016-11-28 12:07 ` Maarten Lankhorst
0 siblings, 1 reply; 4+ messages in thread
From: Abdiel Janulgue @ 2016-11-28 9:37 UTC (permalink / raw)
To: intel-gfx
Pretend to run on a non-intel machine even when running on i915.ko,
so that we could run and gather passrate data.
Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
---
lib/drmtest.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index 44abc7e..a8b75e8 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -254,8 +254,11 @@ int __drm_open_driver(int chipset)
continue;
if (chipset & DRIVER_INTEL && is_i915_device(fd) &&
- has_known_intel_chipset(fd))
+ has_known_intel_chipset(fd)) {
+ igt_skip_on_f(getenv("IGT_GENERIC_ONLY"),
+ "Generic tests only\n");
return fd;
+ }
if (chipset & DRIVER_VC4 &&
is_vc4_device(fd))
@@ -415,5 +418,6 @@ int drm_open_driver_render(int chipset)
void igt_require_intel(int fd)
{
+ igt_skip_on_f(getenv("IGT_GENERIC_ONLY"), "Generic tests only\n");
igt_require(is_i915_device(fd) && has_known_intel_chipset(fd));
}
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [i-g-t PATCH] lib: add option for running generic tests cases only
2016-11-28 9:37 [i-g-t PATCH] lib: add option for running generic tests cases only Abdiel Janulgue
@ 2016-11-28 12:07 ` Maarten Lankhorst
2016-11-28 12:20 ` Chris Wilson
0 siblings, 1 reply; 4+ messages in thread
From: Maarten Lankhorst @ 2016-11-28 12:07 UTC (permalink / raw)
To: Abdiel Janulgue, intel-gfx
Op 28-11-16 om 10:37 schreef Abdiel Janulgue:
> Pretend to run on a non-intel machine even when running on i915.ko,
> so that we could run and gather passrate data.
> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
> ---
> lib/drmtest.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index 44abc7e..a8b75e8 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -254,8 +254,11 @@ int __drm_open_driver(int chipset)
> continue;
>
> if (chipset & DRIVER_INTEL && is_i915_device(fd) &&
> - has_known_intel_chipset(fd))
> + has_known_intel_chipset(fd)) {
> + igt_skip_on_f(getenv("IGT_GENERIC_ONLY"),
> + "Generic tests only\n");
> return fd;
> + }
This will make the passrate worse for any driver that has DRIVER_ANY set.
>
> if (chipset & DRIVER_VC4 &&
> is_vc4_device(fd))
> @@ -415,5 +418,6 @@ int drm_open_driver_render(int chipset)
>
> void igt_require_intel(int fd)
> {
> + igt_skip_on_f(getenv("IGT_GENERIC_ONLY"), "Generic tests only\n");
> igt_require(is_i915_device(fd) && has_known_intel_chipset(fd));
> }
>
Won't it be better to only put the hack in is_i915_device only?
Some code in IGT checks that too.
~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [i-g-t PATCH] lib: add option for running generic tests cases only
2016-11-28 12:07 ` Maarten Lankhorst
@ 2016-11-28 12:20 ` Chris Wilson
2016-11-29 8:21 ` Abdiel Janulgue
0 siblings, 1 reply; 4+ messages in thread
From: Chris Wilson @ 2016-11-28 12:20 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
On Mon, Nov 28, 2016 at 01:07:36PM +0100, Maarten Lankhorst wrote:
> Op 28-11-16 om 10:37 schreef Abdiel Janulgue:
> > Pretend to run on a non-intel machine even when running on i915.ko,
> > so that we could run and gather passrate data.
What exactly do you mean?
> > Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
> > ---
> > lib/drmtest.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/drmtest.c b/lib/drmtest.c
> > index 44abc7e..a8b75e8 100644
> > --- a/lib/drmtest.c
> > +++ b/lib/drmtest.c
> > @@ -254,8 +254,11 @@ int __drm_open_driver(int chipset)
> > continue;
> >
> > if (chipset & DRIVER_INTEL && is_i915_device(fd) &&
> > - has_known_intel_chipset(fd))
> > + has_known_intel_chipset(fd)) {
> > + igt_skip_on_f(getenv("IGT_GENERIC_ONLY"),
> > + "Generic tests only\n");
> > return fd;
> > + }
>
> This will make the passrate worse for any driver that has DRIVER_ANY set.
DRIVER_ANY being the key here. It sounds like you should argue for doing
that generic test first.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [i-g-t PATCH] lib: add option for running generic tests cases only
2016-11-28 12:20 ` Chris Wilson
@ 2016-11-29 8:21 ` Abdiel Janulgue
0 siblings, 0 replies; 4+ messages in thread
From: Abdiel Janulgue @ 2016-11-29 8:21 UTC (permalink / raw)
To: Chris Wilson, Maarten Lankhorst, intel-gfx
On 11/28/2016 02:20 PM, Chris Wilson wrote:
> On Mon, Nov 28, 2016 at 01:07:36PM +0100, Maarten Lankhorst wrote:
>> Op 28-11-16 om 10:37 schreef Abdiel Janulgue:
>>> Pretend to run on a non-intel machine even when running on i915.ko,
>>> so that we could run and gather passrate data.
>
> What exactly do you mean?
We need a list of generic test-cases that isn't dependent on i915. Would
be good to have a subset of generic tests cases.
>
>>> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
>>> ---
>>> lib/drmtest.c | 6 +++++-
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/lib/drmtest.c b/lib/drmtest.c
>>> index 44abc7e..a8b75e8 100644
>>> --- a/lib/drmtest.c
>>> +++ b/lib/drmtest.c
>>> @@ -254,8 +254,11 @@ int __drm_open_driver(int chipset)
>>> continue;
>>>
>>> if (chipset & DRIVER_INTEL && is_i915_device(fd) &&
>>> - has_known_intel_chipset(fd))
>>> + has_known_intel_chipset(fd)) {
>>> + igt_skip_on_f(getenv("IGT_GENERIC_ONLY"),
>>> + "Generic tests only\n");
>>> return fd;
>>> + }
>>
>> This will make the passrate worse for any driver that has DRIVER_ANY set.
>
> DRIVER_ANY being the key here. It sounds like you should argue for doing
> that generic test first.
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-29 8:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-28 9:37 [i-g-t PATCH] lib: add option for running generic tests cases only Abdiel Janulgue
2016-11-28 12:07 ` Maarten Lankhorst
2016-11-28 12:20 ` Chris Wilson
2016-11-29 8:21 ` Abdiel Janulgue
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.