From: "Noralf Trønnes" <noralf@tronnes.org> To: Liviu Dudau <Liviu.Dudau@arm.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, LKML <linux-kernel@vger.kernel.org>, DRI-devel <dri-devel@lists.freedesktop.org>, Mali DP Maintainers <malidp@foss.arm.com>, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [PATCH v2] drm: gem_cma_helper.c: Allow importing of contiguous scatterlists with nents > 1 Date: Wed, 15 Nov 2017 15:24:41 +0100 [thread overview] Message-ID: <14804f07-697f-cfc9-d325-6eb3888b04e3@tronnes.org> (raw) In-Reply-To: <20171115130450.GA31361@e110455-lin.cambridge.arm.com> Den 15.11.2017 14.04, skrev Liviu Dudau: > Hi, > > On Sat, Nov 11, 2017 at 02:47:35PM +0200, Laurent Pinchart wrote: >> Hi Liviu, >> >> Thank you for the patch. >> >> On Friday, 10 November 2017 15:33:10 EET Liviu Dudau wrote: >>> drm_gem_cma_prime_import_sg_table() will fail if the number of entries >>> in the sg_table > 1. However, you can have a device that uses an IOMMU >>> engine and can map a discontiguous buffer with multiple entries that >>> have consecutive sg_dma_addresses, effectively making it contiguous. >>> Allow for that scenario by testing the entries in the sg_table for >>> contiguous coverage. >>> >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com> >>> --- >>> >>> Laurent, >>> >>> Thanks for the review! I would like to ask for one more favour: if you >>> are OK with this version, can you pull this patch through the drm-misc tree? >> I could, but I'd first need to set dim up, and I'm currently abroad with a bad >> internet connection and a big deadline for the middle of next week (I know, >> lots of excuses), so it's not very convenient for me at this time. > Any other drm-misc maintainers feeling helpful and willing to take this > patch in? Sure, I can do it this evening. Noralf. > Otherwise I can send it through the mali-dp tree if no one > objects. > > Best regards, > Liviu > >>> drivers/gpu/drm/drm_gem_cma_helper.c | 22 ++++++++++++++++++++-- >>> include/drm/drm_gem_cma_helper.h | 4 +++- >>> 2 files changed, 23 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c >>> b/drivers/gpu/drm/drm_gem_cma_helper.c index 020e7668dfaba..43b179212052d >>> 100644 >>> --- a/drivers/gpu/drm/drm_gem_cma_helper.c >>> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c >>> @@ -482,8 +482,26 @@ drm_gem_cma_prime_import_sg_table(struct drm_device >>> *dev, { >>> struct drm_gem_cma_object *cma_obj; >>> >>> - if (sgt->nents != 1) >>> - return ERR_PTR(-EINVAL); >>> + if (sgt->nents != 1) { >>> + /* check if the entries in the sg_table are contiguous */ >>> + dma_addr_t next_addr = sg_dma_address(sgt->sgl); >>> + struct scatterlist *s; >>> + unsigned int i; >>> + >>> + for_each_sg(sgt->sgl, s, sgt->nents, i) { >>> + /* >>> + * sg_dma_address(s) is only valid for entries >>> + * that have sg_dma_len(s) != 0 >>> + */ >>> + if (!sg_dma_len(s)) >>> + continue; >>> + >>> + if (sg_dma_address(s) != next_addr) >>> + return ERR_PTR(-EINVAL); >>> + >>> + next_addr = sg_dma_address(s) + sg_dma_len(s); >>> + } >>> + } >>> >>> /* Create a CMA GEM buffer. */ >>> cma_obj = __drm_gem_cma_create(dev, attach->dmabuf->size); >>> diff --git a/include/drm/drm_gem_cma_helper.h >>> b/include/drm/drm_gem_cma_helper.h index 58a739bf15f1f..214aa85adc8d5 >>> 100644 >>> --- a/include/drm/drm_gem_cma_helper.h >>> +++ b/include/drm/drm_gem_cma_helper.h >>> @@ -8,7 +8,9 @@ >>> * struct drm_gem_cma_object - GEM object backed by CMA memory allocations >>> * @base: base GEM object >>> * @paddr: physical address of the backing memory >>> - * @sgt: scatter/gather table for imported PRIME buffers >>> + * @sgt: scatter/gather table for imported PRIME buffers. The table can >>> have + * more than one entry but they are guaranteed to have >>> contiguous + * DMA addresses. >>> * @vaddr: kernel virtual address of the backing memory >>> */ >>> struct drm_gem_cma_object { >> -- >> Regards, >> >> Laurent Pinchart >>
WARNING: multiple messages have this Message-ID (diff)
From: "Noralf Trønnes" <noralf@tronnes.org> To: Liviu Dudau <Liviu.Dudau@arm.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, LKML <linux-kernel@vger.kernel.org>, DRI-devel <dri-devel@lists.freedesktop.org>, Mali DP Maintainers <malidp@foss.arm.com>, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [PATCH v2] drm: gem_cma_helper.c: Allow importing of contiguous scatterlists with nents > 1 Date: Wed, 15 Nov 2017 15:24:41 +0100 [thread overview] Message-ID: <14804f07-697f-cfc9-d325-6eb3888b04e3@tronnes.org> (raw) In-Reply-To: <20171115130450.GA31361@e110455-lin.cambridge.arm.com> Den 15.11.2017 14.04, skrev Liviu Dudau: > Hi, > > On Sat, Nov 11, 2017 at 02:47:35PM +0200, Laurent Pinchart wrote: >> Hi Liviu, >> >> Thank you for the patch. >> >> On Friday, 10 November 2017 15:33:10 EET Liviu Dudau wrote: >>> drm_gem_cma_prime_import_sg_table() will fail if the number of entries >>> in the sg_table > 1. However, you can have a device that uses an IOMMU >>> engine and can map a discontiguous buffer with multiple entries that >>> have consecutive sg_dma_addresses, effectively making it contiguous. >>> Allow for that scenario by testing the entries in the sg_table for >>> contiguous coverage. >>> >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com> >>> --- >>> >>> Laurent, >>> >>> Thanks for the review! I would like to ask for one more favour: if you >>> are OK with this version, can you pull this patch through the drm-misc tree? >> I could, but I'd first need to set dim up, and I'm currently abroad with a bad >> internet connection and a big deadline for the middle of next week (I know, >> lots of excuses), so it's not very convenient for me at this time. > Any other drm-misc maintainers feeling helpful and willing to take this > patch in? Sure, I can do it this evening. Noralf. > Otherwise I can send it through the mali-dp tree if no one > objects. > > Best regards, > Liviu > >>> drivers/gpu/drm/drm_gem_cma_helper.c | 22 ++++++++++++++++++++-- >>> include/drm/drm_gem_cma_helper.h | 4 +++- >>> 2 files changed, 23 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c >>> b/drivers/gpu/drm/drm_gem_cma_helper.c index 020e7668dfaba..43b179212052d >>> 100644 >>> --- a/drivers/gpu/drm/drm_gem_cma_helper.c >>> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c >>> @@ -482,8 +482,26 @@ drm_gem_cma_prime_import_sg_table(struct drm_device >>> *dev, { >>> struct drm_gem_cma_object *cma_obj; >>> >>> - if (sgt->nents != 1) >>> - return ERR_PTR(-EINVAL); >>> + if (sgt->nents != 1) { >>> + /* check if the entries in the sg_table are contiguous */ >>> + dma_addr_t next_addr = sg_dma_address(sgt->sgl); >>> + struct scatterlist *s; >>> + unsigned int i; >>> + >>> + for_each_sg(sgt->sgl, s, sgt->nents, i) { >>> + /* >>> + * sg_dma_address(s) is only valid for entries >>> + * that have sg_dma_len(s) != 0 >>> + */ >>> + if (!sg_dma_len(s)) >>> + continue; >>> + >>> + if (sg_dma_address(s) != next_addr) >>> + return ERR_PTR(-EINVAL); >>> + >>> + next_addr = sg_dma_address(s) + sg_dma_len(s); >>> + } >>> + } >>> >>> /* Create a CMA GEM buffer. */ >>> cma_obj = __drm_gem_cma_create(dev, attach->dmabuf->size); >>> diff --git a/include/drm/drm_gem_cma_helper.h >>> b/include/drm/drm_gem_cma_helper.h index 58a739bf15f1f..214aa85adc8d5 >>> 100644 >>> --- a/include/drm/drm_gem_cma_helper.h >>> +++ b/include/drm/drm_gem_cma_helper.h >>> @@ -8,7 +8,9 @@ >>> * struct drm_gem_cma_object - GEM object backed by CMA memory allocations >>> * @base: base GEM object >>> * @paddr: physical address of the backing memory >>> - * @sgt: scatter/gather table for imported PRIME buffers >>> + * @sgt: scatter/gather table for imported PRIME buffers. The table can >>> have + * more than one entry but they are guaranteed to have >>> contiguous + * DMA addresses. >>> * @vaddr: kernel virtual address of the backing memory >>> */ >>> struct drm_gem_cma_object { >> -- >> Regards, >> >> Laurent Pinchart >> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-11-15 14:25 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-01 14:14 [PATCH] drm: gem_cma_helper.c: Allow importing of contiguous scatterlists with nents > 1 Liviu Dudau 2017-11-01 14:14 ` Liviu Dudau 2017-11-10 4:26 ` Laurent Pinchart 2017-11-10 4:26 ` Laurent Pinchart 2017-11-10 13:33 ` [PATCH v2] " Liviu Dudau 2017-11-10 13:33 ` Liviu Dudau 2017-11-11 12:47 ` Laurent Pinchart 2017-11-11 12:47 ` Laurent Pinchart 2017-11-15 13:04 ` Liviu Dudau 2017-11-15 13:04 ` Liviu Dudau 2017-11-15 14:24 ` Noralf Trønnes [this message] 2017-11-15 14:24 ` Noralf Trønnes 2017-11-15 14:41 ` Liviu Dudau 2017-11-15 14:41 ` Liviu Dudau 2017-11-10 14:19 ` ✓ Fi.CI.BAT: success for " Patchwork 2017-11-10 16:10 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=14804f07-697f-cfc9-d325-6eb3888b04e3@tronnes.org \ --to=noralf@tronnes.org \ --cc=Liviu.Dudau@arm.com \ --cc=airlied@linux.ie \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=malidp@foss.arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.