[RFC 0/3] Enable and test MAXREFDES4# on Genmai board

[RFC 0/3] Enable and test MAXREFDES4# on Genmai board

[Jacopo Mondi]

Hello Magnus and Geert, list,
   this patch series enable the creation of a spidev device though which
interface to a MAXREFDES4# MAX11100-ADC evaluation kit connected to Genmai
CON2 expansion header.

The series is not intended for inclusion but will probably serve as base
for future integration of MAX11100 ADC driver.

The series is based on branch "genmai-gpio-and-pfc" of Geert's tree at
git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git
and target Linux v3.18

The series fix a compilation error for RZ gpio driver and register a
gpio based SPI master on CON2 pins.

The test bed is setup as:

P11_11 (CN2 pin 5) connected as CS
P11_10 (CN2 pin 6) connected as MISO
P11_9  (CN2 pin 7) connected as SCLK
P11_8  (CN2 pin 8) connected as AIN

The ADC input is connected to gpio port 11 pin 8 (gpio863) and ADC
functionalities have been tested reading the results of successive
analog-to-digital conversions and verifying they match the gpio863
output value.

Thanks
   j

Jacopo Mondi (3):
  gpio-rz: Port to v3.18
  dts: arm: genmai: Add MAXDESREF4x spidev
  spidev: Add back "linux,spidev" as compatible

 arch/arm/boot/dts/r7s72100-genmai.dts | 22 ++++++++++++++++++++++
 drivers/gpio/gpio-rz.c                |  3 ++-
 drivers/spi/spidev.c                  |  1 +
 3 files changed, 25 insertions(+), 1 deletion(-)

-- 
2.7.4

[RFC 1/3] gpio-rz: Port to v3.18

[Jacopo Mondi]

Fix invalid return value in gpio remove function

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 drivers/gpio/gpio-rz.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-rz.c b/drivers/gpio/gpio-rz.c
index a933dab..cb8f785 100644
--- a/drivers/gpio/gpio-rz.c
+++ b/drivers/gpio/gpio-rz.c
@@ -175,7 +175,8 @@ static int rz_gpio_remove(struct platform_device *pdev)
 {
 	struct rz_gpio_priv *p = platform_get_drvdata(pdev);
 
-	return gpiochip_remove(&p->gpio_chip);
+	gpiochip_remove(&p->gpio_chip);
+	return 0;
 }
 
 static const struct of_device_id rz_gpio_dt_ids[] = {
-- 
2.7.4

[RFC 2/3] dts: arm: genmai: Add MAXDESREF4x spidev

[Jacopo Mondi]

Add device node for the MAX11100 evaluation board connected to Genmai's
CN2.
The evaluation kit is connected to 4 GPIO lines configured ad bitbanged
SPI master interface

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 arch/arm/boot/dts/r7s72100-genmai.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm/boot/dts/r7s72100-genmai.dts b/arch/arm/boot/dts/r7s72100-genmai.dts
index 233908b..89a1977 100644
--- a/arch/arm/boot/dts/r7s72100-genmai.dts
+++ b/arch/arm/boot/dts/r7s72100-genmai.dts
@@ -46,6 +46,24 @@
 		};
 	};
 
+	spi-gpio {
+		compatible = "spi-gpio";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		pinctrl-names = "default";
+
+		gpio-miso = <&port11 10 GPIO_ACTIVE_HIGH>;
+		gpio-sck = <&port11  9 GPIO_ACTIVE_HIGH>;
+		num-chipselects = <1>;
+		cs-gpios = <&port11 11 GPIO_ACTIVE_HIGH>;
+		status = "ok";
+
+		maxrefdes4x {
+			compatible = "linux,spidev";
+			reg = <0>;
+			spi-max-frequency = <240000>;
+		};
+	};
 };
 
 &extal_clk {
@@ -123,3 +141,7 @@
 		spi-max-frequency = <5000000>;
 	};
 };
+
+&port11 {
+	status = "okay";
+};
-- 
2.7.4

[RFC 3/3] spidev: Add back "linux,spidev" as compatible

[Jacopo Mondi]

spidev is not meant to be configured directly from DTS anymore.
Since we're prototyping, add the "linux,spidev" compatibility string
back

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 drivers/spi/spidev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 6941e04..e767265 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -690,6 +690,7 @@ static int spidev_remove(struct spi_device *spi)
 }
 
 static const struct of_device_id spidev_dt_ids[] = {
+	{ .compatible = "linux,spidev" },
 	{ .compatible = "rohm,dh2228fv" },
 	{},
 };
-- 
2.7.4

RE: [RFC 1/3] gpio-rz: Port to v3.18

[Chris Brandt]

On 12/2/2016, Jacopo Mondi wrote:
> Fix invalid return value in gpio remove function
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  drivers/gpio/gpio-rz.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-rz.c b/drivers/gpio/gpio-rz.c index
> a933dab..cb8f785 100644
> --- a/drivers/gpio/gpio-rz.c
> +++ b/drivers/gpio/gpio-rz.c
> @@ -175,7 +175,8 @@ static int rz_gpio_remove(struct platform_device
> *pdev)  {
>  	struct rz_gpio_priv *p = platform_get_drvdata(pdev);
> 
> -	return gpiochip_remove(&p->gpio_chip);
> +	gpiochip_remove(&p->gpio_chip);
> +	return 0;
>  }
> 
>  static const struct of_device_id rz_gpio_dt_ids[] = {
> --
> 2.7.4


What tree/branch is this based off?



Chris

Re: [RFC 1/3] gpio-rz: Port to v3.18

[jacopo]

Hi Chris,

On 02/12/2016 17:23, Chris Brandt wrote:
> On 12/2/2016, Jacopo Mondi wrote:
>> Fix invalid return value in gpio remove function
>>
>> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
>> ---
>>  drivers/gpio/gpio-rz.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/gpio-rz.c b/drivers/gpio/gpio-rz.c index
>> a933dab..cb8f785 100644
>> --- a/drivers/gpio/gpio-rz.c
>> +++ b/drivers/gpio/gpio-rz.c
>> @@ -175,7 +175,8 @@ static int rz_gpio_remove(struct platform_device
>> *pdev)  {
>>  	struct rz_gpio_priv *p = platform_get_drvdata(pdev);
>>
>> -	return gpiochip_remove(&p->gpio_chip);
>> +	gpiochip_remove(&p->gpio_chip);
>> +	return 0;
>>  }
>>
>>  static const struct of_device_id rz_gpio_dt_ids[] = {
>> --
>> 2.7.4
>
>
> What tree/branch is this based off?
>

Quoting the cover letter:
The series is based on branch "genmai-gpio-and-pfc" of Geert's tree at
git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git
and target Linux v3.18

Thanks
    j



>
>
> Chris
>

RE: [RFC 1/3] gpio-rz: Port to v3.18

[Chris Brandt]

Hi Jacopo,

On 12/2/2016, Jacopo Mondi wrote:
> > What tree/branch is this based off?
> >
> 
> Quoting the cover letter:
> The series is based on branch "genmai-gpio-and-pfc" of Geert's tree at
> git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git
> and target Linux v3.18
> 
> Thanks
>     j

OK. That's what I thought.


I didn't see a cover letter come through, just the 3 patches.

Chris

Re: [RFC 2/3] dts: arm: genmai: Add MAXDESREF4x spidev

[Geert Uytterhoeven]

Hi Jacopo,

On Fri, Dec 2, 2016 at 4:43 PM, Jacopo Mondi <jacopo@jmondi.org> wrote:
> Add device node for the MAX11100 evaluation board connected to Genmai's
> CN2.
> The evaluation kit is connected to 4 GPIO lines configured ad bitbanged

3 GPIO lines?

configured as

> SPI master interface
>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  arch/arm/boot/dts/r7s72100-genmai.dts | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r7s72100-genmai.dts b/arch/arm/boot/dts/r7s72100-genmai.dts
> index 233908b..89a1977 100644
> --- a/arch/arm/boot/dts/r7s72100-genmai.dts
> +++ b/arch/arm/boot/dts/r7s72100-genmai.dts
> @@ -46,6 +46,24 @@
>                 };
>         };
>
> +       spi-gpio {
> +               compatible = "spi-gpio";
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               pinctrl-names = "default";

Why do you need pinctrl-names?
You have no pinctrl configuration.

> +
> +               gpio-miso = <&port11 10 GPIO_ACTIVE_HIGH>;
> +               gpio-sck = <&port11  9 GPIO_ACTIVE_HIGH>;
> +               num-chipselects = <1>;
> +               cs-gpios = <&port11 11 GPIO_ACTIVE_HIGH>;
> +               status = "ok";
> +
> +               maxrefdes4x {

Missing unit address "@0"

> +                       compatible = "linux,spidev";

These days you should use "maxim,max11100", and at that compatible
value to drivers/spi/spidev.c

> +                       reg = <0>;
> +                       spi-max-frequency = <240000>;
> +               };
> +       };
>  };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [RFC 2/3] dts: arm: genmai: Add MAXDESREF4x spidev

[Geert Uytterhoeven]

On Fri, Dec 2, 2016 at 8:23 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> +                       compatible = "linux,spidev";
>
> These days you should use "maxim,max11100", and at that compatible

s/at/add/, of course

> value to drivers/spi/spidev.c

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [RFC 3/3] spidev: Add back "linux,spidev" as compatible

[Geert Uytterhoeven]

Hi Jacopo,

On Fri, Dec 2, 2016 at 4:43 PM, Jacopo Mondi <jacopo@jmondi.org> wrote:
> spidev is not meant to be configured directly from DTS anymore.
> Since we're prototyping, add the "linux,spidev" compatibility string
> back

I guess you needed this because you used "linux,spidev" in your DTS?
With "spidev", it should work out-of-the-box.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [RFC 3/3] spidev: Add back "linux,spidev" as compatible

[jacopo]

Hi Geert,

On 03/12/2016 11:30, Geert Uytterhoeven wrote:
> Hi Jacopo,
>
> On Fri, Dec 2, 2016 at 4:43 PM, Jacopo Mondi <jacopo@jmondi.org> wrote:
>> spidev is not meant to be configured directly from DTS anymore.
>> Since we're prototyping, add the "linux,spidev" compatibility string
>> back
>
> I guess you needed this because you used "linux,spidev" in your DTS?
> With "spidev", it should work out-of-the-box.
>

Oh, yes it does!
I can drop this patch and use "spidev" in [2/3]

Thanks
    j



> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
>

[RFCv2 0/3] Enable and test MAXREFDES4# on Genmai board

[Jacopo Mondi]

Hello Magnus and Geert, list,
   this patch series enable the creation of a spidev device though which
interface to a MAXREFDES4# MAX11100-ADC evaluation kit connected to Genmai
CON2 expansion header.

The series is not intended for inclusion but will probably serve as base
for future integration of MAX11100 ADC driver.

The series is based on branch "genmai-gpio-and-pfc" of Geert's tree at
git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git
and target Linux v3.18

The series fix a compilation error for RZ gpio driver and register a
spidev device on a gpio based SPI master.

The test bed is setup as:

P11_11 (CN2 pin 5) connected as CS
P11_10 (CN2 pin 6) connected as MISO
P11_9  (CN2 pin 7) connected as SCLK
P11_8  (CN2 pin 8) connected as AIN

The ADC input is connected to gpio port 11 pin 8 (gpio863) and ADC
functionalities have been tested reading the results of successive
analog-to-digital conversions and verifying they match the gpio863
output value.

Thanks
   j

v1 -> v2:
    * use "spidev" as compatible string in v1 [2/3] and drop [3/3]
      consequentially.
    * incorporate Geert's comments in [2/3] DTS file

Jacopo Mondi (2):
  gpio-rz: Port to v3.18
  dts: arm: genmai: Add MAXDESREF4x spidev

 arch/arm/boot/dts/r7s72100-genmai.dts | 21 +++++++++++++++++++++
 drivers/gpio/gpio-rz.c                |  3 ++-
 2 files changed, 23 insertions(+), 1 deletion(-)

-- 
2.7.4

[RFCv2 1/2] gpio-rz: Port to v3.18

[Jacopo Mondi]

Fix invalid return value in gpio remove function

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 drivers/gpio/gpio-rz.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-rz.c b/drivers/gpio/gpio-rz.c
index a933dab..cb8f785 100644
--- a/drivers/gpio/gpio-rz.c
+++ b/drivers/gpio/gpio-rz.c
@@ -175,7 +175,8 @@ static int rz_gpio_remove(struct platform_device *pdev)
 {
 	struct rz_gpio_priv *p = platform_get_drvdata(pdev);
 
-	return gpiochip_remove(&p->gpio_chip);
+	gpiochip_remove(&p->gpio_chip);
+	return 0;
 }
 
 static const struct of_device_id rz_gpio_dt_ids[] = {
-- 
2.7.4

[RFCv2 2/2] dts: arm: genmai: Add MAXDESREF4x spidev

[Jacopo Mondi]

Add device node for the MAX11100 evaluation board connected to Genmai's
CN2.
The evaluation kit is connected to 3 GPIO lines configured as bitbanged
SPI master interface.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 arch/arm/boot/dts/r7s72100-genmai.dts | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/arch/arm/boot/dts/r7s72100-genmai.dts b/arch/arm/boot/dts/r7s72100-genmai.dts
index 233908b..659efbf 100644
--- a/arch/arm/boot/dts/r7s72100-genmai.dts
+++ b/arch/arm/boot/dts/r7s72100-genmai.dts
@@ -46,6 +46,23 @@
 		};
 	};
 
+	spi-gpio {
+		compatible = "spi-gpio";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		gpio-miso = <&port11 10 GPIO_ACTIVE_HIGH>;
+		gpio-sck = <&port11  9 GPIO_ACTIVE_HIGH>;
+		num-chipselects = <1>;
+		cs-gpios = <&port11 11 GPIO_ACTIVE_HIGH>;
+		status = "ok";
+
+		maxrefdes4x@0 {
+			compatible = "spidev";
+			reg = <0>;
+			spi-max-frequency = <240000>;
+		};
+	};
 };
 
 &extal_clk {
@@ -123,3 +140,7 @@
 		spi-max-frequency = <5000000>;
 	};
 };
+
+&port11 {
+	status = "okay";
+};
-- 
2.7.4