* [PATCH RFC] [media] m5mols: add missing dependency on VIDEO_IR_I2C
@ 2016-12-13 5:44 Nicholas Mc Guire
[not found] ` <CGME20170329095611epcas1p38e8a9d321864202ce47de1d99ba578ce@epcas1p3.samsung.com>
0 siblings, 1 reply; 3+ messages in thread
From: Nicholas Mc Guire @ 2016-12-13 5:44 UTC (permalink / raw)
To: Kyungmin Park
Cc: HeungJun Kim, Mauro Carvalho Chehab, linux-media, linux-kernel,
Nicholas Mc Guire
The Depends on: tag in Kconfig for CONFIG_VIDEO_M5MOLS does not list
VIDEO_IR_I2C so Kconfig displays the dependencies needed so the M-5MOLS
driver can not be found.
Fixes: commit cb7a01ac324b ("[media] move i2c files into drivers/media/i2c")
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
searching for VIDEO_M5MOLS in menuconfig currently shows the following
dependencies
Depends on: MEDIA_SUPPORT [=m] && I2C [=y] && VIDEO_V4L2 [=m] && \
VIDEO_V4L2_SUBDEV_API [=y] && MEDIA_CAMERA_SUPPORT [=y]
but as the default settings include MEDIA_SUBDRV_AUTOSELECT=y the
"I2C module for IR" submenu (CONFIG_VIDEO_IR_I2C) is not displayed
adding the VIDEO_IR_I2C to the dependency list makes this clear
Q: should a patch like this carry a Fixes: tag ?
Patch was tested against: x86_64_defconfig
Patch is against 4.9.0 (localversion-next is next-20161212)
drivers/media/i2c/m5mols/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/m5mols/Kconfig b/drivers/media/i2c/m5mols/Kconfig
index dc8c250..6847a1b 100644
--- a/drivers/media/i2c/m5mols/Kconfig
+++ b/drivers/media/i2c/m5mols/Kconfig
@@ -1,6 +1,6 @@
config VIDEO_M5MOLS
tristate "Fujitsu M-5MOLS 8MP sensor support"
- depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
+ depends on I2C && VIDEO_IR_I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
depends on MEDIA_CAMERA_SUPPORT
---help---
This driver supports Fujitsu M-5MOLS camera sensor with ISP
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RFC] [media] m5mols: add missing dependency on VIDEO_IR_I2C
[not found] ` <CGME20170329095611epcas1p38e8a9d321864202ce47de1d99ba578ce@epcas1p3.samsung.com>
@ 2017-03-29 9:56 ` Sylwester Nawrocki
2017-03-29 10:43 ` Nicholas Mc Guire
0 siblings, 1 reply; 3+ messages in thread
From: Sylwester Nawrocki @ 2017-03-29 9:56 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: Kyungmin Park, Mauro Carvalho Chehab, linux-media, linux-kernel
On 12/13/2016 06:44 AM, Nicholas Mc Guire wrote:
> The Depends on: tag in Kconfig for CONFIG_VIDEO_M5MOLS does not list
> VIDEO_IR_I2C so Kconfig displays the dependencies needed so the M-5MOLS
> driver can not be found.
>
> Fixes: commit cb7a01ac324b ("[media] move i2c files into drivers/media/i2c")
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
>
> searching for VIDEO_M5MOLS in menuconfig currently shows the following
> dependencies
> Depends on: MEDIA_SUPPORT [=m] && I2C [=y] && VIDEO_V4L2 [=m] && \
> VIDEO_V4L2_SUBDEV_API [=y] && MEDIA_CAMERA_SUPPORT [=y]
> but as the default settings include MEDIA_SUBDRV_AUTOSELECT=y the
> "I2C module for IR" submenu (CONFIG_VIDEO_IR_I2C) is not displayed
> adding the VIDEO_IR_I2C to the dependency list makes this clear
> drivers/media/i2c/m5mols/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/m5mols/Kconfig b/drivers/media/i2c/m5mols/Kconfig
> index dc8c250..6847a1b 100644
> --- a/drivers/media/i2c/m5mols/Kconfig
> +++ b/drivers/media/i2c/m5mols/Kconfig
> @@ -1,6 +1,6 @@
> config VIDEO_M5MOLS
> tristate "Fujitsu M-5MOLS 8MP sensor support"
> - depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
> + depends on I2C && VIDEO_IR_I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
There should be no need to enable the "I2C module for IR" to use m5mols driver,
so the bug fix needs to be somewhere else.
--
Thanks,
Sylwester
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RFC] [media] m5mols: add missing dependency on VIDEO_IR_I2C
2017-03-29 9:56 ` Sylwester Nawrocki
@ 2017-03-29 10:43 ` Nicholas Mc Guire
0 siblings, 0 replies; 3+ messages in thread
From: Nicholas Mc Guire @ 2017-03-29 10:43 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: Nicholas Mc Guire, Kyungmin Park, Mauro Carvalho Chehab,
linux-media, linux-kernel
On Wed, Mar 29, 2017 at 11:56:08AM +0200, Sylwester Nawrocki wrote:
> On 12/13/2016 06:44 AM, Nicholas Mc Guire wrote:
> >The Depends on: tag in Kconfig for CONFIG_VIDEO_M5MOLS does not list
> >VIDEO_IR_I2C so Kconfig displays the dependencies needed so the M-5MOLS
> >driver can not be found.
> >
> >Fixes: commit cb7a01ac324b ("[media] move i2c files into drivers/media/i2c")
> >Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> >---
> >
> >searching for VIDEO_M5MOLS in menuconfig currently shows the following
> >dependencies
> > Depends on: MEDIA_SUPPORT [=m] && I2C [=y] && VIDEO_V4L2 [=m] && \
> > VIDEO_V4L2_SUBDEV_API [=y] && MEDIA_CAMERA_SUPPORT [=y]
> >but as the default settings include MEDIA_SUBDRV_AUTOSELECT=y the
> >"I2C module for IR" submenu (CONFIG_VIDEO_IR_I2C) is not displayed
> >adding the VIDEO_IR_I2C to the dependency list makes this clear
>
> > drivers/media/i2c/m5mols/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/media/i2c/m5mols/Kconfig b/drivers/media/i2c/m5mols/Kconfig
> >index dc8c250..6847a1b 100644
> >--- a/drivers/media/i2c/m5mols/Kconfig
> >+++ b/drivers/media/i2c/m5mols/Kconfig
> >@@ -1,6 +1,6 @@
> > config VIDEO_M5MOLS
> > tristate "Fujitsu M-5MOLS 8MP sensor support"
> >- depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
> >+ depends on I2C && VIDEO_IR_I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
>
> There should be no need to enable the "I2C module for IR" to use m5mols
> driver, so the bug fix needs to be somewhere else.
>
yup - my bad - not clear how I came to that conclusion, guess it was due
to the indirection of VIDEO_M5MOLS needing !CONFIG_MEDIA_SUBDRV_AUTOSELECT
Step-by-step its:
0) x86_64_defconfig
Depends on: MEDIA_SUPPORT [=n] && I2C [=y] && VIDEO_V4L2 [=n] && VIDEO_V4L2_SUBDEV_API [=n] && MEDIA_CAMERA_SUPPORT [=n]
1) <M> Multimedia support --->
Depends on: MEDIA_SUPPORT [=m] && I2C [=y] && VIDEO_V4L2 [=n] && VIDEO_V4L2_SUBDEV_API [=n] && MEDIA_CAMERA_SUPPORT [=n]
2) [*] Cameras/video grabbers support
Depends on: MEDIA_SUPPORT [=m] && I2C [=y] && VIDEO_V4L2 [=m] && VIDEO_V4L2_SUBDEV_API [=n] && MEDIA_CAMERA_SUPPORT [=y]
3) [*] Media Controller API (NEW)
[*] V4L2 sub-device userspace API (NEW)
Depends on: MEDIA_SUPPORT [=m] && I2C [=y] && VIDEO_V4L2 [=m] && VIDEO_V4L2_SUBDEV_API [=y] && MEDIA_CAMERA_SUPPORT [=y]
So now all listed dependencies are satisfied but the M-5MOLS drive is not
visible du to default CONFIG_MEDIA_SUBDRV_AUTOSELECT=y
Not sure how I ended up with the VIDEO_IR_I2C dependency - which as you
state - is wrong. though VIDEO_M5MOLS probably needs a
!CONFIG_MEDIA_SUBDRV_AUTOSELECT in the dependency list though.
thx!
hofrat
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-29 10:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-13 5:44 [PATCH RFC] [media] m5mols: add missing dependency on VIDEO_IR_I2C Nicholas Mc Guire
[not found] ` <CGME20170329095611epcas1p38e8a9d321864202ce47de1d99ba578ce@epcas1p3.samsung.com>
2017-03-29 9:56 ` Sylwester Nawrocki
2017-03-29 10:43 ` Nicholas Mc Guire
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.