[PATCH] aacraid: remove wildcard for series 9 controllers

[PATCH] aacraid: remove wildcard for series 9 controllers

[Don Brace]

From: Kevin Barnett <kevin.barnett@microsemi.com>

The ID we want to remove from the aacraid driver will not be available until Q1 next year,
so no customer currently has it yet. If they are running an older kernel, the aacraid driver
will support this ID but in 'sync' mode, their servers will continue to boot.

If they upgrade to a newer kernel and do not know  to configure the smartpqi
driver and the system fails to boot, they can fall back to the previous
kernel and configure the smartpqi driver.

This patch is for newer kernels going forward. We need to eliminate the
duplication for newer kernels. If both drivers support the same ID
they will have to know how to rebuild their initrd with a specific driver
order. Customers that have servers configured with both older aacraid devices
and the newer smartpqi devices will definitely have to do this. Having to
rebuild the kernel with smartpqi enabled would seem to be an easier
customer experience.

The officially supported driver for this ID is smartpqi.

This patch has been applied to 4.10/scsi-queue


Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Signed-off-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 drivers/scsi/aacraid/linit.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 79871f3..d5b26fa 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/aacraid/linit.c
@@ -160,7 +160,6 @@ static const struct pci_device_id aac_pci_tbl[] = {
 	{ 0x9005, 0x028b, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 62 }, /* Adaptec PMC Series 6 (Tupelo) */
 	{ 0x9005, 0x028c, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 63 }, /* Adaptec PMC Series 7 (Denali) */
 	{ 0x9005, 0x028d, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 64 }, /* Adaptec PMC Series 8 */
-	{ 0x9005, 0x028f, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 65 }, /* Adaptec PMC Series 9 */
 	{ 0,}
 };
 MODULE_DEVICE_TABLE(pci, aac_pci_tbl);
@@ -239,7 +238,6 @@ static struct aac_driver_ident aac_drivers[] = {
 	{ aac_src_init, "aacraid", "ADAPTEC ", "RAID            ", 2, AAC_QUIRK_SRC }, /* Adaptec PMC Series 6 (Tupelo) */
 	{ aac_srcv_init, "aacraid", "ADAPTEC ", "RAID            ", 2, AAC_QUIRK_SRC }, /* Adaptec PMC Series 7 (Denali) */
 	{ aac_srcv_init, "aacraid", "ADAPTEC ", "RAID            ", 2, AAC_QUIRK_SRC }, /* Adaptec PMC Series 8 */
-	{ aac_srcv_init, "aacraid", "ADAPTEC ", "RAID            ", 2, AAC_QUIRK_SRC } /* Adaptec PMC Series 9 */
 };
 
 /**

Re: [PATCH] aacraid: remove wildcard for series 9 controllers

[Greg KH]

On Thu, Dec 15, 2016 at 05:47:02PM -0600, Don Brace wrote:
> From: Kevin Barnett <kevin.barnett@microsemi.com>
> 
> The ID we want to remove from the aacraid driver will not be available until Q1 next year,
> so no customer currently has it yet. If they are running an older kernel, the aacraid driver
> will support this ID but in 'sync' mode, their servers will continue to boot.
> 
> If they upgrade to a newer kernel and do not know  to configure the smartpqi
> driver and the system fails to boot, they can fall back to the previous
> kernel and configure the smartpqi driver.
> 
> This patch is for newer kernels going forward. We need to eliminate the
> duplication for newer kernels. If both drivers support the same ID
> they will have to know how to rebuild their initrd with a specific driver
> order. Customers that have servers configured with both older aacraid devices
> and the newer smartpqi devices will definitely have to do this. Having to
> rebuild the kernel with smartpqi enabled would seem to be an easier
> customer experience.
> 
> The officially supported driver for this ID is smartpqi.
> 
> This patch has been applied to 4.10/scsi-queue

What does this line mean?

Have you read Documentation/stable_kernel_rules.txt for how to submit
patches to the stable tree?

What should I do with this patch?

thanks,

greg k-h

RE: [PATCH] aacraid: remove wildcard for series 9 controllers

[Don Brace]

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Friday, December 16, 2016 6:35 AM
> To: Don Brace
> Cc: John Hall; Kevin Barnett; Mahesh Rajashekhara; Bader Ali-saleh; Scott
> Teel; Viswas G; Justin Lindley; Scott Benesh; stable@vger.kernel.org
> Subject: Re: [PATCH] aacraid: remove wildcard for series 9 controllers
> 
> EXTERNAL EMAIL
> 
> 
> On Thu, Dec 15, 2016 at 05:47:02PM -0600, Don Brace wrote:
> > From: Kevin Barnett <kevin.barnett@microsemi.com>
> >
> > The ID we want to remove from the aacraid driver will not be available until
> Q1 next year,
> > so no customer currently has it yet. If they are running an older kernel, the
> aacraid driver
> > will support this ID but in 'sync' mode, their servers will continue to boot.
> >
> > If they upgrade to a newer kernel and do not know  to configure the
> smartpqi
> > driver and the system fails to boot, they can fall back to the previous
> > kernel and configure the smartpqi driver.
> >
> > This patch is for newer kernels going forward. We need to eliminate the
> > duplication for newer kernels. If both drivers support the same ID
> > they will have to know how to rebuild their initrd with a specific driver
> > order. Customers that have servers configured with both older aacraid
> devices
> > and the newer smartpqi devices will definitely have to do this. Having to
> > rebuild the kernel with smartpqi enabled would seem to be an easier
> > customer experience.
> >
> > The officially supported driver for this ID is smartpqi.
> >
> > This patch has been applied to 4.10/scsi-queue
> 
> What does this line mean?
> 
> Have you read Documentation/stable_kernel_rules.txt for how to submit
> patches to the stable tree?
> 
> What should I do with this patch?

Sorry about the confusion. This patch has been applied to 4.10 (ae2aae242198) and
I would like to have it applied to 4.9. As it is, there will be an issue in 4.9 where the
aacraid driver will claim smartpqi devices and fail to support it properly.

> 
> thanks,
> 
> greg k-h

Re: [PATCH] aacraid: remove wildcard for series 9 controllers

[Martin K. Petersen]

>>>>> "Don" == Don Brace <don.brace@microsemi.com> writes:

>> Applied to 4.10/scsi-queue.

Don> Can this patch still make into 4.9?

Too late. But you can send it to stable.

-- 
Martin K. Petersen	Oracle Linux Engineering

RE: [PATCH] aacraid: remove wildcard for series 9 controllers

[Don Brace]

> -----Original Message-----
> From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
> Sent: Thursday, December 08, 2016 4:10 PM
> To: Don Brace
> Cc: jejb@linux.vnet.ibm.com; John Hall; Kevin Barnett; Mahesh
> Rajashekhara; Bader Ali-saleh; hch@infradead.org; Scott Teel; Viswas G;
> Justin Lindley; Scott Benesh; elliott@hpe.com; POSWALD@suse.com; linux-
> scsi@vger.kernel.org
> Subject: Re: [PATCH] aacraid: remove wildcard for series 9 controllers
> 
> EXTERNAL EMAIL
> 
> 
> >>>>> "Don" == Don Brace <don.brace@microsemi.com> writes:
> 
> Applied to 4.10/scsi-queue.
> 
> --
> Martin K. Petersen      Oracle Linux Engineering

Can this patch still make into 4.9?
Thanks,
Don Brace

Re: [PATCH] aacraid: remove wildcard for series 9 controllers

[Martin K. Petersen]

>>>>> "Don" == Don Brace <don.brace@microsemi.com> writes:

Applied to 4.10/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

[PATCH] aacraid: remove wildcard for series 9 controllers

[Don Brace]

From: Kevin Barnett <kevin.barnett@microsemi.com>

Depends on smartpqi driver adoption

Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Signed-off-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
 drivers/scsi/aacraid/linit.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 79871f3..d5b26fa 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/aacraid/linit.c
@@ -160,7 +160,6 @@ static const struct pci_device_id aac_pci_tbl[] = {
 	{ 0x9005, 0x028b, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 62 }, /* Adaptec PMC Series 6 (Tupelo) */
 	{ 0x9005, 0x028c, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 63 }, /* Adaptec PMC Series 7 (Denali) */
 	{ 0x9005, 0x028d, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 64 }, /* Adaptec PMC Series 8 */
-	{ 0x9005, 0x028f, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 65 }, /* Adaptec PMC Series 9 */
 	{ 0,}
 };
 MODULE_DEVICE_TABLE(pci, aac_pci_tbl);
@@ -239,7 +238,6 @@ static struct aac_driver_ident aac_drivers[] = {
 	{ aac_src_init, "aacraid", "ADAPTEC ", "RAID            ", 2, AAC_QUIRK_SRC }, /* Adaptec PMC Series 6 (Tupelo) */
 	{ aac_srcv_init, "aacraid", "ADAPTEC ", "RAID            ", 2, AAC_QUIRK_SRC }, /* Adaptec PMC Series 7 (Denali) */
 	{ aac_srcv_init, "aacraid", "ADAPTEC ", "RAID            ", 2, AAC_QUIRK_SRC }, /* Adaptec PMC Series 8 */
-	{ aac_srcv_init, "aacraid", "ADAPTEC ", "RAID            ", 2, AAC_QUIRK_SRC } /* Adaptec PMC Series 9 */
 };
 
 /**