* [PATCH] block: Remove unused member (busy) from struct blk_queue_tag
@ 2016-12-16 4:41 Ritesh Harjani
2016-12-16 10:27 ` Bart Van Assche
2016-12-16 15:19 ` Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: Ritesh Harjani @ 2016-12-16 4:41 UTC (permalink / raw)
To: axboe; +Cc: linux-block, Ritesh Harjani
Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>
---
include/linux/blkdev.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 286b2a2..8369564 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -288,7 +288,6 @@ enum blk_queue_state {
struct blk_queue_tag {
struct request **tag_index; /* map of busy tags */
unsigned long *tag_map; /* bit map of free/busy tags */
- int busy; /* current depth */
int max_depth; /* what we will send to device */
int real_max_depth; /* what the array can hold */
atomic_t refcnt; /* map can be shared */
--
1.8.2.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] block: Remove unused member (busy) from struct blk_queue_tag
2016-12-16 4:41 [PATCH] block: Remove unused member (busy) from struct blk_queue_tag Ritesh Harjani
@ 2016-12-16 10:27 ` Bart Van Assche
2016-12-16 10:32 ` Ritesh Harjani
2016-12-16 15:19 ` Jens Axboe
1 sibling, 1 reply; 4+ messages in thread
From: Bart Van Assche @ 2016-12-16 10:27 UTC (permalink / raw)
To: Ritesh Harjani, axboe; +Cc: linux-block, Bart Van Assche
On 12/16/2016 05:41 AM, Ritesh Harjani wrote:
> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>
> ---
> include/linux/blkdev.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 286b2a2..8369564 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -288,7 +288,6 @@ enum blk_queue_state {
> struct blk_queue_tag {
> struct request **tag_index; /* map of busy tags */
> unsigned long *tag_map; /* bit map of free/busy tags */
> - int busy; /* current depth */
> int max_depth; /* what we will send to device */
> int real_max_depth; /* what the array can hold */
> atomic_t refcnt; /* map can be shared */
>
That's a good catch. Was this detected manually or did you use a tool to
detect this? Anyway:
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: Remove unused member (busy) from struct blk_queue_tag
2016-12-16 10:27 ` Bart Van Assche
@ 2016-12-16 10:32 ` Ritesh Harjani
0 siblings, 0 replies; 4+ messages in thread
From: Ritesh Harjani @ 2016-12-16 10:32 UTC (permalink / raw)
To: Bart Van Assche, axboe; +Cc: linux-block, Bart Van Assche
On 12/16/2016 3:57 PM, Bart Van Assche wrote:
> On 12/16/2016 05:41 AM, Ritesh Harjani wrote:
>> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>
>> ---
>> include/linux/blkdev.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
>> index 286b2a2..8369564 100644
>> --- a/include/linux/blkdev.h
>> +++ b/include/linux/blkdev.h
>> @@ -288,7 +288,6 @@ enum blk_queue_state {
>> struct blk_queue_tag {
>> struct request **tag_index; /* map of busy tags */
>> unsigned long *tag_map; /* bit map of free/busy tags */
>> - int busy; /* current depth */
>> int max_depth; /* what we will send to device */
>> int real_max_depth; /* what the array can hold */
>> atomic_t refcnt; /* map can be shared */
>>
>
> That's a good catch. Was this detected manually or did you use a tool to
> detect this? Anyway:
Manually, while I was reading this code.
>
> Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: Remove unused member (busy) from struct blk_queue_tag
2016-12-16 4:41 [PATCH] block: Remove unused member (busy) from struct blk_queue_tag Ritesh Harjani
2016-12-16 10:27 ` Bart Van Assche
@ 2016-12-16 15:19 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2016-12-16 15:19 UTC (permalink / raw)
To: Ritesh Harjani; +Cc: linux-block
On 12/15/2016 09:41 PM, Ritesh Harjani wrote:
> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>
> ---
> include/linux/blkdev.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 286b2a2..8369564 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -288,7 +288,6 @@ enum blk_queue_state {
> struct blk_queue_tag {
> struct request **tag_index; /* map of busy tags */
> unsigned long *tag_map; /* bit map of free/busy tags */
> - int busy; /* current depth */
> int max_depth; /* what we will send to device */
> int real_max_depth; /* what the array can hold */
> atomic_t refcnt; /* map can be shared */
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-16 15:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-16 4:41 [PATCH] block: Remove unused member (busy) from struct blk_queue_tag Ritesh Harjani
2016-12-16 10:27 ` Bart Van Assche
2016-12-16 10:32 ` Ritesh Harjani
2016-12-16 15:19 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.