* [PATCH linux 0/7] drivers: hwmon: Add On-Chip Controller driver
@ 2016-12-16 20:37 eajames.ibm
2016-12-20 1:12 ` Andrew Jeffery
0 siblings, 1 reply; 2+ messages in thread
From: eajames.ibm @ 2016-12-16 20:37 UTC (permalink / raw)
To: openbmc; +Cc: andrew, joel, Edward A. James
From: "Edward A. James" <eajames@us.ibm.com>
This patchset adds a hwmon driver to support the OCC (On-Chip Controller)
on the IBM POWER8 and POWER9 processors, from a BMC (Baseboard Management
Controller). The OCC is an embedded processor that provides real time
power and thermal monitoring.
The driver provides an interface on a BMC to poll OCC sensor data, set
user power caps, and perform some basic OCC error handling. It interfaces
with userspace through hwmon.
The driver is currently functional only for the OCC on POWER8 chips.
Communicating with the POWER9 OCC requries FSI support.
Edward A. James (7):
hwmon: Add core On-Chip Controller support for POWER CPUs
hwmon: occ: Add sysfs interface
hwmon: occ: Add I2C transport implementation for SCOM operations
hwmon: occ: Add callbacks for parsing P8 OCC datastructures
hwmon: occ: Add hwmon implementation for the P8 OCC
arm: aspeed: dts: Add I2C POWER8 OCC compatible string
hwmon: occ: Add callbacks for parsing P9 OCC datastructures
.../devicetree/bindings/i2c/i2c-ibm-occ.txt | 13 +
Documentation/hwmon/occ | 100 ++++
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 9 +
drivers/hwmon/Kconfig | 2 +
drivers/hwmon/Makefile | 1 +
drivers/hwmon/occ/Kconfig | 29 ++
drivers/hwmon/occ/Makefile | 2 +
drivers/hwmon/occ/occ.c | 519 +++++++++++++++++++++
drivers/hwmon/occ/occ.h | 86 ++++
drivers/hwmon/occ/occ_p8.c | 217 +++++++++
drivers/hwmon/occ/occ_p8.h | 30 ++
drivers/hwmon/occ/occ_p8_i2c.c | 141 ++++++
drivers/hwmon/occ/occ_p9.c | 243 ++++++++++
drivers/hwmon/occ/occ_p9.h | 30 ++
drivers/hwmon/occ/occ_scom_i2c.c | 67 +++
drivers/hwmon/occ/occ_scom_i2c.h | 26 ++
drivers/hwmon/occ/occ_sysfs.c | 492 +++++++++++++++++++
drivers/hwmon/occ/occ_sysfs.h | 52 +++
drivers/hwmon/occ/scom.h | 48 ++
19 files changed, 2107 insertions(+)
create mode 100644 Documentation/devicetree/bindings/i2c/i2c-ibm-occ.txt
create mode 100644 Documentation/hwmon/occ
create mode 100644 drivers/hwmon/occ/Kconfig
create mode 100644 drivers/hwmon/occ/Makefile
create mode 100644 drivers/hwmon/occ/occ.c
create mode 100644 drivers/hwmon/occ/occ.h
create mode 100644 drivers/hwmon/occ/occ_p8.c
create mode 100644 drivers/hwmon/occ/occ_p8.h
create mode 100644 drivers/hwmon/occ/occ_p8_i2c.c
create mode 100644 drivers/hwmon/occ/occ_p9.c
create mode 100644 drivers/hwmon/occ/occ_p9.h
create mode 100644 drivers/hwmon/occ/occ_scom_i2c.c
create mode 100644 drivers/hwmon/occ/occ_scom_i2c.h
create mode 100644 drivers/hwmon/occ/occ_sysfs.c
create mode 100644 drivers/hwmon/occ/occ_sysfs.h
create mode 100644 drivers/hwmon/occ/scom.h
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH linux 0/7] drivers: hwmon: Add On-Chip Controller driver
2016-12-16 20:37 [PATCH linux 0/7] drivers: hwmon: Add On-Chip Controller driver eajames.ibm
@ 2016-12-20 1:12 ` Andrew Jeffery
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Jeffery @ 2016-12-20 1:12 UTC (permalink / raw)
To: eajames.ibm, openbmc; +Cc: joel, Edward A. James
[-- Attachment #1: Type: text/plain, Size: 4712 bytes --]
Hi Eddie,
On Fri, 2016-12-16 at 14:37 -0600, eajames.ibm@gmail.com wrote:
> > From: "Edward A. James" <eajames@us.ibm.com>
>
> This patchset adds a hwmon driver to support the OCC (On-Chip Controller)
> on the IBM POWER8 and POWER9 processors, from a BMC (Baseboard Management
> Controller). The OCC is an embedded processor that provides real time
> power and thermal monitoring.
>
> The driver provides an interface on a BMC to poll OCC sensor data, set
> user power caps, and perform some basic OCC error handling. It interfaces
> with userspace through hwmon.
>
> The driver is currently functional only for the OCC on POWER8 chips.
> Communicating with the POWER9 OCC requries FSI support.
>
> Edward A. James (7):
> hwmon: Add core On-Chip Controller support for POWER CPUs
> hwmon: occ: Add sysfs interface
> hwmon: occ: Add I2C transport implementation for SCOM operations
> hwmon: occ: Add callbacks for parsing P8 OCC datastructures
> hwmon: occ: Add hwmon implementation for the P8 OCC
> arm: aspeed: dts: Add I2C POWER8 OCC compatible string
> hwmon: occ: Add callbacks for parsing P9 OCC datastructures
I'm happy with how these are looking. I think it's time to send the
next series upstream once you've addressed the issues in what here is
v7.
When sending upstream, please reset the reroll-count to 0 as upstream
haven't yet participated in the reviews so it makes no sense for them
to see the patches as a "v8" of the series.
Also, please make sure to Cc Joel and myself, though I suspect `git
send-email` will automatically add me as I appear in the tags. I don't
know if Yi's interested in being Cc'ed given he authored the original
driver, maybe ask him.
Finally, it's good form to thread the patches under the cover letter.
This makes the mail easy to find and hide in people's inboxes. I've
mentioned this several times but it has received no attention, but
*please* sort it out before you send the patches upstream. Feel free to
use my address as a testing ground.
Thanks for putting in the effort to get this code cleaned up.
Andrew
>
> .../devicetree/bindings/i2c/i2c-ibm-occ.txt | 13 +
> Documentation/hwmon/occ | 100 ++++
> arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 9 +
> drivers/hwmon/Kconfig | 2 +
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/occ/Kconfig | 29 ++
> drivers/hwmon/occ/Makefile | 2 +
> drivers/hwmon/occ/occ.c | 519 +++++++++++++++++++++
> drivers/hwmon/occ/occ.h | 86 ++++
> drivers/hwmon/occ/occ_p8.c | 217 +++++++++
> drivers/hwmon/occ/occ_p8.h | 30 ++
> drivers/hwmon/occ/occ_p8_i2c.c | 141 ++++++
> drivers/hwmon/occ/occ_p9.c | 243 ++++++++++
> drivers/hwmon/occ/occ_p9.h | 30 ++
> drivers/hwmon/occ/occ_scom_i2c.c | 67 +++
> drivers/hwmon/occ/occ_scom_i2c.h | 26 ++
> drivers/hwmon/occ/occ_sysfs.c | 492 +++++++++++++++++++
> drivers/hwmon/occ/occ_sysfs.h | 52 +++
> drivers/hwmon/occ/scom.h | 48 ++
> 19 files changed, 2107 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-ibm-occ.txt
> create mode 100644 Documentation/hwmon/occ
> create mode 100644 drivers/hwmon/occ/Kconfig
> create mode 100644 drivers/hwmon/occ/Makefile
> create mode 100644 drivers/hwmon/occ/occ.c
> create mode 100644 drivers/hwmon/occ/occ.h
> create mode 100644 drivers/hwmon/occ/occ_p8.c
> create mode 100644 drivers/hwmon/occ/occ_p8.h
> create mode 100644 drivers/hwmon/occ/occ_p8_i2c.c
> create mode 100644 drivers/hwmon/occ/occ_p9.c
> create mode 100644 drivers/hwmon/occ/occ_p9.h
> create mode 100644 drivers/hwmon/occ/occ_scom_i2c.c
> create mode 100644 drivers/hwmon/occ/occ_scom_i2c.h
> create mode 100644 drivers/hwmon/occ/occ_sysfs.c
> create mode 100644 drivers/hwmon/occ/occ_sysfs.h
> create mode 100644 drivers/hwmon/occ/scom.h
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-20 1:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-16 20:37 [PATCH linux 0/7] drivers: hwmon: Add On-Chip Controller driver eajames.ibm
2016-12-20 1:12 ` Andrew Jeffery
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.