All of lore.kernel.org
 help / color / mirror / Atom feed
From: Duncan Hare <dh@synoia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v10 3/3] Adding wget
Date: Wed, 18 Apr 2018 15:50:26 +0000 (UTC)	[thread overview]
Message-ID: <1482774235.1805806.1524066626894@mail.yahoo.com> (raw)
In-Reply-To: <CAPnjgZ2KD1ZSb6twmjWH+SA_JXe=XHGNxG2PK9zHtUST2tKCHw@mail.gmail.com>




Hi Duncan,

On 14 April 2018 at 17:43,  <DH@synoia.com> wrote:
>> From: Duncan Hare <DuncanCHare@yahoo.com>
>>
> Why http and wget:
>> END

Why END?
Don't know.  will delete.

>
> Signed-off-by: Duncan Hare <DuncanCHare@yahoo.com>
> ---
>
> Changes in v10: None

There is no change log here. Has nothing changed since v1?
changed c to C for cover meno tag.

This code looks OK to me, but please can you run it through patman? I
see what look like some style errors.
Has passed patman. Only error messages are for packed structures.

How can we create a test for this? Can we add something to test_net.py ?
Do not see why not. It's only an app and has no hardware dependencies. 
One needs a web server and test file, and code the verify the integrity of the test file in local memory.I used a file with line numbers and a pattern repeated on every "line". Make it easy to findinvalid offsets mis ordered packets.
We use nginx as the web server. We used wbox for a while, but then mvbed to nginx. We could not get Apacheconfigured.
For internet test we use a Ubuntu image & nginx on the Amazon cloud. 
The internet path to Amazon does a nice job of scrambling the order of packets.

Regards,
Duncan


   

  reply	other threads:[~2018-04-18 15:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-14 23:43 [U-Boot] [PATCH v10 0/3] Why netboot: DH at synoia.com
2018-04-14 23:43 ` [U-Boot] [PATCH v10 1/3] Adding TCP and wget into u-boot DH at synoia.com
2018-04-30 23:44   ` Joe Hershberger
2018-04-14 23:43 ` [U-Boot] [PATCH v10 2/3] Adding TCP DH at synoia.com
2018-05-01  1:44   ` Joe Hershberger
2018-04-14 23:43 ` [U-Boot] [PATCH v10 3/3] Adding wget DH at synoia.com
2018-04-17 15:10   ` Simon Glass
2018-04-18 15:50     ` Duncan Hare [this message]
     [not found]     ` <217820715.1487025.1524002336830@mail.yahoo.com>
     [not found]       ` <CAPnjgZ3yNbMVJCbNQVDxxQ9RaX1pujxKSopk=s1MNUyb=oAyiQ@mail.gmail.com>
2018-04-23  3:22         ` Duncan Hare
2018-04-25  5:01           ` Simon Glass
2018-04-25 14:33             ` Duncan Hare
2018-04-25 23:44               ` Simon Glass
2018-04-25 23:52                 ` Duncan Hare
2018-05-01  1:54                   ` Joe Hershberger
2018-05-13 21:05                     ` [U-Boot] net: " Duncan Hare
2018-05-13 22:00                       ` Simon Glass
2018-05-14 15:26                         ` Duncan Hare
2018-05-14 19:51                           ` Simon Glass
2018-05-01  1:50     ` [U-Boot] " Joe Hershberger
2018-05-01  2:18   ` Joe Hershberger
2018-05-01  1:57 ` [U-Boot] [PATCH v10 0/3] Why netboot: Joe Hershberger
2018-05-01 21:29   ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1482774235.1805806.1524066626894@mail.yahoo.com \
    --to=dh@synoia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.