All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v10 3/3] Adding wget
Date: Tue, 17 Apr 2018 11:10:39 -0400	[thread overview]
Message-ID: <CAPnjgZ2KD1ZSb6twmjWH+SA_JXe=XHGNxG2PK9zHtUST2tKCHw@mail.gmail.com> (raw)
In-Reply-To: <20180414234336.26636-4-DH@synoia.com>

Hi Duncan,

On 14 April 2018 at 17:43,  <DH@synoia.com> wrote:
> From: Duncan Hare <DuncanCHare@yahoo.com>
>
> Why http and wget:
>
> HTTP is the most efficient file retrieval protocol in common
> use. The client send a single request, after TCP connection,
> to receive a file of any length.
>
> WGET is the application which implements http file transfer
> outside browsers as a file transfer protocol. Versions of
> wget exists on many operating systems.
> END

Why END?

>
> Signed-off-by: Duncan Hare <DuncanCHare@yahoo.com>
> ---
>
> Changes in v10: None

There is no change log here. Has nothing changed since v1?

This code looks OK to me, but please can you run it through patman? I
see what look like some style errors.

How can we create a test for this? Can we add something to test_net.py ?

Regards,
Simon

  reply	other threads:[~2018-04-17 15:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-14 23:43 [U-Boot] [PATCH v10 0/3] Why netboot: DH at synoia.com
2018-04-14 23:43 ` [U-Boot] [PATCH v10 1/3] Adding TCP and wget into u-boot DH at synoia.com
2018-04-30 23:44   ` Joe Hershberger
2018-04-14 23:43 ` [U-Boot] [PATCH v10 2/3] Adding TCP DH at synoia.com
2018-05-01  1:44   ` Joe Hershberger
2018-04-14 23:43 ` [U-Boot] [PATCH v10 3/3] Adding wget DH at synoia.com
2018-04-17 15:10   ` Simon Glass [this message]
2018-04-18 15:50     ` Duncan Hare
     [not found]     ` <217820715.1487025.1524002336830@mail.yahoo.com>
     [not found]       ` <CAPnjgZ3yNbMVJCbNQVDxxQ9RaX1pujxKSopk=s1MNUyb=oAyiQ@mail.gmail.com>
2018-04-23  3:22         ` Duncan Hare
2018-04-25  5:01           ` Simon Glass
2018-04-25 14:33             ` Duncan Hare
2018-04-25 23:44               ` Simon Glass
2018-04-25 23:52                 ` Duncan Hare
2018-05-01  1:54                   ` Joe Hershberger
2018-05-13 21:05                     ` [U-Boot] net: " Duncan Hare
2018-05-13 22:00                       ` Simon Glass
2018-05-14 15:26                         ` Duncan Hare
2018-05-14 19:51                           ` Simon Glass
2018-05-01  1:50     ` [U-Boot] " Joe Hershberger
2018-05-01  2:18   ` Joe Hershberger
2018-05-01  1:57 ` [U-Boot] [PATCH v10 0/3] Why netboot: Joe Hershberger
2018-05-01 21:29   ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ2KD1ZSb6twmjWH+SA_JXe=XHGNxG2PK9zHtUST2tKCHw@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.