* [Qemu-devel] [PATCH V5 0/2] Add new qmp commands to suppurt Xen COLO
@ 2016-12-27 9:38 Zhang Chen
2016-12-27 9:38 ` [Qemu-devel] [PATCH V5 1/2] Add a new qmp command to start/stop replication Zhang Chen
2016-12-27 9:38 ` [Qemu-devel] [PATCH V5 2/2] Add a new qmp command to do checkpoint, query xen replication status Zhang Chen
0 siblings, 2 replies; 6+ messages in thread
From: Zhang Chen @ 2016-12-27 9:38 UTC (permalink / raw)
To: qemu devel, Eric Blake, zhanghailiang
Cc: Jason Wang, Zhang Chen, Li Zhijian, eddie . dong, Bian Naimeng
Xen COLO depend on qemu COLO replication function.
So, We need new qmp commands for Xen to use qemu replication.
Corresponding libxl patches already in xen.git.
Commit ID:
ed37ef1f91c20f0ab162ce60f8c38400b917fa64
COLO: introduce new API to prepare/start/do/get_error/stop replication
a0ddc0b359375b2418213966dfbdbfab593ecc6f
tools/libxl: introduction of libxl__qmp_restore to load qemu state
Zhang Chen (2):
Add a new qmp command to start/stop replication
Add a new qmp command to do checkpoint, query xen replication status
docs/qmp-commands.txt | 42 +++++++++++++++++++++++++++++++
migration/colo.c | 40 +++++++++++++++++++++++++++++
qapi-schema.json | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 151 insertions(+)
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH V5 1/2] Add a new qmp command to start/stop replication
2016-12-27 9:38 [Qemu-devel] [PATCH V5 0/2] Add new qmp commands to suppurt Xen COLO Zhang Chen
@ 2016-12-27 9:38 ` Zhang Chen
2017-01-04 0:42 ` Stefano Stabellini
2016-12-27 9:38 ` [Qemu-devel] [PATCH V5 2/2] Add a new qmp command to do checkpoint, query xen replication status Zhang Chen
1 sibling, 1 reply; 6+ messages in thread
From: Zhang Chen @ 2016-12-27 9:38 UTC (permalink / raw)
To: qemu devel, Eric Blake, zhanghailiang
Cc: Jason Wang, Zhang Chen, Li Zhijian, eddie . dong, Bian Naimeng,
Wen Congyang
We can call this qmp command to start/stop replication outside of qemu.
Like Xen colo need this function.
Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Signed-off-by: Wen Congyang <wencongyang@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
docs/qmp-commands.txt | 18 ++++++++++++++++++
migration/colo.c | 23 +++++++++++++++++++++++
qapi-schema.json | 19 +++++++++++++++++++
3 files changed, 60 insertions(+)
diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt
index abf210a..d182147 100644
--- a/docs/qmp-commands.txt
+++ b/docs/qmp-commands.txt
@@ -432,6 +432,24 @@ Example:
"arguments": { "enable": true } }
<- { "return": {} }
+xen-set-replication
+-------------------
+
+Enable or disable replication.
+
+Arguments:
+
+- "enable": Enable it or disable it.
+- "primary": True for primary or false for secondary.
+- "failover": Enable failover when stopping replication, but cannot be
+ specified if 'enable' is true (optional, default false).
+
+Example:
+
+-> { "execute": "xen-set-replication",
+ "arguments": {"enable": true, "primary": false} }
+<- { "return": {} }
+
migrate
-------
diff --git a/migration/colo.c b/migration/colo.c
index 93c85c5..6fc2ade 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -19,6 +19,8 @@
#include "qemu/error-report.h"
#include "qapi/error.h"
#include "migration/failover.h"
+#include "replication.h"
+#include "qmp-commands.h"
#define COLO_BUFFER_BASE_SIZE (4 * 1024 * 1024)
@@ -104,6 +106,27 @@ void colo_do_failover(MigrationState *s)
}
}
+void qmp_xen_set_replication(bool enable, bool primary,
+ bool has_failover, bool failover,
+ Error **errp)
+{
+ ReplicationMode mode = primary ?
+ REPLICATION_MODE_PRIMARY :
+ REPLICATION_MODE_SECONDARY;
+
+ if (has_failover && enable) {
+ error_setg(errp, "Parameter 'failover' is only for"
+ " stopping replication");
+ return;
+ }
+
+ if (enable) {
+ replication_start_all(mode, errp);
+ } else {
+ replication_stop_all(failover, failover ? NULL : errp);
+ }
+}
+
static void colo_send_message(QEMUFile *f, COLOMessage msg,
Error **errp)
{
diff --git a/qapi-schema.json b/qapi-schema.json
index f3e9bfc..78802f4 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -4676,6 +4676,25 @@
{ 'command': 'xen-load-devices-state', 'data': {'filename': 'str'} }
##
+# @xen-set-replication
+#
+# Enable or disable replication.
+#
+# @enable: true to enable, false to disable.
+#
+# @primary: true for primary or false for secondary.
+#
+# @failover: #optional true to do failover, false to stop. but cannot be
+# specified if 'enable' is true. default value is false.
+#
+# Returns: nothing.
+#
+# Since: 2.9
+##
+{ 'command': 'xen-set-replication',
+ 'data': { 'enable': 'bool', 'primary': 'bool', '*failover' : 'bool' } }
+
+##
# @GICCapability:
#
# The struct describes capability for a specific GIC (Generic
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH V5 2/2] Add a new qmp command to do checkpoint, query xen replication status
2016-12-27 9:38 [Qemu-devel] [PATCH V5 0/2] Add new qmp commands to suppurt Xen COLO Zhang Chen
2016-12-27 9:38 ` [Qemu-devel] [PATCH V5 1/2] Add a new qmp command to start/stop replication Zhang Chen
@ 2016-12-27 9:38 ` Zhang Chen
2017-01-04 20:40 ` Eric Blake
1 sibling, 1 reply; 6+ messages in thread
From: Zhang Chen @ 2016-12-27 9:38 UTC (permalink / raw)
To: qemu devel, Eric Blake, zhanghailiang
Cc: Jason Wang, Zhang Chen, Li Zhijian, eddie . dong, Bian Naimeng,
Wen Congyang
We can call this qmp command to do checkpoint outside of qemu.
Like Xen colo need this function.
Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Signed-off-by: Wen Congyang <wencongyang@gmail.com>
---
docs/qmp-commands.txt | 24 ++++++++++++++++++++++++
migration/colo.c | 17 +++++++++++++++++
qapi-schema.json | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 91 insertions(+)
diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt
index d182147..a146745 100644
--- a/docs/qmp-commands.txt
+++ b/docs/qmp-commands.txt
@@ -450,6 +450,30 @@ Example:
"arguments": {"enable": true, "primary": false} }
<- { "return": {} }
+query-xen-replication-status
+----------------------------
+
+Query replication status when vm is running.
+
+Arguments: None.
+
+Example:
+
+-> { "execute": "query-xen-replication-status" }
+<- { "return": { "status": "normal" } }
+
+xen-do-checkpoint
+-----------------
+
+Xen use this command to notify replication to do checkpoint.
+
+Arguments: None.
+
+Example:
+
+-> { "execute": "xen-do-checkpoint" }
+<- { "return": {} }
+
migrate
-------
diff --git a/migration/colo.c b/migration/colo.c
index 6fc2ade..7fc9f8a 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -127,6 +127,23 @@ void qmp_xen_set_replication(bool enable, bool primary,
}
}
+ReplicationErrorResult *qmp_query_xen_replication_status(Error **errp)
+{
+ Error *err = NULL;
+ ReplicationErrorResult *result = g_new0(ReplicationErrorResult, 1);
+ replication_get_error_all(&err);
+ result->status = err ?
+ REPLICATION_ERROR_STATUS_ERROR :
+ REPLICATION_ERROR_STATUS_NORMAL;
+ error_free(err);
+ return result;
+}
+
+void qmp_xen_do_checkpoint(Error **errp)
+{
+ replication_do_checkpoint_all(errp);
+}
+
static void colo_send_message(QEMUFile *f, COLOMessage msg,
Error **errp)
{
diff --git a/qapi-schema.json b/qapi-schema.json
index 78802f4..6c162a5 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -4695,6 +4695,56 @@
'data': { 'enable': 'bool', 'primary': 'bool', '*failover' : 'bool' } }
##
+# @ReplicationErrorStatus
+#
+# Describe the status of replication error.
+#
+# @error: Replication have a error.
+#
+# @normal: Replication running normal.
+#
+# Since 2.9
+##
+{ 'enum': 'ReplicationErrorStatus',
+ 'data': [ 'error', 'normal' ] }
+
+##
+# @ReplicationErrorResult
+#
+# The result format for 'xen-get-replication-error'.
+#
+# @status: enum of @ReplicationErrorStatus, which shows current
+# replication error status
+#
+# Since 2.9
+##
+{ 'struct': 'ReplicationErrorResult',
+ 'data': { 'status': 'ReplicationErrorStatus'} }
+
+##
+# @query-xen-replication-status
+#
+# Query replication error that occurs when the vm is running.
+#
+# Returns: A @ReplicationErrorResult objects showing the status.
+#
+# Since: 2.9
+##
+{ 'command': 'query-xen-replication-status',
+ 'returns': 'ReplicationErrorResult' }
+
+##
+# @xen-do-checkpoint
+#
+# Xen use this command to notify replication to do checkpoint.
+#
+# Returns: nothing.
+#
+# Since: 2.9
+##
+{ 'command': 'xen-do-checkpoint' }
+
+##
# @GICCapability:
#
# The struct describes capability for a specific GIC (Generic
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH V5 1/2] Add a new qmp command to start/stop replication
2016-12-27 9:38 ` [Qemu-devel] [PATCH V5 1/2] Add a new qmp command to start/stop replication Zhang Chen
@ 2017-01-04 0:42 ` Stefano Stabellini
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Stabellini @ 2017-01-04 0:42 UTC (permalink / raw)
To: Zhang Chen
Cc: qemu devel, Eric Blake, zhanghailiang, Li Zhijian, Jason Wang,
eddie . dong, Wen Congyang, Bian Naimeng
On Tue, 27 Dec 2016, Zhang Chen wrote:
> We can call this qmp command to start/stop replication outside of qemu.
> Like Xen colo need this function.
>
> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
> Signed-off-by: Wen Congyang <wencongyang@gmail.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> docs/qmp-commands.txt | 18 ++++++++++++++++++
> migration/colo.c | 23 +++++++++++++++++++++++
> qapi-schema.json | 19 +++++++++++++++++++
> 3 files changed, 60 insertions(+)
>
> diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt
> index abf210a..d182147 100644
> --- a/docs/qmp-commands.txt
> +++ b/docs/qmp-commands.txt
> @@ -432,6 +432,24 @@ Example:
> "arguments": { "enable": true } }
> <- { "return": {} }
>
> +xen-set-replication
> +-------------------
> +
> +Enable or disable replication.
> +
> +Arguments:
> +
> +- "enable": Enable it or disable it.
> +- "primary": True for primary or false for secondary.
> +- "failover": Enable failover when stopping replication, but cannot be
> + specified if 'enable' is true (optional, default false).
> +
> +Example:
> +
> +-> { "execute": "xen-set-replication",
> + "arguments": {"enable": true, "primary": false} }
> +<- { "return": {} }
> +
> migrate
> -------
>
> diff --git a/migration/colo.c b/migration/colo.c
> index 93c85c5..6fc2ade 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -19,6 +19,8 @@
> #include "qemu/error-report.h"
> #include "qapi/error.h"
> #include "migration/failover.h"
> +#include "replication.h"
> +#include "qmp-commands.h"
>
> #define COLO_BUFFER_BASE_SIZE (4 * 1024 * 1024)
>
> @@ -104,6 +106,27 @@ void colo_do_failover(MigrationState *s)
> }
> }
>
> +void qmp_xen_set_replication(bool enable, bool primary,
> + bool has_failover, bool failover,
> + Error **errp)
> +{
> + ReplicationMode mode = primary ?
> + REPLICATION_MODE_PRIMARY :
> + REPLICATION_MODE_SECONDARY;
> +
> + if (has_failover && enable) {
> + error_setg(errp, "Parameter 'failover' is only for"
> + " stopping replication");
> + return;
> + }
> +
> + if (enable) {
> + replication_start_all(mode, errp);
> + } else {
> + replication_stop_all(failover, failover ? NULL : errp);
> + }
> +}
> +
> static void colo_send_message(QEMUFile *f, COLOMessage msg,
> Error **errp)
> {
> diff --git a/qapi-schema.json b/qapi-schema.json
> index f3e9bfc..78802f4 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -4676,6 +4676,25 @@
> { 'command': 'xen-load-devices-state', 'data': {'filename': 'str'} }
>
> ##
> +# @xen-set-replication
> +#
> +# Enable or disable replication.
> +#
> +# @enable: true to enable, false to disable.
> +#
> +# @primary: true for primary or false for secondary.
> +#
> +# @failover: #optional true to do failover, false to stop. but cannot be
> +# specified if 'enable' is true. default value is false.
> +#
> +# Returns: nothing.
> +#
> +# Since: 2.9
> +##
> +{ 'command': 'xen-set-replication',
> + 'data': { 'enable': 'bool', 'primary': 'bool', '*failover' : 'bool' } }
> +
> +##
> # @GICCapability:
> #
> # The struct describes capability for a specific GIC (Generic
> --
> 2.7.4
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH V5 2/2] Add a new qmp command to do checkpoint, query xen replication status
2016-12-27 9:38 ` [Qemu-devel] [PATCH V5 2/2] Add a new qmp command to do checkpoint, query xen replication status Zhang Chen
@ 2017-01-04 20:40 ` Eric Blake
2017-01-11 3:47 ` Zhang Chen
0 siblings, 1 reply; 6+ messages in thread
From: Eric Blake @ 2017-01-04 20:40 UTC (permalink / raw)
To: Zhang Chen, qemu devel, zhanghailiang
Cc: Jason Wang, Li Zhijian, eddie . dong, Bian Naimeng, Wen Congyang
[-- Attachment #1: Type: text/plain, Size: 4429 bytes --]
On 12/27/2016 03:38 AM, Zhang Chen wrote:
> We can call this qmp command to do checkpoint outside of qemu.
> Like Xen colo need this function.
That sentence is awkward; maybe:
Xen colo will need this function.
>
> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
> Signed-off-by: Wen Congyang <wencongyang@gmail.com>
> ---
> docs/qmp-commands.txt | 24 ++++++++++++++++++++++++
> migration/colo.c | 17 +++++++++++++++++
> qapi-schema.json | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 91 insertions(+)
>
> diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt
> index d182147..a146745 100644
> --- a/docs/qmp-commands.txt
> +++ b/docs/qmp-commands.txt
> @@ -450,6 +450,30 @@ Example:
> "arguments": {"enable": true, "primary": false} }
> <- { "return": {} }
>
> +query-xen-replication-status
> +----------------------------
> +
> +Query replication status when vm is running.
> +
> +Arguments: None.
> +
> +Example:
> +
> +-> { "execute": "query-xen-replication-status" }
> +<- { "return": { "status": "normal" } }
> +
> +xen-do-checkpoint
> +-----------------
> +
> +Xen use this command to notify replication to do checkpoint.
s/use/uses/
s/do/trigger a/
> +
> +Arguments: None.
> +
> +Example:
> +
> +-> { "execute": "xen-do-checkpoint" }
> +<- { "return": {} }
> +
> migrate
> -------
>
> diff --git a/migration/colo.c b/migration/colo.c
> index 6fc2ade..7fc9f8a 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -127,6 +127,23 @@ void qmp_xen_set_replication(bool enable, bool primary,
> }
> }
>
> +ReplicationErrorResult *qmp_query_xen_replication_status(Error **errp)
> +{
> + Error *err = NULL;
> + ReplicationErrorResult *result = g_new0(ReplicationErrorResult, 1);
> + replication_get_error_all(&err);
> + result->status = err ?
> + REPLICATION_ERROR_STATUS_ERROR :
> + REPLICATION_ERROR_STATUS_NORMAL;
> + error_free(err);
> + return result;
> +}
> +
> +void qmp_xen_do_checkpoint(Error **errp)
> +{
> + replication_do_checkpoint_all(errp);
> +}
> +
> static void colo_send_message(QEMUFile *f, COLOMessage msg,
> Error **errp)
> {
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 78802f4..6c162a5 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -4695,6 +4695,56 @@
> 'data': { 'enable': 'bool', 'primary': 'bool', '*failover' : 'bool' } }
>
> ##
> +# @ReplicationErrorStatus
> +#
> +# Describe the status of replication error.
> +#
> +# @error: Replication have a error.
s/have a/has an/
> +#
> +# @normal: Replication running normal.
s/running normal/is running normally/
> +#
> +# Since 2.9
> +##
> +{ 'enum': 'ReplicationErrorStatus',
> + 'data': [ 'error', 'normal' ] }
> +
> +##
> +# @ReplicationErrorResult
The name of this struct is misleading (but harmless, since struct names
are not part of the API). Better might be: ReplicationStatus
> +#
> +# The result format for 'xen-get-replication-error'.
Wrong name; you renamed the command 'query-xen-replication-status'.
> +#
> +# @status: enum of @ReplicationErrorStatus, which shows current
> +# replication error status
> +#
> +# Since 2.9
> +##
> +{ 'struct': 'ReplicationErrorResult',
> + 'data': { 'status': 'ReplicationErrorStatus'} }
> +
> +##
> +# @query-xen-replication-status
> +#
> +# Query replication error that occurs when the vm is running.
Since you might extend this in the future, I'd just leave it at:
Query replication status while the vm is running.
> +#
> +# Returns: A @ReplicationErrorResult objects showing the status.
> +#
> +# Since: 2.9
> +##
> +{ 'command': 'query-xen-replication-status',
> + 'returns': 'ReplicationErrorResult' }
Again, the struct name is misleading.
> +
> +##
> +# @xen-do-checkpoint
> +#
> +# Xen use this command to notify replication to do checkpoint.
s/use/uses/
> +#
> +# Returns: nothing.
> +#
> +# Since: 2.9
> +##
> +{ 'command': 'xen-do-checkpoint' }
> +
> +##
> # @GICCapability:
> #
> # The struct describes capability for a specific GIC (Generic
>
Getting closer!
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH V5 2/2] Add a new qmp command to do checkpoint, query xen replication status
2017-01-04 20:40 ` Eric Blake
@ 2017-01-11 3:47 ` Zhang Chen
0 siblings, 0 replies; 6+ messages in thread
From: Zhang Chen @ 2017-01-11 3:47 UTC (permalink / raw)
To: Eric Blake, qemu devel, zhanghailiang
Cc: Jason Wang, Li Zhijian, eddie . dong, Bian Naimeng, Wen Congyang
Hi~~ Eric:
I have send the V6 to fix the issues below, Have any comments?
Thanks
Zhang Chen
On 01/05/2017 04:40 AM, Eric Blake wrote:
> On 12/27/2016 03:38 AM, Zhang Chen wrote:
>> We can call this qmp command to do checkpoint outside of qemu.
>> Like Xen colo need this function.
> That sentence is awkward; maybe:
>
> Xen colo will need this function.
>
>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>> Signed-off-by: Wen Congyang <wencongyang@gmail.com>
>> ---
>> docs/qmp-commands.txt | 24 ++++++++++++++++++++++++
>> migration/colo.c | 17 +++++++++++++++++
>> qapi-schema.json | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 91 insertions(+)
>>
>> diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt
>> index d182147..a146745 100644
>> --- a/docs/qmp-commands.txt
>> +++ b/docs/qmp-commands.txt
>> @@ -450,6 +450,30 @@ Example:
>> "arguments": {"enable": true, "primary": false} }
>> <- { "return": {} }
>>
>> +query-xen-replication-status
>> +----------------------------
>> +
>> +Query replication status when vm is running.
>> +
>> +Arguments: None.
>> +
>> +Example:
>> +
>> +-> { "execute": "query-xen-replication-status" }
>> +<- { "return": { "status": "normal" } }
>> +
>> +xen-do-checkpoint
>> +-----------------
>> +
>> +Xen use this command to notify replication to do checkpoint.
> s/use/uses/
> s/do/trigger a/
>
>> +
>> +Arguments: None.
>> +
>> +Example:
>> +
>> +-> { "execute": "xen-do-checkpoint" }
>> +<- { "return": {} }
>> +
>> migrate
>> -------
>>
>> diff --git a/migration/colo.c b/migration/colo.c
>> index 6fc2ade..7fc9f8a 100644
>> --- a/migration/colo.c
>> +++ b/migration/colo.c
>> @@ -127,6 +127,23 @@ void qmp_xen_set_replication(bool enable, bool primary,
>> }
>> }
>>
>> +ReplicationErrorResult *qmp_query_xen_replication_status(Error **errp)
>> +{
>> + Error *err = NULL;
>> + ReplicationErrorResult *result = g_new0(ReplicationErrorResult, 1);
>> + replication_get_error_all(&err);
>> + result->status = err ?
>> + REPLICATION_ERROR_STATUS_ERROR :
>> + REPLICATION_ERROR_STATUS_NORMAL;
>> + error_free(err);
>> + return result;
>> +}
>> +
>> +void qmp_xen_do_checkpoint(Error **errp)
>> +{
>> + replication_do_checkpoint_all(errp);
>> +}
>> +
>> static void colo_send_message(QEMUFile *f, COLOMessage msg,
>> Error **errp)
>> {
>> diff --git a/qapi-schema.json b/qapi-schema.json
>> index 78802f4..6c162a5 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -4695,6 +4695,56 @@
>> 'data': { 'enable': 'bool', 'primary': 'bool', '*failover' : 'bool' } }
>>
>> ##
>> +# @ReplicationErrorStatus
>> +#
>> +# Describe the status of replication error.
>> +#
>> +# @error: Replication have a error.
> s/have a/has an/
>
>> +#
>> +# @normal: Replication running normal.
> s/running normal/is running normally/
>
>> +#
>> +# Since 2.9
>> +##
>> +{ 'enum': 'ReplicationErrorStatus',
>> + 'data': [ 'error', 'normal' ] }
>> +
>> +##
>> +# @ReplicationErrorResult
> The name of this struct is misleading (but harmless, since struct names
> are not part of the API). Better might be: ReplicationStatus
>
>> +#
>> +# The result format for 'xen-get-replication-error'.
> Wrong name; you renamed the command 'query-xen-replication-status'.
>
>> +#
>> +# @status: enum of @ReplicationErrorStatus, which shows current
>> +# replication error status
>> +#
>> +# Since 2.9
>> +##
>> +{ 'struct': 'ReplicationErrorResult',
>> + 'data': { 'status': 'ReplicationErrorStatus'} }
>> +
>> +##
>> +# @query-xen-replication-status
>> +#
>> +# Query replication error that occurs when the vm is running.
> Since you might extend this in the future, I'd just leave it at:
>
> Query replication status while the vm is running.
>
>> +#
>> +# Returns: A @ReplicationErrorResult objects showing the status.
>> +#
>> +# Since: 2.9
>> +##
>> +{ 'command': 'query-xen-replication-status',
>> + 'returns': 'ReplicationErrorResult' }
> Again, the struct name is misleading.
>
>> +
>> +##
>> +# @xen-do-checkpoint
>> +#
>> +# Xen use this command to notify replication to do checkpoint.
> s/use/uses/
>
>> +#
>> +# Returns: nothing.
>> +#
>> +# Since: 2.9
>> +##
>> +{ 'command': 'xen-do-checkpoint' }
>> +
>> +##
>> # @GICCapability:
>> #
>> # The struct describes capability for a specific GIC (Generic
>>
> Getting closer!
>
--
Thanks
Zhang Chen
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-11 3:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-27 9:38 [Qemu-devel] [PATCH V5 0/2] Add new qmp commands to suppurt Xen COLO Zhang Chen
2016-12-27 9:38 ` [Qemu-devel] [PATCH V5 1/2] Add a new qmp command to start/stop replication Zhang Chen
2017-01-04 0:42 ` Stefano Stabellini
2016-12-27 9:38 ` [Qemu-devel] [PATCH V5 2/2] Add a new qmp command to do checkpoint, query xen replication status Zhang Chen
2017-01-04 20:40 ` Eric Blake
2017-01-11 3:47 ` Zhang Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.