* [PATCH 1/5] drm/msm: Stop using drm_framebuffer_unregister_private
@ 2016-12-27 10:49 Daniel Vetter
2016-12-27 10:49 ` [PATCH 2/5] drm/cma-helper: " Daniel Vetter
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Daniel Vetter @ 2016-12-27 10:49 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
This is the deprecated function for when you embedded the framebuffer
somewhere else (which breaks refcounting). But msm is using
drm_framebuffer_remove and a free-standing fb, so this is rendundant.
Cc: Rob Clark <robdclark@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/msm/msm_fbdev.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index 5d68ab362d75..f8a587eac6b8 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b/drivers/gpu/drm/msm/msm_fbdev.c
@@ -174,10 +174,8 @@ static int msm_fbdev_create(struct drm_fb_helper *helper,
fail:
if (ret) {
- if (fb) {
- drm_framebuffer_unregister_private(fb);
+ if (fb)
drm_framebuffer_remove(fb);
- }
}
return ret;
@@ -247,7 +245,6 @@ void msm_fbdev_free(struct drm_device *dev)
/* this will free the backing object */
if (fbdev->fb) {
msm_gem_put_vaddr(fbdev->bo);
- drm_framebuffer_unregister_private(fbdev->fb);
drm_framebuffer_remove(fbdev->fb);
}
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/5] drm/cma-helper: Stop using drm_framebuffer_unregister_private
2016-12-27 10:49 [PATCH 1/5] drm/msm: Stop using drm_framebuffer_unregister_private Daniel Vetter
@ 2016-12-27 10:49 ` Daniel Vetter
2017-01-12 10:00 ` Laurent Pinchart
2016-12-27 10:49 ` [PATCH 3/5] drm/exynos: " Daniel Vetter
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Daniel Vetter @ 2016-12-27 10:49 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Laurent Pinchart, Daniel Vetter
This is the deprecated function for when you embedded the framebuffer
somewhere else (which breaks refcounting). But cma helpers are using
drm_framebuffer_remove and a free-standing fb, so this is rendundant.
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/drm_fb_cma_helper.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
index 591f30ebc42a..769a3b3236ee 100644
--- a/drivers/gpu/drm/drm_fb_cma_helper.c
+++ b/drivers/gpu/drm/drm_fb_cma_helper.c
@@ -485,8 +485,7 @@ int drm_fbdev_cma_create_with_funcs(struct drm_fb_helper *helper,
return 0;
err_cma_destroy:
- drm_framebuffer_unregister_private(&fbdev_cma->fb->fb);
- drm_fb_cma_destroy(&fbdev_cma->fb->fb);
+ drm_framebuffer_remove(&fbdev_cma->fb->fb);
err_fb_info_destroy:
drm_fb_helper_release_fbi(helper);
err_gem_free_object:
@@ -592,10 +591,8 @@ void drm_fbdev_cma_fini(struct drm_fbdev_cma *fbdev_cma)
drm_fbdev_cma_defio_fini(fbdev_cma->fb_helper.fbdev);
drm_fb_helper_release_fbi(&fbdev_cma->fb_helper);
- if (fbdev_cma->fb) {
- drm_framebuffer_unregister_private(&fbdev_cma->fb->fb);
- drm_fb_cma_destroy(&fbdev_cma->fb->fb);
- }
+ if (fbdev_cma->fb)
+ drm_framebuffer_remove(&fbdev_cma->fb->fb);
drm_fb_helper_fini(&fbdev_cma->fb_helper);
kfree(fbdev_cma);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/5] drm/exynos: Stop using drm_framebuffer_unregister_private
2016-12-27 10:49 [PATCH 1/5] drm/msm: Stop using drm_framebuffer_unregister_private Daniel Vetter
2016-12-27 10:49 ` [PATCH 2/5] drm/cma-helper: " Daniel Vetter
@ 2016-12-27 10:49 ` Daniel Vetter
2017-01-12 8:21 ` Inki Dae
2016-12-27 10:49 ` [PATCH 4/5] drm/omap: " Daniel Vetter
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Daniel Vetter @ 2016-12-27 10:49 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
This is the deprecated function for when you embedded the framebuffer
somewhere else (which breaks refcounting). But exynos is using
drm_framebuffer_remove and a free-standing fb, so this is rendundant.
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index d8808158d418..a7884bea42eb 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -270,10 +270,8 @@ static void exynos_drm_fbdev_destroy(struct drm_device *dev,
/* release drm framebuffer and real buffer */
if (fb_helper->fb && fb_helper->fb->funcs) {
fb = fb_helper->fb;
- if (fb) {
- drm_framebuffer_unregister_private(fb);
+ if (fb)
drm_framebuffer_remove(fb);
- }
}
drm_fb_helper_unregister_fbi(fb_helper);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/5] drm/omap: Stop using drm_framebuffer_unregister_private
2016-12-27 10:49 [PATCH 1/5] drm/msm: Stop using drm_framebuffer_unregister_private Daniel Vetter
2016-12-27 10:49 ` [PATCH 2/5] drm/cma-helper: " Daniel Vetter
2016-12-27 10:49 ` [PATCH 3/5] drm/exynos: " Daniel Vetter
@ 2016-12-27 10:49 ` Daniel Vetter
2017-01-12 9:56 ` Laurent Pinchart
2016-12-27 10:49 ` [PATCH 5/5] drm/tegra: " Daniel Vetter
2017-01-12 9:48 ` [PATCH 1/5] drm/msm: " Archit Taneja
4 siblings, 1 reply; 11+ messages in thread
From: Daniel Vetter @ 2016-12-27 10:49 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Tomi Valkeinen, Daniel Vetter
This is the deprecated function for when you embedded the framebuffer
somewhere else (which breaks refcounting). But omapdrm is using
drm_framebuffer_remove and a free-standing fb, so this is rendundant.
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/omapdrm/omap_fbdev.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
index aed99a0fc44b..2a839956dae6 100644
--- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
+++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
@@ -225,10 +225,8 @@ static int omap_fbdev_create(struct drm_fb_helper *helper,
drm_fb_helper_release_fbi(helper);
- if (fb) {
- drm_framebuffer_unregister_private(fb);
+ if (fb)
drm_framebuffer_remove(fb);
- }
}
return ret;
@@ -314,10 +312,8 @@ void omap_fbdev_free(struct drm_device *dev)
omap_gem_put_paddr(fbdev->bo);
/* this will free the backing object */
- if (fbdev->fb) {
- drm_framebuffer_unregister_private(fbdev->fb);
+ if (fbdev->fb)
drm_framebuffer_remove(fbdev->fb);
- }
kfree(fbdev);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 5/5] drm/tegra: Stop using drm_framebuffer_unregister_private
2016-12-27 10:49 [PATCH 1/5] drm/msm: Stop using drm_framebuffer_unregister_private Daniel Vetter
` (2 preceding siblings ...)
2016-12-27 10:49 ` [PATCH 4/5] drm/omap: " Daniel Vetter
@ 2016-12-27 10:49 ` Daniel Vetter
2017-01-12 10:15 ` Archit Taneja
2017-01-12 14:37 ` Thierry Reding
2017-01-12 9:48 ` [PATCH 1/5] drm/msm: " Archit Taneja
4 siblings, 2 replies; 11+ messages in thread
From: Daniel Vetter @ 2016-12-27 10:49 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
This is the deprecated function for when you embedded the framebuffer
somewhere else (which breaks refcounting). But tegra is using
drm_framebuffer_remove and a free-standing fb, so this is rendundant.
One caveat here is that the failur path in the init code still
manually cleaned up the fb. I presume that was an oversigth and
changed it over to drm_framebuffer_remove too.
Cc: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/tegra/fb.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index 8df7783cecc2..f896e2ff7d47 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm/tegra/fb.c
@@ -271,8 +271,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,
return 0;
destroy:
- drm_framebuffer_unregister_private(fb);
- tegra_fb_destroy(fb);
+ drm_framebuffer_remove(fb);
release:
drm_fb_helper_release_fbi(helper);
return err;
@@ -342,10 +341,8 @@ static void tegra_fbdev_exit(struct tegra_fbdev *fbdev)
drm_fb_helper_unregister_fbi(&fbdev->base);
drm_fb_helper_release_fbi(&fbdev->base);
- if (fbdev->fb) {
- drm_framebuffer_unregister_private(&fbdev->fb->base);
+ if (fbdev->fb)
drm_framebuffer_remove(&fbdev->fb->base);
- }
drm_fb_helper_fini(&fbdev->base);
tegra_fbdev_free(fbdev);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 3/5] drm/exynos: Stop using drm_framebuffer_unregister_private
2016-12-27 10:49 ` [PATCH 3/5] drm/exynos: " Daniel Vetter
@ 2017-01-12 8:21 ` Inki Dae
0 siblings, 0 replies; 11+ messages in thread
From: Inki Dae @ 2017-01-12 8:21 UTC (permalink / raw)
To: Daniel Vetter, DRI Development; +Cc: Daniel Vetter
Applied.
Thanks.
2016년 12월 27일 19:49에 Daniel Vetter 이(가) 쓴 글:
> This is the deprecated function for when you embedded the framebuffer
> somewhere else (which breaks refcounting). But exynos is using
> drm_framebuffer_remove and a free-standing fb, so this is rendundant.
>
> Cc: Inki Dae <inki.dae@samsung.com>
> Cc: Joonyoung Shim <jy0922.shim@samsung.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> index d8808158d418..a7884bea42eb 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> @@ -270,10 +270,8 @@ static void exynos_drm_fbdev_destroy(struct drm_device *dev,
> /* release drm framebuffer and real buffer */
> if (fb_helper->fb && fb_helper->fb->funcs) {
> fb = fb_helper->fb;
> - if (fb) {
> - drm_framebuffer_unregister_private(fb);
> + if (fb)
> drm_framebuffer_remove(fb);
> - }
> }
>
> drm_fb_helper_unregister_fbi(fb_helper);
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/5] drm/msm: Stop using drm_framebuffer_unregister_private
2016-12-27 10:49 [PATCH 1/5] drm/msm: Stop using drm_framebuffer_unregister_private Daniel Vetter
` (3 preceding siblings ...)
2016-12-27 10:49 ` [PATCH 5/5] drm/tegra: " Daniel Vetter
@ 2017-01-12 9:48 ` Archit Taneja
4 siblings, 0 replies; 11+ messages in thread
From: Archit Taneja @ 2017-01-12 9:48 UTC (permalink / raw)
To: Daniel Vetter, DRI Development; +Cc: Daniel Vetter
On 12/27/2016 04:19 PM, Daniel Vetter wrote:
> This is the deprecated function for when you embedded the framebuffer
> somewhere else (which breaks refcounting). But msm is using
> drm_framebuffer_remove and a free-standing fb, so this is rendundant.
>
> Cc: Rob Clark <robdclark@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Archit Taneja <architt@codeaurora.org>
> ---
> drivers/gpu/drm/msm/msm_fbdev.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
> index 5d68ab362d75..f8a587eac6b8 100644
> --- a/drivers/gpu/drm/msm/msm_fbdev.c
> +++ b/drivers/gpu/drm/msm/msm_fbdev.c
> @@ -174,10 +174,8 @@ static int msm_fbdev_create(struct drm_fb_helper *helper,
> fail:
>
> if (ret) {
> - if (fb) {
> - drm_framebuffer_unregister_private(fb);
> + if (fb)
> drm_framebuffer_remove(fb);
> - }
> }
>
> return ret;
> @@ -247,7 +245,6 @@ void msm_fbdev_free(struct drm_device *dev)
> /* this will free the backing object */
> if (fbdev->fb) {
> msm_gem_put_vaddr(fbdev->bo);
> - drm_framebuffer_unregister_private(fbdev->fb);
> drm_framebuffer_remove(fbdev->fb);
> }
>
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/5] drm/omap: Stop using drm_framebuffer_unregister_private
2016-12-27 10:49 ` [PATCH 4/5] drm/omap: " Daniel Vetter
@ 2017-01-12 9:56 ` Laurent Pinchart
0 siblings, 0 replies; 11+ messages in thread
From: Laurent Pinchart @ 2017-01-12 9:56 UTC (permalink / raw)
To: dri-devel; +Cc: Daniel Vetter, Tomi Valkeinen, Daniel Vetter
Hi Daniel,
Thank you for the patch.
On Tuesday 27 Dec 2016 11:49:24 Daniel Vetter wrote:
> This is the deprecated function for when you embedded the framebuffer
> somewhere else (which breaks refcounting). But omapdrm is using
> drm_framebuffer_remove and a free-standing fb, so this is rendundant.
>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/omapdrm/omap_fbdev.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> b/drivers/gpu/drm/omapdrm/omap_fbdev.c index aed99a0fc44b..2a839956dae6
> 100644
> --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> @@ -225,10 +225,8 @@ static int omap_fbdev_create(struct drm_fb_helper
> *helper,
>
> drm_fb_helper_release_fbi(helper);
>
> - if (fb) {
> - drm_framebuffer_unregister_private(fb);
> + if (fb)
> drm_framebuffer_remove(fb);
> - }
> }
>
> return ret;
> @@ -314,10 +312,8 @@ void omap_fbdev_free(struct drm_device *dev)
> omap_gem_put_paddr(fbdev->bo);
>
> /* this will free the backing object */
> - if (fbdev->fb) {
> - drm_framebuffer_unregister_private(fbdev->fb);
> + if (fbdev->fb)
> drm_framebuffer_remove(fbdev->fb);
> - }
>
> kfree(fbdev);
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/5] drm/cma-helper: Stop using drm_framebuffer_unregister_private
2016-12-27 10:49 ` [PATCH 2/5] drm/cma-helper: " Daniel Vetter
@ 2017-01-12 10:00 ` Laurent Pinchart
0 siblings, 0 replies; 11+ messages in thread
From: Laurent Pinchart @ 2017-01-12 10:00 UTC (permalink / raw)
To: dri-devel; +Cc: Daniel Vetter, Daniel Vetter
Hi Daniel,
Thank you for the patch.
On Tuesday 27 Dec 2016 11:49:22 Daniel Vetter wrote:
> This is the deprecated function for when you embedded the framebuffer
> somewhere else (which breaks refcounting). But cma helpers are using
> drm_framebuffer_remove and a free-standing fb, so this is rendundant.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c
> b/drivers/gpu/drm/drm_fb_cma_helper.c index 591f30ebc42a..769a3b3236ee
> 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -485,8 +485,7 @@ int drm_fbdev_cma_create_with_funcs(struct drm_fb_helper
> *helper, return 0;
>
> err_cma_destroy:
> - drm_framebuffer_unregister_private(&fbdev_cma->fb->fb);
> - drm_fb_cma_destroy(&fbdev_cma->fb->fb);
> + drm_framebuffer_remove(&fbdev_cma->fb->fb);
> err_fb_info_destroy:
> drm_fb_helper_release_fbi(helper);
> err_gem_free_object:
> @@ -592,10 +591,8 @@ void drm_fbdev_cma_fini(struct drm_fbdev_cma
> *fbdev_cma) drm_fbdev_cma_defio_fini(fbdev_cma->fb_helper.fbdev);
> drm_fb_helper_release_fbi(&fbdev_cma->fb_helper);
>
> - if (fbdev_cma->fb) {
> - drm_framebuffer_unregister_private(&fbdev_cma->fb->fb);
> - drm_fb_cma_destroy(&fbdev_cma->fb->fb);
> - }
> + if (fbdev_cma->fb)
> + drm_framebuffer_remove(&fbdev_cma->fb->fb);
>
> drm_fb_helper_fini(&fbdev_cma->fb_helper);
> kfree(fbdev_cma);
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 5/5] drm/tegra: Stop using drm_framebuffer_unregister_private
2016-12-27 10:49 ` [PATCH 5/5] drm/tegra: " Daniel Vetter
@ 2017-01-12 10:15 ` Archit Taneja
2017-01-12 14:37 ` Thierry Reding
1 sibling, 0 replies; 11+ messages in thread
From: Archit Taneja @ 2017-01-12 10:15 UTC (permalink / raw)
To: Daniel Vetter, DRI Development; +Cc: Daniel Vetter
On 12/27/2016 04:19 PM, Daniel Vetter wrote:
> This is the deprecated function for when you embedded the framebuffer
> somewhere else (which breaks refcounting). But tegra is using
> drm_framebuffer_remove and a free-standing fb, so this is rendundant.
s/rendundant/redundant
>
> One caveat here is that the failur path in the init code still
s/failur/failure
> manually cleaned up the fb. I presume that was an oversigth and
s/oversigth/oversight
> changed it over to drm_framebuffer_remove too.
Reviewed-by: Archit Taneja <architt@codeaurora.org>
>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/tegra/fb.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
> index 8df7783cecc2..f896e2ff7d47 100644
> --- a/drivers/gpu/drm/tegra/fb.c
> +++ b/drivers/gpu/drm/tegra/fb.c
> @@ -271,8 +271,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,
> return 0;
>
> destroy:
> - drm_framebuffer_unregister_private(fb);
> - tegra_fb_destroy(fb);
> + drm_framebuffer_remove(fb);
> release:
> drm_fb_helper_release_fbi(helper);
> return err;
> @@ -342,10 +341,8 @@ static void tegra_fbdev_exit(struct tegra_fbdev *fbdev)
> drm_fb_helper_unregister_fbi(&fbdev->base);
> drm_fb_helper_release_fbi(&fbdev->base);
>
> - if (fbdev->fb) {
> - drm_framebuffer_unregister_private(&fbdev->fb->base);
> + if (fbdev->fb)
> drm_framebuffer_remove(&fbdev->fb->base);
> - }
>
> drm_fb_helper_fini(&fbdev->base);
> tegra_fbdev_free(fbdev);
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 5/5] drm/tegra: Stop using drm_framebuffer_unregister_private
2016-12-27 10:49 ` [PATCH 5/5] drm/tegra: " Daniel Vetter
2017-01-12 10:15 ` Archit Taneja
@ 2017-01-12 14:37 ` Thierry Reding
1 sibling, 0 replies; 11+ messages in thread
From: Thierry Reding @ 2017-01-12 14:37 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, DRI Development
[-- Attachment #1.1: Type: text/plain, Size: 903 bytes --]
On Tue, Dec 27, 2016 at 11:49:25AM +0100, Daniel Vetter wrote:
> This is the deprecated function for when you embedded the framebuffer
> somewhere else (which breaks refcounting). But tegra is using
> drm_framebuffer_remove and a free-standing fb, so this is rendundant.
Nit: "Tegra", "redundant", "FB"?
>
> One caveat here is that the failur path in the init code still
"failure"
> manually cleaned up the fb. I presume that was an oversigth and
"oversight"
> changed it over to drm_framebuffer_remove too.
>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/tegra/fb.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Yes, drm_framebuffer_remove() ends up calling tegra_fb_destroy(), which
is really what we need here, so:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-01-12 14:37 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-27 10:49 [PATCH 1/5] drm/msm: Stop using drm_framebuffer_unregister_private Daniel Vetter
2016-12-27 10:49 ` [PATCH 2/5] drm/cma-helper: " Daniel Vetter
2017-01-12 10:00 ` Laurent Pinchart
2016-12-27 10:49 ` [PATCH 3/5] drm/exynos: " Daniel Vetter
2017-01-12 8:21 ` Inki Dae
2016-12-27 10:49 ` [PATCH 4/5] drm/omap: " Daniel Vetter
2017-01-12 9:56 ` Laurent Pinchart
2016-12-27 10:49 ` [PATCH 5/5] drm/tegra: " Daniel Vetter
2017-01-12 10:15 ` Archit Taneja
2017-01-12 14:37 ` Thierry Reding
2017-01-12 9:48 ` [PATCH 1/5] drm/msm: " Archit Taneja
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.