[PATCH] drm/amd/amdgpu: fix performance drop

[PATCH] drm/amd/amdgpu: fix performance drop

[Roger.He]

From: "Hongbo.He" <Hongbo.He@amd.com>

rollback to ttm default callback since OCL perf benchmark huge performance drop

Change-Id: If4cfc5a52872a7e00a7cbcad6efa46c57ee533de
Signed-off-by: Roger.He <Hongbo.He@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 0f3c358..8b973be 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -1137,9 +1137,8 @@ static struct ttm_bo_driver amdgpu_bo_driver = {
 	.fault_reserve_notify = &amdgpu_bo_fault_reserve_notify,
 	.io_mem_reserve = &amdgpu_ttm_io_mem_reserve,
 	.io_mem_free = &amdgpu_ttm_io_mem_free,
-	.lru_removal = &amdgpu_ttm_lru_removal,
-	.lru_tail = &amdgpu_ttm_lru_tail,
-	.swap_lru_tail = &amdgpu_ttm_swap_lru_tail,
+	.lru_tail = &ttm_bo_default_lru_tail,
+	.swap_lru_tail = &ttm_bo_default_swap_lru_tail,
 };
 
 int amdgpu_ttm_init(struct amdgpu_device *adev)
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/amdgpu: fix performance drop

[Christian König]

Am 28.12.2016 um 04:17 schrieb Roger.He:
> From: "Hongbo.He" <Hongbo.He@amd.com>
>
> rollback to ttm default callback since OCL perf benchmark huge performance drop
>
> Change-Id: If4cfc5a52872a7e00a7cbcad6efa46c57ee533de
> Signed-off-by: Roger.He <Hongbo.He@amd.com>

NAK, as I wrote internally as well we need this for further KFD features.

Additional to that this patch would leave unused code in the kernel driver.

I will work on properly fixing this.

Regards,
Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index 0f3c358..8b973be 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -1137,9 +1137,8 @@ static struct ttm_bo_driver amdgpu_bo_driver = {
>   	.fault_reserve_notify = &amdgpu_bo_fault_reserve_notify,
>   	.io_mem_reserve = &amdgpu_ttm_io_mem_reserve,
>   	.io_mem_free = &amdgpu_ttm_io_mem_free,
> -	.lru_removal = &amdgpu_ttm_lru_removal,
> -	.lru_tail = &amdgpu_ttm_lru_tail,
> -	.swap_lru_tail = &amdgpu_ttm_swap_lru_tail,
> +	.lru_tail = &ttm_bo_default_lru_tail,
> +	.swap_lru_tail = &ttm_bo_default_swap_lru_tail,
>   };
>   
>   int amdgpu_ttm_init(struct amdgpu_device *adev)


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx