* [PATCH] nvme-rdma: fix nvme_rdma_queue_is_ready
@ 2017-01-04 5:25 Christoph Hellwig
2017-01-04 8:54 ` Max Gurtovoy
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2017-01-04 5:25 UTC (permalink / raw)
Now that we don't abuse the cmd field in struct request for nvme command
passthrough this function needs to be converted to the proper accessor
as well.
Fixes: d49187e97e ("nvme: introduce struct nvme_request")
Signed-off-by: Christoph Hellwig <hch at lst.de>
---
drivers/nvme/host/rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index f587af3..34e5648 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1422,7 +1422,7 @@ static inline bool nvme_rdma_queue_is_ready(struct nvme_rdma_queue *queue,
struct request *rq)
{
if (unlikely(!test_bit(NVME_RDMA_Q_LIVE, &queue->flags))) {
- struct nvme_command *cmd = (struct nvme_command *)rq->cmd;
+ struct nvme_command *cmd = nvme_req(rq)->cmd;
if (rq->cmd_type != REQ_TYPE_DRV_PRIV ||
cmd->common.opcode != nvme_fabrics_command ||
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] nvme-rdma: fix nvme_rdma_queue_is_ready
2017-01-04 5:25 [PATCH] nvme-rdma: fix nvme_rdma_queue_is_ready Christoph Hellwig
@ 2017-01-04 8:54 ` Max Gurtovoy
0 siblings, 0 replies; 2+ messages in thread
From: Max Gurtovoy @ 2017-01-04 8:54 UTC (permalink / raw)
On 1/4/2017 7:25 AM, Christoph Hellwig wrote:
> Now that we don't abuse the cmd field in struct request for nvme command
> passthrough this function needs to be converted to the proper accessor
> as well.
>
> Fixes: d49187e97e ("nvme: introduce struct nvme_request")
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> ---
> drivers/nvme/host/rdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index f587af3..34e5648 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -1422,7 +1422,7 @@ static inline bool nvme_rdma_queue_is_ready(struct nvme_rdma_queue *queue,
> struct request *rq)
> {
> if (unlikely(!test_bit(NVME_RDMA_Q_LIVE, &queue->flags))) {
> - struct nvme_command *cmd = (struct nvme_command *)rq->cmd;
> + struct nvme_command *cmd = nvme_req(rq)->cmd;
>
> if (rq->cmd_type != REQ_TYPE_DRV_PRIV ||
> cmd->common.opcode != nvme_fabrics_command ||
>
Looks good,
Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-04 8:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-04 5:25 [PATCH] nvme-rdma: fix nvme_rdma_queue_is_ready Christoph Hellwig
2017-01-04 8:54 ` Max Gurtovoy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.