[meta-oe][PATCH v3] devtools: Add recipe for Chromium Embedded Controller utilities

[meta-oe][PATCH v3] devtools: Add recipe for Chromium Embedded Controller utilities

[Moritz Fischer]

Add a recipe to build 'ectool' a utility to interact with the embedded
controller on Google's chromebooks (and other platforms using it).

Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
---
Changes from v1:

- Replaced DESCRIPTION with SUMMARY (Martin)
- Use EXTRA_OEMAKE (Martin)
- Removed FILESEXTRAPATHS (Martin)
- Changed PV (Martin / Khem)
- Removed FILES_PN (Khem)

Changes from v2:

- Changed PV (Martin)

---
 .../chromium-utils/chromium-utils.bb               | 24 ++++++++++++++++++++
 .../files/0001-build-Add-HOST_LDFLAGS.patch        | 26 ++++++++++++++++++++++
 2 files changed, 50 insertions(+)
 create mode 100644 meta/recipes-devtools/chromium-utils/chromium-utils.bb
 create mode 100644 meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch

diff --git a/meta/recipes-devtools/chromium-utils/chromium-utils.bb b/meta/recipes-devtools/chromium-utils/chromium-utils.bb
new file mode 100644
index 0000000..f2216fe
--- /dev/null
+++ b/meta/recipes-devtools/chromium-utils/chromium-utils.bb
@@ -0,0 +1,24 @@
+SUMMARY = "Chromium EC utilities"
+DEPENDS = "libftdi"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=562c740877935f40b262db8af30bca36"
+
+SRCREV = "b19bb1f22a3fd0102030485d324c0321a18827e8"
+SRC_URI = "git://chromium.googlesource.com/chromiumos/platform/ec;protocol=https \
+           file://0001-build-Add-HOST_LDFLAGS.patch \
+          "
+
+PV = "1.1.9999+gitr${SRCPV}"
+
+S = "${WORKDIR}/git"
+
+EXTRA_OEMAKE = "'HOSTCC=${CC}' 'HOSTCFLAGS=${CFLAGS}' 'HOST_LDFLAGS=${LDFLAGS}'"
+
+do_compile() {
+    oe_runmake utils
+}
+
+do_install() {
+    install -m 0755 -d ${D}${bindir}
+    install -m 0755 ${S}/build/bds/util/ectool ${D}${bindir}/ectool
+}
diff --git a/meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch b/meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch
new file mode 100644
index 0000000..46e8cad
--- /dev/null
+++ b/meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch
@@ -0,0 +1,26 @@
+From 56ffeeffea735a6a8f69fc111278ebabe3c7e2d8 Mon Sep 17 00:00:00 2001
+From: Moritz Fischer <moritz.fischer@ettus.com>
+Date: Tue, 27 Dec 2016 22:24:07 -0800
+Subject: [PATCH] build Add HOST_LDFLAGS
+
+Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
+---
+ Makefile.rules | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile.rules b/Makefile.rules
+index 404454d..0057ba9 100644
+--- a/Makefile.rules
++++ b/Makefile.rules
+@@ -60,7 +60,7 @@ cmd_c_to_build = $(BUILDCC) $(BUILD_CFLAGS) \
+ 	         $(sort $(foreach c,$($(*F)-objs),util/$(c:%.o=%.c)) $*.c) \
+ 	         $(BUILD_LDFLAGS) \
+ 	         -MMD -MF $@.d -o $@
+-cmd_c_to_host = $(HOSTCC) $(HOST_CFLAGS) -MMD -MF $@.d  -o $@ \
++cmd_c_to_host = $(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS) -MMD -MF $@.d  -o $@ \
+ 	         $(sort $(foreach c,$($(*F)-objs),util/$(c:%.o=%.c)) $*.c)
+ cmd_cxx_to_host = $(HOSTCXX) -std=c++0x $(COMMON_WARN) $(HOST_CXXFLAGS)\
+ 	-I ./$($(notdir $@)_ROOT) -o $@ $(filter %.cc,$^) $($(notdir $@)_LIBS)
+-- 
+2.4.11
+
-- 
2.7.4

Re: [meta-oe][PATCH v3] devtools: Add recipe for Chromium Embedded Controller utilities

[Leonardo Sandoval]

> +}
> diff --git a/meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch b/meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch
> new file mode 100644
> index 0000000..46e8cad
> --- /dev/null
> +++ b/meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch
> @@ -0,0 +1,26 @@
> +From 56ffeeffea735a6a8f69fc111278ebabe3c7e2d8 Mon Sep 17 00:00:00 2001
> +From: Moritz Fischer <moritz.fischer@ettus.com>
> +Date: Tue, 27 Dec 2016 22:24:07 -0800
> +Subject: [PATCH] build Add HOST_LDFLAGS
> +

what is the Upstream Status of this patch? At least for oe-core, you 
need to provide it. More info at 
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines



> +Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> +---
> + Makefile.rules | 2 +-
>

Re: [meta-oe][PATCH v3] devtools: Add recipe for Chromium Embedded Controller utilities

[Moritz Fischer]

Leonardo,

On Wed, Jan 4, 2017 at 10:36 AM, Leonardo Sandoval
<leonardo.sandoval.gonzalez@linux.intel.com> wrote:
>
>> +}
>> diff --git
>> a/meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch
>> b/meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch
>> new file mode 100644
>> index 0000000..46e8cad
>> --- /dev/null
>> +++
>> b/meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch
>> @@ -0,0 +1,26 @@
>> +From 56ffeeffea735a6a8f69fc111278ebabe3c7e2d8 Mon Sep 17 00:00:00 2001
>> +From: Moritz Fischer <moritz.fischer@ettus.com>
>> +Date: Tue, 27 Dec 2016 22:24:07 -0800
>> +Subject: [PATCH] build Add HOST_LDFLAGS
>> +
>
>
> what is the Upstream Status of this patch? At least for oe-core, you need to
> provide it. More info at
> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Good catch, thanks. I submitted it upstream. I'll just wait for that
to resubmit my v4 here, maybe by then I don't need the patch anymore
then.

Moritz

Re: [meta-oe][PATCH v3] devtools: Add recipe for Chromium Embedded Controller utilities

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

On 4 January 2017 at 20:25, Moritz Fischer <moritz.fischer@ettus.com> wrote:

> Good catch, thanks. I submitted it upstream. I'll just wait for that
> to resubmit my v4 here, maybe by then I don't need the patch anymore
> then.
>

Is there a good rationale to put this in oe-core, instead of a BSP layer or
meta-oe?  How widespread are boards that use this tool?

Ross

[-- Attachment #2: Type: text/html, Size: 791 bytes --]

Re: [meta-oe][PATCH v3] devtools: Add recipe for Chromium Embedded Controller utilities

[Khem Raj]

On Wed, Jan 4, 2017 at 12:39 PM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 4 January 2017 at 20:25, Moritz Fischer <moritz.fischer@ettus.com> wrote:
>>
>> Good catch, thanks. I submitted it upstream. I'll just wait for that
>> to resubmit my v4 here, maybe by then I don't need the patch anymore
>> then.
>
>
> Is there a good rationale to put this in oe-core, instead of a BSP layer or
> meta-oe?  How widespread are boards that use this tool?

it should be in meta-oe imo

>
> Ross
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>