All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "watchdog: mei_wdt: request stop on reboot to prevent false positive event" has been added to the 4.9-stable tree
@ 2017-01-04 14:00 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-01-04 14:00 UTC (permalink / raw)
  To: alexander.usyskin, gregkh, linux, tomas.winkler; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    watchdog: mei_wdt: request stop on reboot to prevent false positive event

to the 4.9-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     watchdog-mei_wdt-request-stop-on-reboot-to-prevent-false-positive-event.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 9eff1140a82db8c5520f76e51c21827b4af670b3 Mon Sep 17 00:00:00 2001
From: Alexander Usyskin <alexander.usyskin@intel.com>
Date: Tue, 8 Nov 2016 17:55:52 +0200
Subject: watchdog: mei_wdt: request stop on reboot to prevent false positive event

From: Alexander Usyskin <alexander.usyskin@intel.com>

commit 9eff1140a82db8c5520f76e51c21827b4af670b3 upstream.

Systemd on reboot enables shutdown watchdog that leaves the watchdog
device open to ensure that even if power down process get stuck the
platform reboots nonetheless.
The iamt_wdt is an alarm-only watchdog and can't reboot system, but the
FW will generate an alarm event reboot was completed in time, as the
watchdog is not automatically disabled during power cycle.
So we should request stop watchdog on reboot to eliminate wrong alarm
from the FW.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/watchdog/mei_wdt.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/watchdog/mei_wdt.c
+++ b/drivers/watchdog/mei_wdt.c
@@ -389,6 +389,8 @@ static int mei_wdt_register(struct mei_w
 	wdt->wdd.max_timeout = MEI_WDT_MAX_TIMEOUT;
 
 	watchdog_set_drvdata(&wdt->wdd, wdt);
+	watchdog_stop_on_reboot(&wdt->wdd);
+
 	ret = watchdog_register_device(&wdt->wdd);
 	if (ret) {
 		dev_err(dev, "unable to register watchdog device = %d.\n", ret);


Patches currently in stable-queue which might be from alexander.usyskin@intel.com are

queue-4.9/watchdog-mei_wdt-request-stop-on-reboot-to-prevent-false-positive-event.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-01-04 14:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-04 14:00 Patch "watchdog: mei_wdt: request stop on reboot to prevent false positive event" has been added to the 4.9-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.