From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> To: <linux-kernel@vger.kernel.org>, <iommu@lists.linux-foundation.org> Cc: <joro@8bytes.org>, <bp@alien8.de>, <peterz@infradead.org>, <mingo@redhat.com>, Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> Subject: [PATCH v7 4/7] perf/amd/iommu: Declare pr_fmt and remove unnecessary pr_debug Date: Mon, 9 Jan 2017 21:33:44 -0600 [thread overview] Message-ID: <1484019227-11473-5-git-send-email-Suravee.Suthikulpanit@amd.com> (raw) In-Reply-To: <1484019227-11473-1-git-send-email-Suravee.Suthikulpanit@amd.com> This patch declare pr_fmt for perf/amd_iommu and remove unnecessary pr_debug. Cc: Peter Zijlstra <peterz@infradead.org> Cc: Borislav Petkov <bp@alien8.de> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> --- arch/x86/events/amd/iommu.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c index 9744dc8..9bff41d 100644 --- a/arch/x86/events/amd/iommu.c +++ b/arch/x86/events/amd/iommu.c @@ -11,6 +11,8 @@ * published by the Free Software Foundation. */ +#define pr_fmt(fmt) "perf/amd_iommu: " fmt + #include <linux/perf_event.h> #include <linux/init.h> #include <linux/cpumask.h> @@ -288,7 +290,6 @@ static void perf_iommu_start(struct perf_event *event, int flags) u64 val; struct hw_perf_event *hwc = &event->hw; - pr_debug("perf: amd_iommu:perf_iommu_start\n"); if (WARN_ON_ONCE(!(hwc->state & PERF_HES_STOPPED))) return; @@ -312,7 +313,6 @@ static void perf_iommu_read(struct perf_event *event) u64 cnt, prev; s64 delta; struct hw_perf_event *hwc = &event->hw; - pr_debug("perf: amd_iommu:perf_iommu_read\n"); if (amd_iommu_pc_get_counter(0, _GET_BANK(event), _GET_CNTR(event), &cnt)) return; @@ -339,8 +339,6 @@ static void perf_iommu_stop(struct perf_event *event, int flags) struct hw_perf_event *hwc = &event->hw; u64 config; - pr_debug("perf: amd_iommu:perf_iommu_stop\n"); - if (hwc->state & PERF_HES_UPTODATE) return; @@ -362,7 +360,6 @@ static int perf_iommu_add(struct perf_event *event, int flags) struct perf_amd_iommu *perf_iommu = container_of(event->pmu, struct perf_amd_iommu, pmu); - pr_debug("perf: amd_iommu:perf_iommu_add\n"); event->hw.state = PERF_HES_UPTODATE | PERF_HES_STOPPED; /* request an iommu bank/counter */ @@ -383,7 +380,6 @@ static void perf_iommu_del(struct perf_event *event, int flags) struct perf_amd_iommu *perf_iommu = container_of(event->pmu, struct perf_amd_iommu, pmu); - pr_debug("perf: amd_iommu:perf_iommu_del\n"); perf_iommu_stop(event, PERF_EF_UPDATE); /* clear the assigned iommu bank/counter */ @@ -443,7 +439,7 @@ static __init int _init_perf_amd_iommu( /* Init events attributes */ if (_init_events_attrs(perf_iommu) != 0) - pr_err("perf: amd_iommu: Only support raw events.\n"); + pr_err("Only support raw events.\n"); perf_iommu->max_banks = amd_iommu_pc_get_max_banks(0); perf_iommu->max_counters = amd_iommu_pc_get_max_counters(0); @@ -456,7 +452,7 @@ static __init int _init_perf_amd_iommu( ret = perf_pmu_register(&perf_iommu->pmu, name, -1); if (ret) { - pr_err("perf: amd_iommu: Failed to initialized.\n"); + pr_err("Error initializing AMD IOMMU perf counters.\n"); amd_iommu_pc_exit(); } else { pr_info("perf: amd_iommu: Detected. (%d banks, %d counters/bank)\n", -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Suravee Suthikulpanit <Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org> To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Cc: peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org Subject: [PATCH v7 4/7] perf/amd/iommu: Declare pr_fmt and remove unnecessary pr_debug Date: Mon, 9 Jan 2017 21:33:44 -0600 [thread overview] Message-ID: <1484019227-11473-5-git-send-email-Suravee.Suthikulpanit@amd.com> (raw) In-Reply-To: <1484019227-11473-1-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org> This patch declare pr_fmt for perf/amd_iommu and remove unnecessary pr_debug. Cc: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> Cc: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org> --- arch/x86/events/amd/iommu.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c index 9744dc8..9bff41d 100644 --- a/arch/x86/events/amd/iommu.c +++ b/arch/x86/events/amd/iommu.c @@ -11,6 +11,8 @@ * published by the Free Software Foundation. */ +#define pr_fmt(fmt) "perf/amd_iommu: " fmt + #include <linux/perf_event.h> #include <linux/init.h> #include <linux/cpumask.h> @@ -288,7 +290,6 @@ static void perf_iommu_start(struct perf_event *event, int flags) u64 val; struct hw_perf_event *hwc = &event->hw; - pr_debug("perf: amd_iommu:perf_iommu_start\n"); if (WARN_ON_ONCE(!(hwc->state & PERF_HES_STOPPED))) return; @@ -312,7 +313,6 @@ static void perf_iommu_read(struct perf_event *event) u64 cnt, prev; s64 delta; struct hw_perf_event *hwc = &event->hw; - pr_debug("perf: amd_iommu:perf_iommu_read\n"); if (amd_iommu_pc_get_counter(0, _GET_BANK(event), _GET_CNTR(event), &cnt)) return; @@ -339,8 +339,6 @@ static void perf_iommu_stop(struct perf_event *event, int flags) struct hw_perf_event *hwc = &event->hw; u64 config; - pr_debug("perf: amd_iommu:perf_iommu_stop\n"); - if (hwc->state & PERF_HES_UPTODATE) return; @@ -362,7 +360,6 @@ static int perf_iommu_add(struct perf_event *event, int flags) struct perf_amd_iommu *perf_iommu = container_of(event->pmu, struct perf_amd_iommu, pmu); - pr_debug("perf: amd_iommu:perf_iommu_add\n"); event->hw.state = PERF_HES_UPTODATE | PERF_HES_STOPPED; /* request an iommu bank/counter */ @@ -383,7 +380,6 @@ static void perf_iommu_del(struct perf_event *event, int flags) struct perf_amd_iommu *perf_iommu = container_of(event->pmu, struct perf_amd_iommu, pmu); - pr_debug("perf: amd_iommu:perf_iommu_del\n"); perf_iommu_stop(event, PERF_EF_UPDATE); /* clear the assigned iommu bank/counter */ @@ -443,7 +439,7 @@ static __init int _init_perf_amd_iommu( /* Init events attributes */ if (_init_events_attrs(perf_iommu) != 0) - pr_err("perf: amd_iommu: Only support raw events.\n"); + pr_err("Only support raw events.\n"); perf_iommu->max_banks = amd_iommu_pc_get_max_banks(0); perf_iommu->max_counters = amd_iommu_pc_get_max_counters(0); @@ -456,7 +452,7 @@ static __init int _init_perf_amd_iommu( ret = perf_pmu_register(&perf_iommu->pmu, name, -1); if (ret) { - pr_err("perf: amd_iommu: Failed to initialized.\n"); + pr_err("Error initializing AMD IOMMU perf counters.\n"); amd_iommu_pc_exit(); } else { pr_info("perf: amd_iommu: Detected. (%d banks, %d counters/bank)\n", -- 1.8.3.1
next prev parent reply other threads:[~2017-01-10 3:35 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-10 3:33 [PATCH v7 0/7] perf/amd/iommu: Enable multi-IOMMU support Suravee Suthikulpanit 2017-01-10 3:33 ` Suravee Suthikulpanit 2017-01-10 3:33 ` [PATCH v7 1/7] perf/amd/iommu: Misc fix up perf_iommu_read Suravee Suthikulpanit 2017-01-10 3:33 ` Suravee Suthikulpanit 2017-01-11 10:32 ` Borislav Petkov 2017-01-11 10:32 ` Borislav Petkov 2017-01-11 11:57 ` Peter Zijlstra 2017-01-11 11:57 ` Peter Zijlstra 2017-01-15 2:36 ` Suravee Suthikulpanit 2017-01-15 2:36 ` Suravee Suthikulpanit 2017-01-19 10:14 ` Peter Zijlstra 2017-01-19 10:14 ` Peter Zijlstra 2017-01-10 3:33 ` [PATCH v7 2/7] perf/amd/iommu: Modify functions to query max banks and counters Suravee Suthikulpanit 2017-01-10 3:33 ` Suravee Suthikulpanit 2017-01-10 14:43 ` Joerg Roedel 2017-01-10 14:43 ` Joerg Roedel 2017-01-11 3:03 ` Suravee Suthikulpanit 2017-01-11 3:03 ` Suravee Suthikulpanit 2017-01-11 8:13 ` Boris Petkov 2017-01-11 8:13 ` Boris Petkov 2017-01-11 9:14 ` Suravee Suthikulpanit 2017-01-11 9:14 ` Suravee Suthikulpanit 2017-01-10 3:33 ` [PATCH v7 3/7] perf/amd/iommu: Modify IOMMU API to allow specifying IOMMU index Suravee Suthikulpanit 2017-01-10 3:33 ` Suravee Suthikulpanit 2017-01-11 17:23 ` Borislav Petkov 2017-01-10 3:33 ` Suravee Suthikulpanit [this message] 2017-01-10 3:33 ` [PATCH v7 4/7] perf/amd/iommu: Declare pr_fmt and remove unnecessary pr_debug Suravee Suthikulpanit 2017-01-12 10:19 ` Borislav Petkov 2017-01-14 10:13 ` Suravee Suthikulpanit 2017-01-14 10:13 ` Suravee Suthikulpanit 2017-01-10 3:33 ` [PATCH v7 5/7] perf/amd/iommu: Clean up perf_iommu_enable_event Suravee Suthikulpanit 2017-01-10 3:33 ` Suravee Suthikulpanit 2017-01-12 14:14 ` Borislav Petkov 2017-01-12 14:14 ` Borislav Petkov 2017-01-10 3:33 ` [PATCH v7 6/7] iommu/amd: Introduce amd_iommu_get_num_iommus() Suravee Suthikulpanit 2017-01-10 3:33 ` Suravee Suthikulpanit 2017-01-12 14:21 ` Borislav Petkov 2017-01-10 3:33 ` [PATCH v7 7/7] perf/amd/iommu: Enable support for multiple IOMMUs Suravee Suthikulpanit 2017-01-10 3:33 ` Suravee Suthikulpanit 2017-01-12 17:52 ` Borislav Petkov 2017-01-12 17:52 ` Borislav Petkov 2017-01-13 10:24 ` Suravee Suthikulpanit 2017-01-13 10:24 ` Suravee Suthikulpanit 2017-01-13 11:49 ` Borislav Petkov 2017-01-14 2:58 ` Suravee Suthikulpanit 2017-01-14 2:58 ` Suravee Suthikulpanit 2017-01-14 10:29 ` Borislav Petkov 2017-01-14 10:29 ` Borislav Petkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1484019227-11473-5-git-send-email-Suravee.Suthikulpanit@amd.com \ --to=suravee.suthikulpanit@amd.com \ --cc=bp@alien8.de \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.