All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] notify: constify fsnotify_ops structures
@ 2017-01-10 19:50 Bhumika Goyal
  0 siblings, 0 replies; only message in thread
From: Bhumika Goyal @ 2017-01-10 19:50 UTC (permalink / raw)
  To: julia.lawall, eparis, linux-kernel; +Cc: Bhumika Goyal

Declare fsnotify_ops structures as const as they are only passed as an
argument to the function fsnotify_alloc_group. This argument is of type
const, so fsnotify_ops structures having the same property can be
declared const too.
Done using Coccinelle:

@r1 disable optional_qualifier@
identifier i;
position p;
@@
static struct fsnotify_ops i@p={...};

@ok1@
identifier r1.i;
position p;
@@
fsnotify_alloc_group(&i@p)

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct fsnotify_ops i;

File size before: fs/notify/dnotify/dnotify.o
   text	   data	    bss	    dec	    hex	filename
   2227	     71	      0	   2298	    8fa	fs/notify/dnotify/dnotify.o

File size after: fs/notify/dnotify/dnotify.o
   text	   data	    bss	    dec	    hex	filename
   2259	     39	      0	   2298	    8fa	fs/notify/dnotify/dnotify.o

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 fs/notify/dnotify/dnotify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/notify/dnotify/dnotify.c b/fs/notify/dnotify/dnotify.c
index 5a4ec30..33aea5d 100644
--- a/fs/notify/dnotify/dnotify.c
+++ b/fs/notify/dnotify/dnotify.c
@@ -136,7 +136,7 @@ static void dnotify_free_mark(struct fsnotify_mark *fsn_mark)
 	kmem_cache_free(dnotify_mark_cache, dn_mark);
 }
 
-static struct fsnotify_ops dnotify_fsnotify_ops = {
+static const struct fsnotify_ops dnotify_fsnotify_ops = {
 	.handle_event = dnotify_handle_event,
 };
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-01-10 19:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-10 19:50 [PATCH] notify: constify fsnotify_ops structures Bhumika Goyal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.