* [PATCH v2 1/4] staging: android/ion: Split function call
@ 2017-01-12 22:01 Bogdan Purcareata
2017-01-12 22:01 ` [PATCH v2 2/4] staging: android/ion: Don't use return in void function Bogdan Purcareata
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bogdan Purcareata @ 2017-01-12 22:01 UTC (permalink / raw)
To: labbott, sumit.semwal, gregkh, arve, riandrews, devel, linux-kernel
Cc: Bogdan Purcareata
Fix checkpatch error of line exceeding 80 characters.
Signed-off-by: Bogdan Purcareata <bogdan.purcareata@gmail.com>
---
v1 -> v2:
- add changelog
- fix CHECK reports from checkpatch
drivers/staging/android/ion/ion-ioctl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion-ioctl.c b/drivers/staging/android/ion/ion-ioctl.c
index 7e7431d..9ff815a 100644
--- a/drivers/staging/android/ion/ion-ioctl.c
+++ b/drivers/staging/android/ion/ion-ioctl.c
@@ -111,7 +111,8 @@ long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
struct ion_handle *handle;
mutex_lock(&client->lock);
- handle = ion_handle_get_by_id_nolock(client, data.handle.handle);
+ handle = ion_handle_get_by_id_nolock(client,
+ data.handle.handle);
if (IS_ERR(handle)) {
mutex_unlock(&client->lock);
return PTR_ERR(handle);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/4] staging: android/ion: Don't use return in void function
2017-01-12 22:01 [PATCH v2 1/4] staging: android/ion: Split function call Bogdan Purcareata
@ 2017-01-12 22:01 ` Bogdan Purcareata
2017-01-12 22:01 ` [PATCH v2 3/4] staging: android/ion: Align comment mark Bogdan Purcareata
2017-01-12 22:01 ` [PATCH v2 4/4] staging: android/ion: Use variable names in header Bogdan Purcareata
2 siblings, 0 replies; 4+ messages in thread
From: Bogdan Purcareata @ 2017-01-12 22:01 UTC (permalink / raw)
To: labbott, sumit.semwal, gregkh, arve, riandrews, devel, linux-kernel
Cc: Bogdan Purcareata
Return statements are superfluous in void functions, and checkpatch
complains about them too.
Remove offending return.
Signed-off-by: Bogdan Purcareata <bogdan.purcareata@gmail.com>
---
v1 -> v2
- add changelog
drivers/staging/android/ion/ion_of.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
index 46b2bb9..7791c70 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -161,7 +161,6 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev)
static void rmem_ion_device_release(struct reserved_mem *rmem,
struct device *dev)
{
- return;
}
static const struct reserved_mem_ops rmem_dma_ops = {
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 3/4] staging: android/ion: Align comment mark
2017-01-12 22:01 [PATCH v2 1/4] staging: android/ion: Split function call Bogdan Purcareata
2017-01-12 22:01 ` [PATCH v2 2/4] staging: android/ion: Don't use return in void function Bogdan Purcareata
@ 2017-01-12 22:01 ` Bogdan Purcareata
2017-01-12 22:01 ` [PATCH v2 4/4] staging: android/ion: Use variable names in header Bogdan Purcareata
2 siblings, 0 replies; 4+ messages in thread
From: Bogdan Purcareata @ 2017-01-12 22:01 UTC (permalink / raw)
To: labbott, sumit.semwal, gregkh, arve, riandrews, devel, linux-kernel
Cc: Bogdan Purcareata
Fix missing space right before multiple line comment closing.
Signed-off-by: Bogdan Purcareata <bogdan.purcareata@gmail.com>
---
v1 -> v2
- add changelog
drivers/staging/android/ion/ion_priv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_priv.h b/drivers/staging/android/ion/ion_priv.h
index 3c3b324..00d8b53 100644
--- a/drivers/staging/android/ion/ion_priv.h
+++ b/drivers/staging/android/ion/ion_priv.h
@@ -54,7 +54,7 @@
* handle, used for debugging
* @pid: pid of last client to reference this buffer in a
* handle, used for debugging
-*/
+ */
struct ion_buffer {
struct kref ref;
union {
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 4/4] staging: android/ion: Use variable names in header
2017-01-12 22:01 [PATCH v2 1/4] staging: android/ion: Split function call Bogdan Purcareata
2017-01-12 22:01 ` [PATCH v2 2/4] staging: android/ion: Don't use return in void function Bogdan Purcareata
2017-01-12 22:01 ` [PATCH v2 3/4] staging: android/ion: Align comment mark Bogdan Purcareata
@ 2017-01-12 22:01 ` Bogdan Purcareata
2 siblings, 0 replies; 4+ messages in thread
From: Bogdan Purcareata @ 2017-01-12 22:01 UTC (permalink / raw)
To: labbott, sumit.semwal, gregkh, arve, riandrews, devel, linux-kernel
Cc: Bogdan Purcareata
Populate header function signatures with variable names as well, not
just variable types.
Signed-off-by: Bogdan Purcareata <bogdan.purcareata@gmail.com>
---
v1 -> v2:
- fix CHECK report from checkpatch
drivers/staging/android/ion/ion_priv.h | 38 +++++++++++++++++-----------------
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/android/ion/ion_priv.h b/drivers/staging/android/ion/ion_priv.h
index 00d8b53..5b3059c 100644
--- a/drivers/staging/android/ion/ion_priv.h
+++ b/drivers/staging/android/ion/ion_priv.h
@@ -287,10 +287,10 @@ void ion_device_add_heap(struct ion_device *dev, struct ion_heap *heap);
* some helpers for common operations on buffers using the sg_table
* and vaddr fields
*/
-void *ion_heap_map_kernel(struct ion_heap *, struct ion_buffer *);
-void ion_heap_unmap_kernel(struct ion_heap *, struct ion_buffer *);
-int ion_heap_map_user(struct ion_heap *, struct ion_buffer *,
- struct vm_area_struct *);
+void *ion_heap_map_kernel(struct ion_heap *heap, struct ion_buffer *buffer);
+void ion_heap_unmap_kernel(struct ion_heap *heap, struct ion_buffer *buffer);
+int ion_heap_map_user(struct ion_heap *heap, struct ion_buffer *buffer,
+ struct vm_area_struct *vma);
int ion_heap_buffer_zero(struct ion_buffer *buffer);
int ion_heap_pages_zero(struct page *page, size_t size, pgprot_t pgprot);
@@ -371,21 +371,21 @@ size_t ion_heap_freelist_size(struct ion_heap *heap);
* heaps as appropriate.
*/
-struct ion_heap *ion_heap_create(struct ion_platform_heap *);
-void ion_heap_destroy(struct ion_heap *);
-struct ion_heap *ion_system_heap_create(struct ion_platform_heap *);
-void ion_system_heap_destroy(struct ion_heap *);
+struct ion_heap *ion_heap_create(struct ion_platform_heap *heap_data);
+void ion_heap_destroy(struct ion_heap *heap);
+struct ion_heap *ion_system_heap_create(struct ion_platform_heap *unused);
+void ion_system_heap_destroy(struct ion_heap *heap);
-struct ion_heap *ion_system_contig_heap_create(struct ion_platform_heap *);
-void ion_system_contig_heap_destroy(struct ion_heap *);
+struct ion_heap *ion_system_contig_heap_create(struct ion_platform_heap *heap);
+void ion_system_contig_heap_destroy(struct ion_heap *heap);
-struct ion_heap *ion_carveout_heap_create(struct ion_platform_heap *);
-void ion_carveout_heap_destroy(struct ion_heap *);
+struct ion_heap *ion_carveout_heap_create(struct ion_platform_heap *heap_data);
+void ion_carveout_heap_destroy(struct ion_heap *heap);
-struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *);
-void ion_chunk_heap_destroy(struct ion_heap *);
-struct ion_heap *ion_cma_heap_create(struct ion_platform_heap *);
-void ion_cma_heap_destroy(struct ion_heap *);
+struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *heap_data);
+void ion_chunk_heap_destroy(struct ion_heap *heap);
+struct ion_heap *ion_cma_heap_create(struct ion_platform_heap *data);
+void ion_cma_heap_destroy(struct ion_heap *heap);
/**
* functions for creating and destroying a heap pool -- allows you
@@ -427,9 +427,9 @@ struct ion_page_pool {
struct ion_page_pool *ion_page_pool_create(gfp_t gfp_mask, unsigned int order,
bool cached);
-void ion_page_pool_destroy(struct ion_page_pool *);
-struct page *ion_page_pool_alloc(struct ion_page_pool *);
-void ion_page_pool_free(struct ion_page_pool *, struct page *);
+void ion_page_pool_destroy(struct ion_page_pool *pool);
+struct page *ion_page_pool_alloc(struct ion_page_pool *pool);
+void ion_page_pool_free(struct ion_page_pool *pool, struct page *page);
/** ion_page_pool_shrink - shrinks the size of the memory cached in the pool
* @pool: the pool
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-12 22:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-12 22:01 [PATCH v2 1/4] staging: android/ion: Split function call Bogdan Purcareata
2017-01-12 22:01 ` [PATCH v2 2/4] staging: android/ion: Don't use return in void function Bogdan Purcareata
2017-01-12 22:01 ` [PATCH v2 3/4] staging: android/ion: Align comment mark Bogdan Purcareata
2017-01-12 22:01 ` [PATCH v2 4/4] staging: android/ion: Use variable names in header Bogdan Purcareata
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.