From: David Howells <dhowells@redhat.com>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: dhowells@redhat.com, Herbert Xu <herbert@gondor.apana.org.au>,
Mimi Zohar <zohar@linux.ibm.com>,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 04/10] crypto: akcipher - new verify API for public key algorithms
Date: Thu, 28 Feb 2019 18:18:54 +0000 [thread overview]
Message-ID: <14843.1551377934@warthog.procyon.org.uk> (raw)
In-Reply-To: <20190224060828.2527-5-vt@altlinux.org>
Vitaly Chikunov <vt@altlinux.org> wrote:
> + digest = kmemdup(sig->digest, sig->digest_size, GFP_KERNEL);
> + if (!digest)
You shouldn't need to copy the digest. It's being passed in to the crypto
algorithm, not extracted out.
> + if (memcmp(c, outbuf_enc, c_size)) {
Please use == 0 and != 0 with memcmp() and strcmp(). Their return values are
kind of inverted in sense if you treat them as boolean.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: dhowells@redhat.com, Herbert Xu <herbert@gondor.apana.org.au>,
Mimi Zohar <zohar@linux.ibm.com>,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 04/10] crypto: akcipher - new verify API for public key algorithms
Date: Thu, 28 Feb 2019 18:18:54 +0000 [thread overview]
Message-ID: <14843.1551377934@warthog.procyon.org.uk> (raw)
In-Reply-To: <20190224060828.2527-5-vt@altlinux.org>
Vitaly Chikunov <vt@altlinux.org> wrote:
> + digest = kmemdup(sig->digest, sig->digest_size, GFP_KERNEL);
> + if (!digest)
You shouldn't need to copy the digest. It's being passed in to the crypto
algorithm, not extracted out.
> + if (memcmp(c, outbuf_enc, c_size)) {
Please use = 0 and != 0 with memcmp() and strcmp(). Their return values are
kind of inverted in sense if you treat them as boolean.
David
next prev parent reply other threads:[~2019-02-28 18:19 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 6:08 [PATCH v5 00/10] crypto: add EC-RDSA (GOST 34.10) algorithm Vitaly Chikunov
2019-02-24 6:08 ` Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 01/10] KEYS: report to keyctl only actually supported key ops Vitaly Chikunov
2019-02-24 6:08 ` Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 02/10] crypto: akcipher - check the presence of callback before the call Vitaly Chikunov
2019-02-24 6:08 ` Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 03/10] crypto: rsa - unimplement sign/verify for raw RSA backends Vitaly Chikunov
2019-02-24 6:08 ` Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 04/10] crypto: akcipher - new verify API for public key algorithms Vitaly Chikunov
2019-02-24 6:08 ` Vitaly Chikunov
2019-02-27 23:28 ` Mimi Zohar
2019-02-27 23:28 ` Mimi Zohar
2019-02-28 5:37 ` Vitaly Chikunov
2019-02-28 5:37 ` Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 05/10] X.509: parse public key parameters from x509 for akcipher Vitaly Chikunov
2019-02-24 6:08 ` Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 06/10] crypto: Kconfig - create Public-key cryptography section Vitaly Chikunov
2019-02-24 6:08 ` Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 07/10] crypto: ecc - make ecc into separate module Vitaly Chikunov
2019-02-24 6:08 ` Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 08/10] crypto: ecrdsa - add EC-RDSA (GOST 34.10) algorithm Vitaly Chikunov
2019-02-24 6:08 ` Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 09/10] crypto: ecrdsa - add EC-RDSA test vectors to testmgr Vitaly Chikunov
2019-02-24 6:08 ` Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 10/10] integrity: support EC-RDSA signatures for asymmetric_verify Vitaly Chikunov
2019-02-24 6:08 ` Vitaly Chikunov
2019-02-25 21:20 ` Thiago Jung Bauermann
2019-02-25 21:20 ` Thiago Jung Bauermann
2019-02-26 4:25 ` Vitaly Chikunov
2019-02-26 4:25 ` Vitaly Chikunov
2019-02-26 12:07 ` Mimi Zohar
2019-02-26 12:07 ` Mimi Zohar
2019-02-28 18:18 ` David Howells [this message]
2019-02-28 18:18 ` [PATCH v5 04/10] crypto: akcipher - new verify API for public key algorithms David Howells
2019-02-28 18:39 ` Vitaly Chikunov
2019-02-28 18:39 ` Vitaly Chikunov
2019-02-28 19:02 ` David Howells
2019-02-28 19:07 ` Vitaly Chikunov
2019-02-28 19:07 ` Vitaly Chikunov
2019-03-01 2:34 ` Herbert Xu
2019-03-01 2:34 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14843.1551377934@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vt@altlinux.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.