From: Prarit Bhargava <prarit@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Prarit Bhargava <prarit@redhat.com>,
Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-edac@vger.kernel.org
Subject: [PATCH] x86/mce: Fix initialization error warning
Date: Mon, 16 Jan 2017 16:49:41 -0500 [thread overview]
Message-ID: <1484603381-15018-1-git-send-email-prarit@redhat.com> (raw)
When booting kernel with mce=off a loud warning from the mce code
is displayed. This causes confusion for end users.
Add a check to see if MCE is available before outputting the warning
message.
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: linux-edac@vger.kernel.org
---
arch/x86/kernel/cpu/mcheck/mce.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index 00ef43233e03..943a0c440c55 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -2662,7 +2662,8 @@ static __init int mcheck_init_device(void)
free_cpumask_var(mce_device_initialized);
err_out:
- pr_err("Unable to init device /dev/mcelog (rc: %d)\n", err);
+ if (mce_available(&boot_cpu_data))
+ pr_err("Unable to init device /dev/mcelog (rc: %d)\n", err);
return err;
}
--
1.7.9.3
next reply other threads:[~2017-01-16 22:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 21:49 Prarit Bhargava [this message]
2017-01-16 21:56 ` [PATCH] x86/mce: Fix initialization error warning Thomas Gleixner
2017-01-16 21:56 ` Borislav Petkov
2017-01-16 22:06 ` Prarit Bhargava
2017-01-16 22:43 ` Borislav Petkov
2017-01-16 23:13 ` Prarit Bhargava
2017-01-16 23:32 ` Borislav Petkov
2017-01-16 23:50 ` Prarit Bhargava
2017-01-17 8:34 ` Thomas Gleixner
2017-01-17 9:08 ` Borislav Petkov
2017-01-17 9:09 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484603381-15018-1-git-send-email-prarit@redhat.com \
--to=prarit@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.