From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>
Cc: Prarit Bhargava <prarit@redhat.com>,
linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH] x86/mce: Fix initialization error warning
Date: Tue, 17 Jan 2017 10:09:56 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1701171009400.3495@nanos> (raw)
In-Reply-To: <20170117090814.o6ur3d5dbeyqlqds@pd.tnic>
On Tue, 17 Jan 2017, Borislav Petkov wrote:
> On Tue, Jan 17, 2017 at 09:34:18AM +0100, Thomas Gleixner wrote:
> > That's one thing, but OTOH we really can avoid the KERN_ERR level print out
> > for the case where mce is not available (for whatever reasons: HW / Virt /
> > command line ....).
> >
> > The simple 2 liner I posted earlier in this thread does it nicely.
>
> Well, I seem to remember at the time of this:
>
> 9c15a24b038f ("x86/mce: Improve mcheck_init_device() error handling")
>
> that I requested to have that error message there so that we *know* when
> that function fails instead of trying to decipher "Hey, mcelog doesn't
> start here" and wonder why.
>
> But we can kill it just as well, especially as there's patch deprecating
> /dev/mcelog floating around. We can reorg error messages in that
> function later, if deemed necessary.
Your decision.
prev parent reply other threads:[~2017-01-17 9:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 21:49 [PATCH] x86/mce: Fix initialization error warning Prarit Bhargava
2017-01-16 21:56 ` Thomas Gleixner
2017-01-16 21:56 ` Borislav Petkov
2017-01-16 22:06 ` Prarit Bhargava
2017-01-16 22:43 ` Borislav Petkov
2017-01-16 23:13 ` Prarit Bhargava
2017-01-16 23:32 ` Borislav Petkov
2017-01-16 23:50 ` Prarit Bhargava
2017-01-17 8:34 ` Thomas Gleixner
2017-01-17 9:08 ` Borislav Petkov
2017-01-17 9:09 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1701171009400.3495@nanos \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=prarit@redhat.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.