* [PATCH 1/1] drm/amdgpu: fix unload driver issue for virtual display
@ 2017-01-19 2:03 Xiangliang Yu
[not found] ` <1484791420-7341-1-git-send-email-Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Xiangliang Yu @ 2017-01-19 2:03 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Xiangliang Yu
Virtual display doesn't allocate amdgpu_encoder when initializing,
so will get invaild pointer if try to free amdgpu_encoder when
unloading driver.
Signed-off-by: Xiangliang Yu <Xiangliang.Yu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
index 64dd266..fc12cdf 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
@@ -634,11 +634,8 @@ static const struct drm_encoder_helper_funcs dce_virtual_encoder_helper_funcs =
static void dce_virtual_encoder_destroy(struct drm_encoder *encoder)
{
- struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
-
- kfree(amdgpu_encoder->enc_priv);
drm_encoder_cleanup(encoder);
- kfree(amdgpu_encoder);
+ kfree(encoder);
}
static const struct drm_encoder_funcs dce_virtual_encoder_funcs = {
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] drm/amdgpu: fix unload driver issue for virtual display
[not found] ` <1484791420-7341-1-git-send-email-Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org>
@ 2017-01-19 8:48 ` Christian König
2017-01-19 13:54 ` Alex Deucher
1 sibling, 0 replies; 3+ messages in thread
From: Christian König @ 2017-01-19 8:48 UTC (permalink / raw)
To: Xiangliang Yu, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Am 19.01.2017 um 03:03 schrieb Xiangliang Yu:
> Virtual display doesn't allocate amdgpu_encoder when initializing,
> so will get invaild pointer if try to free amdgpu_encoder when
> unloading driver.
>
> Signed-off-by: Xiangliang Yu <Xiangliang.Yu@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> index 64dd266..fc12cdf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> +++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> @@ -634,11 +634,8 @@ static const struct drm_encoder_helper_funcs dce_virtual_encoder_helper_funcs =
>
> static void dce_virtual_encoder_destroy(struct drm_encoder *encoder)
> {
> - struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
> -
> - kfree(amdgpu_encoder->enc_priv);
> drm_encoder_cleanup(encoder);
> - kfree(amdgpu_encoder);
> + kfree(encoder);
> }
>
> static const struct drm_encoder_funcs dce_virtual_encoder_funcs = {
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] drm/amdgpu: fix unload driver issue for virtual display
[not found] ` <1484791420-7341-1-git-send-email-Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org>
2017-01-19 8:48 ` Christian König
@ 2017-01-19 13:54 ` Alex Deucher
1 sibling, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2017-01-19 13:54 UTC (permalink / raw)
To: Xiangliang Yu; +Cc: amd-gfx list
On Wed, Jan 18, 2017 at 9:03 PM, Xiangliang Yu <Xiangliang.Yu@amd.com> wrote:
> Virtual display doesn't allocate amdgpu_encoder when initializing,
> so will get invaild pointer if try to free amdgpu_encoder when
> unloading driver.
>
> Signed-off-by: Xiangliang Yu <Xiangliang.Yu@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> index 64dd266..fc12cdf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> +++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> @@ -634,11 +634,8 @@ static const struct drm_encoder_helper_funcs dce_virtual_encoder_helper_funcs =
>
> static void dce_virtual_encoder_destroy(struct drm_encoder *encoder)
> {
> - struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
> -
> - kfree(amdgpu_encoder->enc_priv);
> drm_encoder_cleanup(encoder);
> - kfree(amdgpu_encoder);
> + kfree(encoder);
> }
>
> static const struct drm_encoder_funcs dce_virtual_encoder_funcs = {
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-19 13:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-19 2:03 [PATCH 1/1] drm/amdgpu: fix unload driver issue for virtual display Xiangliang Yu
[not found] ` <1484791420-7341-1-git-send-email-Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org>
2017-01-19 8:48 ` Christian König
2017-01-19 13:54 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.