All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
To: Cyril Bur <cyrilbur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	arnd-r2nGTMty4D4@public.gmane.org,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	andrew-zrmu5oMJ5Fs@public.gmane.org,
	xow-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	jk-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH 1/4] Documentation: dt: mailbox: Add Aspeed ast2400/2500 bindings
Date: Thu, 19 Jan 2017 09:08:47 -0600	[thread overview]
Message-ID: <1484838527.24294.45.camel@kernel.crashing.org> (raw)
In-Reply-To: <1484784318.4097.2.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Thu, 2017-01-19 at 11:05 +1100, Cyril Bur wrote:
> > > +============
> > > +This represents the mailbox on the Soc.
> > > +
> > > +As the mailbox registers sit on the LPC bus, it makes most sense for
> > > +the device to be within the LPC host node. See
> > > +Documentation/devicetree/bindings/mfd/aspeed-lpc.txt for more
> > > +information. This does not have to be the case, provided the reg
> > > +property can give the full address of the mbox registers.
> > 
> > This does have to be the case. I'd expect all devices on the LPC bus to 
> > be under a LPC bus node.
> > 
> > Drop the last sentence, and:
> > 
> > Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> 
> Will do, thanks for the review.

Well well ... on the BMC side it's not actually on the LPC bus ;-)

However it's within the LPC host controller register set, and so as such
can be represented as a child of it.

Cheers,
Ben.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Cyril Bur <cyrilbur@gmail.com>, Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, jassisinghbrar@gmail.com,
	arnd@arndb.de, gregkh@linuxfoundation.org, joel@jms.id.au,
	mark.rutland@arm.com, openbmc@lists.ozlabs.org, andrew@aj.id.au,
	xow@google.com, jk@ozlabs.org
Subject: Re: [PATCH 1/4] Documentation: dt: mailbox: Add Aspeed ast2400/2500 bindings
Date: Thu, 19 Jan 2017 09:08:47 -0600	[thread overview]
Message-ID: <1484838527.24294.45.camel@kernel.crashing.org> (raw)
In-Reply-To: <1484784318.4097.2.camel@gmail.com>

On Thu, 2017-01-19 at 11:05 +1100, Cyril Bur wrote:
> > > +============
> > > +This represents the mailbox on the Soc.
> > > +
> > > +As the mailbox registers sit on the LPC bus, it makes most sense for
> > > +the device to be within the LPC host node. See
> > > +Documentation/devicetree/bindings/mfd/aspeed-lpc.txt for more
> > > +information. This does not have to be the case, provided the reg
> > > +property can give the full address of the mbox registers.
> > 
> > This does have to be the case. I'd expect all devices on the LPC bus to 
> > be under a LPC bus node.
> > 
> > Drop the last sentence, and:
> > 
> > Acked-by: Rob Herring <robh@kernel.org>
> 
> Will do, thanks for the review.

Well well ... on the BMC side it's not actually on the LPC bus ;-)

However it's within the LPC host controller register set, and so as such
can be represented as a child of it.

Cheers,
Ben.

  parent reply	other threads:[~2017-01-19 15:08 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-12  0:29 [PATCH 0/4] ASpeed mailbox and LPC control drivers Cyril Bur
2017-01-12  0:29 ` Cyril Bur
     [not found] ` <20170112002910.3650-1-cyrilbur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-12  0:29   ` [PATCH 1/4] Documentation: dt: mailbox: Add Aspeed ast2400/2500 bindings Cyril Bur
2017-01-12  0:29     ` Cyril Bur
     [not found]     ` <20170112002910.3650-2-cyrilbur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-18 20:38       ` Rob Herring
2017-01-18 20:38         ` Rob Herring
2017-01-19  0:05         ` Cyril Bur
2017-01-19  0:05           ` Cyril Bur
     [not found]           ` <1484784318.4097.2.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-19 15:08             ` Benjamin Herrenschmidt [this message]
2017-01-19 15:08               ` Benjamin Herrenschmidt
2017-01-12  0:29   ` [PATCH 2/4] Documentation: dt: misc: Add Aspeed ast2400/2500 LPC Control bindings Cyril Bur
2017-01-12  0:29     ` Cyril Bur
     [not found]     ` <20170112002910.3650-3-cyrilbur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-18 21:16       ` Rob Herring
2017-01-18 21:16         ` Rob Herring
2017-01-19  0:19         ` Cyril Bur
2017-01-19  0:19           ` Cyril Bur
2017-01-12  0:29   ` [PATCH 3/4] drivers/misc: Add ASpeed LPC control driver Cyril Bur
2017-01-12  0:29     ` Cyril Bur
     [not found]     ` <20170112002910.3650-4-cyrilbur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-12  7:43       ` Greg KH
2017-01-12  7:43         ` Greg KH
     [not found]         ` <20170112074312.GA23943-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-01-12 15:36           ` Benjamin Herrenschmidt
2017-01-12 15:36             ` Benjamin Herrenschmidt
2017-01-12  7:47       ` Greg KH
2017-01-12  7:47         ` Greg KH
     [not found]         ` <20170112074750.GB23943-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-01-12 10:16           ` Cyril Bur
2017-01-12 10:16             ` Cyril Bur
     [not found]             ` <1484216163.11416.8.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-12 10:30               ` Greg KH
2017-01-12 10:30                 ` Greg KH
     [not found]                 ` <20170112103038.GA19239-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-01-12 15:27                   ` Benjamin Herrenschmidt
2017-01-12 15:27                     ` Benjamin Herrenschmidt
     [not found]                     ` <1484234867.2492.39.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2017-01-12 16:00                       ` Greg KH
2017-01-12 16:00                         ` Greg KH
     [not found]                         ` <20170112160051.GB8095-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-01-12 16:07                           ` Benjamin Herrenschmidt
2017-01-12 16:07                             ` Benjamin Herrenschmidt
     [not found]                             ` <1484237253.2492.43.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2017-01-12 16:26                               ` Greg KH
2017-01-12 16:26                                 ` Greg KH
     [not found]                                 ` <20170112162619.GB10283-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-01-12 16:31                                   ` Benjamin Herrenschmidt
2017-01-12 16:31                                     ` Benjamin Herrenschmidt
2017-01-12 15:35               ` Benjamin Herrenschmidt
2017-01-12 15:35                 ` Benjamin Herrenschmidt
     [not found]                 ` <1484235315.2492.41.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2017-01-12 16:27                   ` Greg KH
2017-01-12 16:27                     ` Greg KH
2017-01-12 16:29                   ` Benjamin Herrenschmidt
2017-01-12 16:29                     ` Benjamin Herrenschmidt
     [not found]                     ` <1484238577.2492.45.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2017-01-12 17:27                       ` Greg KH
2017-01-12 17:27                         ` Greg KH
2017-01-12  0:29   ` [PATCH 4/4] drivers/mailbox: Add ASpeed mailbox driver Cyril Bur
2017-01-12  0:29     ` Cyril Bur
     [not found]     ` <20170112002910.3650-5-cyrilbur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-07  5:40       ` Joel Stanley
2017-02-07  5:40         ` Joel Stanley
     [not found]         ` <CACPK8XcsScjrit-7VHh4oL=zPiMeEAB5_R550U0uPsuQ4WF1mg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-07  5:44           ` Benjamin Herrenschmidt
2017-02-07  5:44             ` Benjamin Herrenschmidt
2017-02-07 22:57           ` Cyril Bur
2017-02-07 22:57             ` Cyril Bur
     [not found]             ` <1486508229.3824.1.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-07 22:59               ` Joel Stanley
2017-02-07 22:59                 ` Joel Stanley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484838527.24294.45.camel@kernel.crashing.org \
    --to=benh-xvmvhmargas8u2djnn8i7kb+6bgklq7r@public.gmane.org \
    --cc=andrew-zrmu5oMJ5Fs@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=cyrilbur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jk-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
    --cc=joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=xow-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.