* [PATCH] arm64: dts: exynos: Disable pull down for audio pins in Exynos5433 SoCs
[not found] <CGME20170120065702eucas1p1dd0b370aa6cba11d26ce2ed1651f16b9@eucas1p1.samsung.com>
@ 2017-01-20 6:56 ` Marek Szyprowski
2017-01-20 10:35 ` Javier Martinez Canillas
2017-01-20 15:16 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Marek Szyprowski @ 2017-01-20 6:56 UTC (permalink / raw)
To: linux-samsung-soc
Cc: Marek Szyprowski, Sylwester Nawrocki, Krzysztof Kozlowski,
Bartlomiej Zolnierkiewicz, Chanwoo Choi
Common definition for I2S, PMC, SPDIF buses should not define any pull
control for the individual pins. Correct this by changing samsung,pin-pud
property to EXYNOS_PIN_PULL_NONE like it is defined for other Exynos SoCs.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi
index d49879bd34bb..50403700274b 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi
@@ -135,14 +135,14 @@
samsung,pins = "gpz0-0", "gpz0-1", "gpz0-2", "gpz0-3",
"gpz0-4", "gpz0-5", "gpz0-6";
samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
- samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+ samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS5433_PIN_DRV_FAST_SR1>;
};
pcm0_bus: pcm0-bus {
samsung,pins = "gpz1-0", "gpz1-1", "gpz1-2", "gpz1-3";
samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
- samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+ samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS5433_PIN_DRV_FAST_SR1>;
};
@@ -569,7 +569,7 @@
samsung,pins = "gpd4-0", "gpd4-1", "gpd4-2",
"gpd4-3", "gpd4-4";
samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
- samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+ samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS5433_PIN_DRV_FAST_SR1>;
};
@@ -577,14 +577,14 @@
samsung,pins = "gpd4-0", "gpd4-1", "gpd4-2",
"gpd4-3", "gpd4-4";
samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
- samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+ samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS5433_PIN_DRV_FAST_SR1>;
};
spdif_bus: spdif-bus {
samsung,pins = "gpd4-3", "gpd4-4";
samsung,pin-function = <EXYNOS_PIN_FUNC_4>;
- samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+ samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS5433_PIN_DRV_FAST_SR1>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: exynos: Disable pull down for audio pins in Exynos5433 SoCs
2017-01-20 6:56 ` [PATCH] arm64: dts: exynos: Disable pull down for audio pins in Exynos5433 SoCs Marek Szyprowski
@ 2017-01-20 10:35 ` Javier Martinez Canillas
2017-01-20 15:16 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2017-01-20 10:35 UTC (permalink / raw)
To: Marek Szyprowski, linux-samsung-soc
Cc: Sylwester Nawrocki, Krzysztof Kozlowski,
Bartlomiej Zolnierkiewicz, Chanwoo Choi
Hello Marek,
On 01/20/2017 03:56 AM, Marek Szyprowski wrote:
> Common definition for I2S, PMC, SPDIF buses should not define any pull
> control for the individual pins. Correct this by changing samsung,pin-pud
> property to EXYNOS_PIN_PULL_NONE like it is defined for other Exynos SoCs.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
Looks good to me.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: exynos: Disable pull down for audio pins in Exynos5433 SoCs
2017-01-20 6:56 ` [PATCH] arm64: dts: exynos: Disable pull down for audio pins in Exynos5433 SoCs Marek Szyprowski
2017-01-20 10:35 ` Javier Martinez Canillas
@ 2017-01-20 15:16 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2017-01-20 15:16 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-samsung-soc, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz,
Chanwoo Choi
On Fri, Jan 20, 2017 at 07:56:53AM +0100, Marek Szyprowski wrote:
> Common definition for I2S, PMC, SPDIF buses should not define any pull
> control for the individual pins. Correct this by changing samsung,pin-pud
> property to EXYNOS_PIN_PULL_NONE like it is defined for other Exynos SoCs.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Thanks, applied.
--
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-20 15:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170120065702eucas1p1dd0b370aa6cba11d26ce2ed1651f16b9@eucas1p1.samsung.com>
2017-01-20 6:56 ` [PATCH] arm64: dts: exynos: Disable pull down for audio pins in Exynos5433 SoCs Marek Szyprowski
2017-01-20 10:35 ` Javier Martinez Canillas
2017-01-20 15:16 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.