* [PATCH] serial: sh-sci: Reformat sci_parse_dt() for git diff
@ 2017-01-25 14:55 Geert Uytterhoeven
2017-01-25 16:45 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2017-01-25 14:55 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: linux-serial, linux-renesas-soc, Geert Uytterhoeven
As the function header of sci_parse_dt() is split in an unusual way,
"git diff" gets confused when changes to the body of the function are
made, and attributes them to the wrong function.
Reformat the function header to fix this.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/tty/serial/sh-sci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index 9bc9756a2d15d574..a589544f320661f5 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -2816,8 +2816,8 @@ static int sci_remove(struct platform_device *dev)
};
MODULE_DEVICE_TABLE(of, of_sci_match);
-static struct plat_sci_port *
-sci_parse_dt(struct platform_device *pdev, unsigned int *dev_id)
+static struct plat_sci_port *sci_parse_dt(struct platform_device *pdev,
+ unsigned int *dev_id)
{
struct device_node *np = pdev->dev.of_node;
const struct of_device_id *match;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: sh-sci: Reformat sci_parse_dt() for git diff
2017-01-25 14:55 [PATCH] serial: sh-sci: Reformat sci_parse_dt() for git diff Geert Uytterhoeven
@ 2017-01-25 16:45 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2017-01-25 16:45 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial, linux-renesas-soc
On Wed, Jan 25, 2017 at 03:55:49PM +0100, Geert Uytterhoeven wrote:
> As the function header of sci_parse_dt() is split in an unusual way,
> "git diff" gets confused when changes to the body of the function are
> made, and attributes them to the wrong function.
>
> Reformat the function header to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/tty/serial/sh-sci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 9bc9756a2d15d574..a589544f320661f5 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -2816,8 +2816,8 @@ static int sci_remove(struct platform_device *dev)
> };
> MODULE_DEVICE_TABLE(of, of_sci_match);
>
> -static struct plat_sci_port *
> -sci_parse_dt(struct platform_device *pdev, unsigned int *dev_id)
> +static struct plat_sci_port *sci_parse_dt(struct platform_device *pdev,
> + unsigned int *dev_id)
> {
> struct device_node *np = pdev->dev.of_node;
> const struct of_device_id *match;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-25 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-25 14:55 [PATCH] serial: sh-sci: Reformat sci_parse_dt() for git diff Geert Uytterhoeven
2017-01-25 16:45 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.