* [patch] qla4xxx: remove some bogus casts
@ 2015-08-17 14:36 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2015-08-17 14:36 UTC (permalink / raw)
To: QLogic-Storage-Upstream, Vikas Chaudhary
Cc: James E.J. Bottomley, linux-scsi, kernel-janitors
These casts are wrong and unnecessary. They annoy static checkers
because they imply we are planning to write sizeof(long) bytes to a
sizeof(u32) buffer which would corrupt memory.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c
index 4180d6d..d97ea5d 100644
--- a/drivers/scsi/qla4xxx/ql4_init.c
+++ b/drivers/scsi/qla4xxx/ql4_init.c
@@ -101,19 +101,13 @@ int qla4xxx_init_rings(struct scsi_qla_host *ha)
ha->response_ptr = &ha->response_ring[ha->response_out];
if (is_qla8022(ha)) {
- writel(0,
- (unsigned long __iomem *)&ha->qla4_82xx_reg->req_q_out);
- writel(0,
- (unsigned long __iomem *)&ha->qla4_82xx_reg->rsp_q_in);
- writel(0,
- (unsigned long __iomem *)&ha->qla4_82xx_reg->rsp_q_out);
+ writel(0, &ha->qla4_82xx_reg->req_q_out);
+ writel(0, &ha->qla4_82xx_reg->rsp_q_in);
+ writel(0, &ha->qla4_82xx_reg->rsp_q_out);
} else if (is_qla8032(ha) || is_qla8042(ha)) {
- writel(0,
- (unsigned long __iomem *)&ha->qla4_83xx_reg->req_q_in);
- writel(0,
- (unsigned long __iomem *)&ha->qla4_83xx_reg->rsp_q_in);
- writel(0,
- (unsigned long __iomem *)&ha->qla4_83xx_reg->rsp_q_out);
+ writel(0, &ha->qla4_83xx_reg->req_q_in);
+ writel(0, &ha->qla4_83xx_reg->rsp_q_in);
+ writel(0, &ha->qla4_83xx_reg->rsp_q_out);
} else {
/*
* Initialize DMA Shadow registers. The firmware is really
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [patch] qla4xxx: remove some bogus casts
@ 2015-08-17 14:36 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2015-08-17 14:36 UTC (permalink / raw)
To: QLogic-Storage-Upstream, Vikas Chaudhary
Cc: James E.J. Bottomley, linux-scsi, kernel-janitors
These casts are wrong and unnecessary. They annoy static checkers
because they imply we are planning to write sizeof(long) bytes to a
sizeof(u32) buffer which would corrupt memory.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c
index 4180d6d..d97ea5d 100644
--- a/drivers/scsi/qla4xxx/ql4_init.c
+++ b/drivers/scsi/qla4xxx/ql4_init.c
@@ -101,19 +101,13 @@ int qla4xxx_init_rings(struct scsi_qla_host *ha)
ha->response_ptr = &ha->response_ring[ha->response_out];
if (is_qla8022(ha)) {
- writel(0,
- (unsigned long __iomem *)&ha->qla4_82xx_reg->req_q_out);
- writel(0,
- (unsigned long __iomem *)&ha->qla4_82xx_reg->rsp_q_in);
- writel(0,
- (unsigned long __iomem *)&ha->qla4_82xx_reg->rsp_q_out);
+ writel(0, &ha->qla4_82xx_reg->req_q_out);
+ writel(0, &ha->qla4_82xx_reg->rsp_q_in);
+ writel(0, &ha->qla4_82xx_reg->rsp_q_out);
} else if (is_qla8032(ha) || is_qla8042(ha)) {
- writel(0,
- (unsigned long __iomem *)&ha->qla4_83xx_reg->req_q_in);
- writel(0,
- (unsigned long __iomem *)&ha->qla4_83xx_reg->rsp_q_in);
- writel(0,
- (unsigned long __iomem *)&ha->qla4_83xx_reg->rsp_q_out);
+ writel(0, &ha->qla4_83xx_reg->req_q_in);
+ writel(0, &ha->qla4_83xx_reg->rsp_q_in);
+ writel(0, &ha->qla4_83xx_reg->rsp_q_out);
} else {
/*
* Initialize DMA Shadow registers. The firmware is really
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [patch] qla4xxx: remove some bogus casts
2015-08-17 14:36 ` Dan Carpenter
@ 2015-08-18 4:45 ` Bart Van Assche
-1 siblings, 0 replies; 10+ messages in thread
From: Bart Van Assche @ 2015-08-18 4:45 UTC (permalink / raw)
To: Dan Carpenter, QLogic-Storage-Upstream, Vikas Chaudhary
Cc: James E.J. Bottomley, linux-scsi, kernel-janitors
On 08/17/2015 07:36 AM, Dan Carpenter wrote:
> These casts are wrong and unnecessary. They annoy static checkers
> because they imply we are planning to write sizeof(long) bytes to a
> sizeof(u32) buffer which would corrupt memory.
Hello Dan,
Can you verify whether that patch is still needed after having applied
the patch series I posted in July (and that was acknowledged by QLogic):
http://thread.gmane.org/gmane.linux.scsi/103135 ?
Thanks,
Bart.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch] qla4xxx: remove some bogus casts
@ 2015-08-18 4:45 ` Bart Van Assche
0 siblings, 0 replies; 10+ messages in thread
From: Bart Van Assche @ 2015-08-18 4:45 UTC (permalink / raw)
To: Dan Carpenter, QLogic-Storage-Upstream, Vikas Chaudhary
Cc: James E.J. Bottomley, linux-scsi, kernel-janitors
On 08/17/2015 07:36 AM, Dan Carpenter wrote:
> These casts are wrong and unnecessary. They annoy static checkers
> because they imply we are planning to write sizeof(long) bytes to a
> sizeof(u32) buffer which would corrupt memory.
Hello Dan,
Can you verify whether that patch is still needed after having applied
the patch series I posted in July (and that was acknowledged by QLogic):
http://thread.gmane.org/gmane.linux.scsi/103135 ?
Thanks,
Bart.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch] qla4xxx: remove some bogus casts
2015-08-18 4:45 ` Bart Van Assche
@ 2015-08-18 8:47 ` Dan Carpenter
-1 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2015-08-18 8:47 UTC (permalink / raw)
To: Bart Van Assche
Cc: QLogic-Storage-Upstream, Vikas Chaudhary, James E.J. Bottomley,
linux-scsi, kernel-janitors
On Mon, Aug 17, 2015 at 09:45:45PM -0700, Bart Van Assche wrote:
> On 08/17/2015 07:36 AM, Dan Carpenter wrote:
> >These casts are wrong and unnecessary. They annoy static checkers
> >because they imply we are planning to write sizeof(long) bytes to a
> >sizeof(u32) buffer which would corrupt memory.
>
> Hello Dan,
>
> Can you verify whether that patch is still needed after having
> applied the patch series I posted in July (and that was acknowledged
> by QLogic): http://thread.gmane.org/gmane.linux.scsi/103135 ?
>
I think it is needed still?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch] qla4xxx: remove some bogus casts
@ 2015-08-18 8:47 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2015-08-18 8:47 UTC (permalink / raw)
To: Bart Van Assche
Cc: QLogic-Storage-Upstream, Vikas Chaudhary, James E.J. Bottomley,
linux-scsi, kernel-janitors
On Mon, Aug 17, 2015 at 09:45:45PM -0700, Bart Van Assche wrote:
> On 08/17/2015 07:36 AM, Dan Carpenter wrote:
> >These casts are wrong and unnecessary. They annoy static checkers
> >because they imply we are planning to write sizeof(long) bytes to a
> >sizeof(u32) buffer which would corrupt memory.
>
> Hello Dan,
>
> Can you verify whether that patch is still needed after having
> applied the patch series I posted in July (and that was acknowledged
> by QLogic): http://thread.gmane.org/gmane.linux.scsi/103135 ?
>
I think it is needed still?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch] qla4xxx: remove some bogus casts
2015-08-18 8:47 ` Dan Carpenter
@ 2015-08-23 1:41 ` Bart Van Assche
-1 siblings, 0 replies; 10+ messages in thread
From: Bart Van Assche @ 2015-08-23 1:41 UTC (permalink / raw)
To: Dan Carpenter
Cc: QLogic-Storage-Upstream, Vikas Chaudhary, James E.J. Bottomley,
linux-scsi, kernel-janitors
On 08/18/15 01:47, Dan Carpenter wrote:
> On Mon, Aug 17, 2015 at 09:45:45PM -0700, Bart Van Assche wrote:
>> On 08/17/2015 07:36 AM, Dan Carpenter wrote:
>>> These casts are wrong and unnecessary. They annoy static checkers
>>> because they imply we are planning to write sizeof(long) bytes to a
>>> sizeof(u32) buffer which would corrupt memory.
>>
>> Hello Dan,
>>
>> Can you verify whether that patch is still needed after having
>> applied the patch series I posted in July (and that was acknowledged
>> by QLogic): http://thread.gmane.org/gmane.linux.scsi/103135 ?
>>
>
> I think it is needed still?
Hello Dan,
You are right, this patch is indeed needed. Hence:
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch] qla4xxx: remove some bogus casts
@ 2015-08-23 1:41 ` Bart Van Assche
0 siblings, 0 replies; 10+ messages in thread
From: Bart Van Assche @ 2015-08-23 1:41 UTC (permalink / raw)
To: Dan Carpenter
Cc: QLogic-Storage-Upstream, Vikas Chaudhary, James E.J. Bottomley,
linux-scsi, kernel-janitors
On 08/18/15 01:47, Dan Carpenter wrote:
> On Mon, Aug 17, 2015 at 09:45:45PM -0700, Bart Van Assche wrote:
>> On 08/17/2015 07:36 AM, Dan Carpenter wrote:
>>> These casts are wrong and unnecessary. They annoy static checkers
>>> because they imply we are planning to write sizeof(long) bytes to a
>>> sizeof(u32) buffer which would corrupt memory.
>>
>> Hello Dan,
>>
>> Can you verify whether that patch is still needed after having
>> applied the patch series I posted in July (and that was acknowledged
>> by QLogic): http://thread.gmane.org/gmane.linux.scsi/103135 ?
>>
>
> I think it is needed still?
Hello Dan,
You are right, this patch is indeed needed. Hence:
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch] qla4xxx: remove some bogus casts
2015-08-23 1:41 ` Bart Van Assche
(?)
@ 2017-01-25 16:35 ` Bart Van Assche
2017-01-26 2:54 ` Martin K. Petersen
-1 siblings, 1 reply; 10+ messages in thread
From: Bart Van Assche @ 2017-01-25 16:35 UTC (permalink / raw)
To: martin.petersen; +Cc: linux-scsi
On Sat, 2015-08-22 at 18:41 -0700, Bart Van Assche wrote:
> On 08/18/15 01:47, Dan Carpenter wrote:
> > On Mon, Aug 17, 2015 at 09:45:45PM -0700, Bart Van Assche wrote:
> > > On 08/17/2015 07:36 AM, Dan Carpenter wrote:
> > > > These casts are wrong and unnecessary. They annoy static checkers
> > > > because they imply we are planning to write sizeof(long) bytes to a
> > > > sizeof(u32) buffer which would corrupt memory.
> > >
> > > Hello Dan,
> > >
> > > Can you verify whether that patch is still needed after having
> > > applied the patch series I posted in July (and that was acknowledged
> > > by QLogic): http://thread.gmane.org/gmane.linux.scsi/103135 ?
> > >
> >
> > I think it is needed still?
>
> Hello Dan,
>
> You are right, this patch is indeed needed. Hence:
>
> Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Hello Martin,
Do you need more reviews to queue this patch?
Thanks,
Bart.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch] qla4xxx: remove some bogus casts
2017-01-25 16:35 ` Bart Van Assche
@ 2017-01-26 2:54 ` Martin K. Petersen
0 siblings, 0 replies; 10+ messages in thread
From: Martin K. Petersen @ 2017-01-26 2:54 UTC (permalink / raw)
To: Bart Van Assche; +Cc: martin.petersen, linux-scsi
>>>>> "Bart" == Bart Van Assche <Bart.VanAssche@sandisk.com> writes:
Hi Bart,
Bart> Do you need more reviews to queue this patch?
It's more than a month old and consequently it doesn't exist :). Please
repost.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-01-26 2:54 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-17 14:36 [patch] qla4xxx: remove some bogus casts Dan Carpenter
2015-08-17 14:36 ` Dan Carpenter
2015-08-18 4:45 ` Bart Van Assche
2015-08-18 4:45 ` Bart Van Assche
2015-08-18 8:47 ` Dan Carpenter
2015-08-18 8:47 ` Dan Carpenter
2015-08-23 1:41 ` Bart Van Assche
2015-08-23 1:41 ` Bart Van Assche
2017-01-25 16:35 ` Bart Van Assche
2017-01-26 2:54 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.