[PATCH lttng-tools 2/2] Port: win32 DLLs don't support hidden symbols

[PATCH lttng-tools 2/2] Port: win32 DLLs don't support hidden symbols

[Michael Jeanson]

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
---
 src/common/macros.h | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/common/macros.h b/src/common/macros.h
index 8ae6535..90849ed 100644
--- a/src/common/macros.h
+++ b/src/common/macros.h
@@ -74,7 +74,14 @@ void *zmalloc(size_t len)
 #define LTTNG_PACKED __attribute__((__packed__))
 #endif
 
-#ifndef LTTNG_HIDDEN
+/*
+ * LTTNG_HIDDEN: set the hidden attribute for internal functions
+ * On Windows, symbols are local unless explicitly exported,
+ * see https://gcc.gnu.org/wiki/Visibility
+ */
+#if defined(_WIN32) || defined(__CYGWIN__)
+#define LTTNG_HIDDEN
+#else
 #define LTTNG_HIDDEN __attribute__((visibility("hidden")))
 #endif
 
-- 
2.7.4

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [PATCH lttng-tools 1/2] Port: add cygwin support to endian compat

[Jérémie Galarneau]

Both patches merged in master and stable-2.9.

Thanks!
Jérémie

On 26 January 2017 at 15:09, Michael Jeanson <mjeanson@efficios.com> wrote:
> Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
> ---
>  src/common/compat/endian.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/common/compat/endian.h b/src/common/compat/endian.h
> index 4edc124..6427feb 100644
> --- a/src/common/compat/endian.h
> +++ b/src/common/compat/endian.h
> @@ -18,7 +18,7 @@
>  #ifndef _COMPAT_ENDIAN_H
>  #define _COMPAT_ENDIAN_H
>
> -#ifdef __linux__
> +#if defined(__linux__) || defined(__CYGWIN__)
>  #include <endian.h>
>
>  /*
> --
> 2.7.4
>



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev