* [PATCH net-next] net: ipv6: remove skb_reserve in getroute
@ 2017-01-26 22:08 David Ahern
2017-01-26 22:29 ` Eric Dumazet
2017-01-26 23:38 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: David Ahern @ 2017-01-26 22:08 UTC (permalink / raw)
To: netdev; +Cc: David Ahern
Remove skb_reserve and skb_reset_mac_header from inet6_rtm_getroute. The
allocated skb is not passed through the routing engine (like it is for
IPv4) and has not since the beginning of git time.
Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
---
net/ipv6/route.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 47499ed429da..5046d2b24004 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -3420,12 +3420,6 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh)
goto errout;
}
- /* Reserve room for dummy headers, this skb can pass
- through good chunk of routing engine.
- */
- skb_reset_mac_header(skb);
- skb_reserve(skb, MAX_HEADER + sizeof(struct ipv6hdr));
-
skb_dst_set(skb, &rt->dst);
err = rt6_fill_node(net, skb, rt, &fl6.daddr, &fl6.saddr, iif,
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: ipv6: remove skb_reserve in getroute
2017-01-26 22:08 [PATCH net-next] net: ipv6: remove skb_reserve in getroute David Ahern
@ 2017-01-26 22:29 ` Eric Dumazet
2017-01-26 23:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2017-01-26 22:29 UTC (permalink / raw)
To: David Ahern; +Cc: netdev
On Thu, 2017-01-26 at 14:08 -0800, David Ahern wrote:
> Remove skb_reserve and skb_reset_mac_header from inet6_rtm_getroute. The
> allocated skb is not passed through the routing engine (like it is for
> IPv4) and has not since the beginning of git time.
>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
> ---
> net/ipv6/route.c | 6 ------
> 1 file changed, 6 deletions(-)
Nice ;)
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: ipv6: remove skb_reserve in getroute
2017-01-26 22:08 [PATCH net-next] net: ipv6: remove skb_reserve in getroute David Ahern
2017-01-26 22:29 ` Eric Dumazet
@ 2017-01-26 23:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-01-26 23:38 UTC (permalink / raw)
To: dsa; +Cc: netdev
From: David Ahern <dsa@cumulusnetworks.com>
Date: Thu, 26 Jan 2017 14:08:36 -0800
> Remove skb_reserve and skb_reset_mac_header from inet6_rtm_getroute. The
> allocated skb is not passed through the routing engine (like it is for
> IPv4) and has not since the beginning of git time.
>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Good catch, applied, thanks David.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-26 23:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-26 22:08 [PATCH net-next] net: ipv6: remove skb_reserve in getroute David Ahern
2017-01-26 22:29 ` Eric Dumazet
2017-01-26 23:38 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.