From: Loic Pallardy <loic.pallardy@st.com> To: bjorn.andersson@linaro.org, ohad@wizery.com, lee.jones@linaro.org Cc: loic.pallardy@st.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, patrice.chotard@st.com, hugues.fruchet@st.com, peter.griffin@linaro.org Subject: [PATCH v3 4/4] remoteproc: core: don't allocate carveout if pa or da are defined Date: Tue, 31 Jan 2017 13:35:56 +0100 [thread overview] Message-ID: <1485866156-6364-5-git-send-email-loic.pallardy@st.com> (raw) In-Reply-To: <1485866156-6364-1-git-send-email-loic.pallardy@st.com> Remoteproc doesn't check if firmware requests fixed addresses for carveout regions. Current assumption is that platform specific driver is in charge of coprocessor specific memory region allocation and remoteproc core doesn't have to handle them. If a da or a pa is specified in firmware resource table, remoteproc core doesn't have to perform any allocation. Access to carveout will be done thanks to rproc_da_to_pa function, which will provide virtual address on carveout region allocated by platform specific driver. Signed-off-by: Loic Pallardy <loic.pallardy@st.com> --- No change since V1 drivers/remoteproc/remoteproc_core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 90b05c7..dd63ceed 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -622,6 +622,11 @@ static int rproc_handle_carveout(struct rproc *rproc, dev_dbg(dev, "carveout rsc: name: %s, da 0x%x, pa 0x%x, len 0x%x, flags 0x%x\n", rsc->name, rsc->da, rsc->pa, rsc->len, rsc->flags); + if (rsc->pa != FW_RSC_ADDR_ANY || rsc->da != FW_RSC_ADDR_ANY) { + dev_dbg(dev, "carveout already allocated by low level driver\n"); + return 0; + } + carveout = kzalloc(sizeof(*carveout), GFP_KERNEL); if (!carveout) return -ENOMEM; -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Loic Pallardy <loic.pallardy@st.com> To: <bjorn.andersson@linaro.org>, <ohad@wizery.com>, <lee.jones@linaro.org> Cc: <loic.pallardy@st.com>, <linux-remoteproc@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <kernel@stlinux.com>, <patrice.chotard@st.com>, <hugues.fruchet@st.com>, <peter.griffin@linaro.org> Subject: [PATCH v3 4/4] remoteproc: core: don't allocate carveout if pa or da are defined Date: Tue, 31 Jan 2017 13:35:56 +0100 [thread overview] Message-ID: <1485866156-6364-5-git-send-email-loic.pallardy@st.com> (raw) In-Reply-To: <1485866156-6364-1-git-send-email-loic.pallardy@st.com> Remoteproc doesn't check if firmware requests fixed addresses for carveout regions. Current assumption is that platform specific driver is in charge of coprocessor specific memory region allocation and remoteproc core doesn't have to handle them. If a da or a pa is specified in firmware resource table, remoteproc core doesn't have to perform any allocation. Access to carveout will be done thanks to rproc_da_to_pa function, which will provide virtual address on carveout region allocated by platform specific driver. Signed-off-by: Loic Pallardy <loic.pallardy@st.com> --- No change since V1 drivers/remoteproc/remoteproc_core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 90b05c7..dd63ceed 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -622,6 +622,11 @@ static int rproc_handle_carveout(struct rproc *rproc, dev_dbg(dev, "carveout rsc: name: %s, da 0x%x, pa 0x%x, len 0x%x, flags 0x%x\n", rsc->name, rsc->da, rsc->pa, rsc->len, rsc->flags); + if (rsc->pa != FW_RSC_ADDR_ANY || rsc->da != FW_RSC_ADDR_ANY) { + dev_dbg(dev, "carveout already allocated by low level driver\n"); + return 0; + } + carveout = kzalloc(sizeof(*carveout), GFP_KERNEL); if (!carveout) return -ENOMEM; -- 1.9.1
next prev parent reply other threads:[~2017-01-31 12:35 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-31 12:35 [PATCH v3 0/4] remoteproc: st: add virtio_rpmsg support Loic Pallardy 2017-01-31 12:35 ` Loic Pallardy 2017-01-31 12:35 ` [PATCH v3 1/4] remoteproc: st: correct probe error management Loic Pallardy 2017-01-31 12:35 ` Loic Pallardy 2017-02-06 21:19 ` Bjorn Andersson 2017-02-07 22:20 ` Loic PALLARDY 2017-01-31 12:35 ` [PATCH v3 2/4] remoteproc: st: add virtio communication support Loic Pallardy 2017-01-31 12:35 ` Loic Pallardy 2017-01-31 12:35 ` [PATCH v3 3/4] remoteproc: st: add da to va support Loic Pallardy 2017-01-31 12:35 ` Loic Pallardy 2017-02-08 9:00 ` [v3,3/4] " Hugues FRUCHET 2017-01-31 12:35 ` Loic Pallardy [this message] 2017-01-31 12:35 ` [PATCH v3 4/4] remoteproc: core: don't allocate carveout if pa or da are defined Loic Pallardy 2017-02-08 9:00 ` [v3, " Hugues FRUCHET 2017-02-09 1:55 ` [PATCH v3 " Bjorn Andersson 2017-02-09 21:34 ` Loic PALLARDY
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1485866156-6364-5-git-send-email-loic.pallardy@st.com \ --to=loic.pallardy@st.com \ --cc=bjorn.andersson@linaro.org \ --cc=hugues.fruchet@st.com \ --cc=kernel@stlinux.com \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=ohad@wizery.com \ --cc=patrice.chotard@st.com \ --cc=peter.griffin@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.