All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ritesh Raj Sarraf <rrs@debian.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Platform Driver <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH] Add sysfs interface for touchpad state
Date: Wed, 01 Feb 2017 21:47:26 +0530	[thread overview]
Message-ID: <1485965846.14297.1.camel@debian.org> (raw)
In-Reply-To: <CAHp75VcHE8ZHpuS=WEQOD7kMLSDSiFhZSAx_55ARidi0FUhapw@mail.gmail.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Wed, 2017-02-01 at 17:07 +0200, Andy Shevchenko wrote:
> > root@learner:/sys/class/input# od -x /dev/input/event6
> > ?0000000 ee33 5891 0000 0000 2bd9 0005 0000 0000
> > ^@0000020 0004 0004 0042 0000 ee33 5891 0000 0000
> > 0000040 2bd9 0005 0000 0000 0001 00c1 0001 0000
> > 0000060 ee33 5891 0000 0000 2bd9 0005 0000 0000
> > 0000100 0000 0000 0000 0000 ee33 5891 0000 0000
> > 0000120 2c09 0005 0000 0000 0001 00c1 0000 0000
> > 0000140 ee33 5891 0000 0000 2c09 0005 0000 0000
> > 0000160 0000 0000 0000 0000 ee37 5891 0000 0000
> > 0000200 3d7e 000f 0000 0000 0004 0004 0043 0000
> > 0000220 ee37 5891 0000 0000 3d7e 000f 0000 0000
> > 0000240 0001 00c0 0001 0000 ee37 5891 0000 0000
> > 0000260 3d7e 000f 0000 0000 0000 0000 0000 0000
> > 0000300 ee37 5891 0000 0000 3dae 000f 0000 0000
> > 0000320 0001 00c0 0000 0000 ee37 5891 0000 0000
> > 0000340 3dae 000f 0000 0000 0000 0000 0000 0000
> 
> So, the whole idea of this exercise is to show that driver sends an
> event whenever you bend / unbend the cover.
> User space already will know what is the state of the cover.
> 

Yes. But we've not found the interface in sysfs where we could read that from.
Nor did udev report anything meaningful for it.

> > By the way, does the patch make sense for
> > inclusion ? To have an interface for touchpad mode ?
> 
> The question now is why do you need that on top of existing event?

If you have time, please see:
https://bugs.launchpad.net/bugs/1366421

It has pretty much all the details on what and why we need something in sysfs.

For HP and ThinkPad, there already are interfaces available.

/sys/devices/platform/hp-wmi/tablet
/sys/devices/platform/thinkpad_acpi/hotkey_tablet_mode

It'd be nice to see the same for Yoga IdeaPad; a proper interface for tablet-
mode.

- -- 
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEQCVDstmIVAB/Yn02pjpYo/LhdWkFAliSChYACgkQpjpYo/Lh
dWm/LhAAitvcaPzR2fUR6gtlxMLOQDTEPA8rjQdVmIBFLYPV9OTyJPkjz9V0aZlR
S4BcGa43foXLNsj5tGFNoy8gucwQ2bpEEpPJazlsmRVk9SB7Ui0GVzU673EUqCHD
wR3NI4MzlEmo6RV8DxTyx6rGOjGH2XGjwi6cbfZFLiehw7RjYZV5ggO5uxK+O43n
EbudMaiHOZeg+rYtU+c162TdAjPwwWTiTx5LJvZpam7QS3M31U76PdVt75bacbfH
m7TarxK15ksP9Mmj3DJnXKavOS5u92mPRkSIZmE/hmWsJ/X6tmTzgX0tHddF4N+7
yaftBwglqV6Da8Xylc9GKkC2Q/b0mXSQqTwr86fK2TyKY6HHj5QJ6CNG9gwP33tG
Kg2zIpMzKul7FHpJeQIrHL312Z/4bek1Islki2ydt8CwdheMPTnxUqcFNKpaTItM
FudQTJuaffXinmavGtwco/iFBqJbnqX3RkgWpXxyIvG4NTLrcMcMDKY6DRo+f2FB
0ojU2APhPZ+63+fvCwO1Bv06/vbzfphkOvgQv6w2laekmuCJaF2RfQDj8N+DiteH
LRmqYpF4UEr4WnJeHuumV3oRQsjHU6exdzg/5oBNyJ1vD8CzRFYvTgyNmdunmFnp
ybuVmjVIjFKxGnF1x46ZFF+o7CM0+3XeC6vFYbT3WNDQq1iQKTY=
=/CI9
-----END PGP SIGNATURE-----

  reply	other threads:[~2017-02-01 16:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-30 10:57 [PATCH] Add sysfs interface for touchpad state Ritesh Raj Sarraf
2017-01-30 20:25 ` Andy Shevchenko
2017-01-31 11:47   ` Ritesh Raj Sarraf
2017-02-01 11:25     ` Andy Shevchenko
2017-02-01 14:26       ` Ritesh Raj Sarraf
2017-02-01 15:07         ` Andy Shevchenko
2017-02-01 16:17           ` Ritesh Raj Sarraf [this message]
2017-02-01 20:53             ` Andy Shevchenko
2017-02-02  8:16               ` Ritesh Raj Sarraf
2017-02-13 22:26                 ` Andy Shevchenko
2017-02-14 14:18                   ` Ritesh Raj Sarraf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485965846.14297.1.camel@debian.org \
    --to=rrs@debian.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.