All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Ritesh Raj Sarraf <rrs@debian.org>
Cc: Platform Driver <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH] Add sysfs interface for touchpad state
Date: Wed, 1 Feb 2017 17:07:31 +0200	[thread overview]
Message-ID: <CAHp75VcHE8ZHpuS=WEQOD7kMLSDSiFhZSAx_55ARidi0FUhapw@mail.gmail.com> (raw)
In-Reply-To: <1485959219.8977.1.camel@debian.org>

On Wed, Feb 1, 2017 at 4:26 PM, Ritesh Raj Sarraf <rrs@debian.org> wrote:
> On Wed, 2017-02-01 at 13:25 +0200, Andy Shevchenko wrote:
>> We have Yoga 900 here and I just played with it.
>> So, can you do the following:
>> 1. Boot system to a text mode (no X).
>> 2. Be sure that ideapad_lenovo module is loaded
>> 3. By looking into output of
>> % ls -l /sys/class/input
>> find VPC2004 related *event* number (/.../eventX/...)
>> 4. Run
>> % od -x /dev/input/eventX
>> 5. Ensure that you get events (hex dump) when you bend the cover.
>>
>> We can continue after you try the above.
>>
>
> Fantastic. In that case, I hope you can help enable SW_TABLET_MODE for ideapad
> driver too.
>
> Here's what you asked for:

> lrwxrwxrwx 1 root root 0 Feb  1 19:33 event6 -> ../../devices/pci0000:00/0000:00:1f.0/PNP0C09:00/VPC2004:00/input/input8/event6

> root@learner:/sys/class/input# od -x /dev/input/event6
> ?0000000 ee33 5891 0000 0000 2bd9 0005 0000 0000
> ^@0000020 0004 0004 0042 0000 ee33 5891 0000 0000
> 0000040 2bd9 0005 0000 0000 0001 00c1 0001 0000
> 0000060 ee33 5891 0000 0000 2bd9 0005 0000 0000
> 0000100 0000 0000 0000 0000 ee33 5891 0000 0000
> 0000120 2c09 0005 0000 0000 0001 00c1 0000 0000
> 0000140 ee33 5891 0000 0000 2c09 0005 0000 0000
> 0000160 0000 0000 0000 0000 ee37 5891 0000 0000
> 0000200 3d7e 000f 0000 0000 0004 0004 0043 0000
> 0000220 ee37 5891 0000 0000 3d7e 000f 0000 0000
> 0000240 0001 00c0 0001 0000 ee37 5891 0000 0000
> 0000260 3d7e 000f 0000 0000 0000 0000 0000 0000
> 0000300 ee37 5891 0000 0000 3dae 000f 0000 0000
> 0000320 0001 00c0 0000 0000 ee37 5891 0000 0000
> 0000340 3dae 000f 0000 0000 0000 0000 0000 0000

So, the whole idea of this exercise is to show that driver sends an
event whenever you bend / unbend the cover.
User space already will know what is the state of the cover.

> By the way, does the patch make sense for
> inclusion ? To have an interface for touchpad mode ?

The question now is why do you need that on top of existing event?

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2017-02-01 15:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-30 10:57 [PATCH] Add sysfs interface for touchpad state Ritesh Raj Sarraf
2017-01-30 20:25 ` Andy Shevchenko
2017-01-31 11:47   ` Ritesh Raj Sarraf
2017-02-01 11:25     ` Andy Shevchenko
2017-02-01 14:26       ` Ritesh Raj Sarraf
2017-02-01 15:07         ` Andy Shevchenko [this message]
2017-02-01 16:17           ` Ritesh Raj Sarraf
2017-02-01 20:53             ` Andy Shevchenko
2017-02-02  8:16               ` Ritesh Raj Sarraf
2017-02-13 22:26                 ` Andy Shevchenko
2017-02-14 14:18                   ` Ritesh Raj Sarraf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75VcHE8ZHpuS=WEQOD7kMLSDSiFhZSAx_55ARidi0FUhapw@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rrs@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.