All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fs: ext4: block_validity.c
@ 2017-02-09 18:57 Nathan Howard
  2017-02-09 19:22 ` Theodore Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: Nathan Howard @ 2017-02-09 18:57 UTC (permalink / raw)
  To: tytso, adilger.kernel, linux-ext4, linux-kernel; +Cc: Nathan Howard

Fixed coding style issues.

Signed-off-by: Nathan Howard <adanhawthorn@gmail.com>
---
 fs/ext4/block_validity.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c
index fdb1954..fead1f9 100644
--- a/fs/ext4/block_validity.c
+++ b/fs/ext4/block_validity.c
@@ -124,16 +124,16 @@ static void debug_print_tree(struct ext4_sb_info *sbi)
 	struct ext4_system_zone *entry;
 	int first = 1;
 
-	printk(KERN_INFO "System zones: ");
+	pr_info("System zones: ");
 	node = rb_first(&sbi->system_blks);
 	while (node) {
 		entry = rb_entry(node, struct ext4_system_zone, node);
-		printk(KERN_CONT "%s%llu-%llu", first ? "" : ", ",
+		pr_cont("%s%llu-%llu", first ? "" : ", ",
 		       entry->start_blk, entry->start_blk + entry->count - 1);
 		first = 0;
 		node = rb_next(node);
 	}
-	printk(KERN_CONT "\n");
+	pr_cont("\n");
 }
 
 int ext4_setup_system_zone(struct super_block *sb)
@@ -153,7 +153,7 @@ int ext4_setup_system_zone(struct super_block *sb)
 	if (EXT4_SB(sb)->system_blks.rb_node)
 		return 0;
 
-	for (i=0; i < ngroups; i++) {
+	for (i = 0; i < ngroups; i++) {
 		if (ext4_bg_has_super(sb, i) &&
 		    ((i < 5) || ((i % flex_size) == 0)))
 			add_system_zone(sbi, ext4_group_first_block_no(sb, i),
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fs: ext4: block_validity.c
  2017-02-09 18:57 [PATCH] fs: ext4: block_validity.c Nathan Howard
@ 2017-02-09 19:22 ` Theodore Ts'o
  0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2017-02-09 19:22 UTC (permalink / raw)
  To: Nathan Howard; +Cc: adilger.kernel, linux-ext4, linux-kernel

On Thu, Feb 09, 2017 at 01:57:21PM -0500, Nathan Howard wrote:
> Fixed coding style issues.

Sorry, I only take coding style fixups as part of substantive (bug
fixes, new features, or optimizatoins) changes to the code in question.

If you're trying to do "my first kernel patch", the recommended place
to practice your skills is the Staging tree.

Cheers,

					- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-02-09 19:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-09 18:57 [PATCH] fs: ext4: block_validity.c Nathan Howard
2017-02-09 19:22 ` Theodore Ts'o

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.