* [patch net-next] sched: Fix accidental removal of errout goto
@ 2017-02-14 15:27 Jiri Pirko
2017-02-14 16:44 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Pirko @ 2017-02-14 15:27 UTC (permalink / raw)
To: netdev; +Cc: davem, jhs, mlxsw, colin.king
From: Jiri Pirko <jiri@mellanox.com>
Bring back the goto that was removed by accident.
Reported-by: Colin Ian King <colin.king@canonical.com>
Fixes: 40c81b25b16c ("sched: check negative err value to safe one level of indent")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
net/sched/cls_api.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index abe1fe1..732f7ca 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -389,6 +389,7 @@ static int tc_ctl_tfilter(struct sk_buff *skb, struct nlmsghdr *n)
RTM_DELTFILTER, false);
if (tcf_proto_destroy(tp, false))
RCU_INIT_POINTER(*back, next);
+ goto errout;
case RTM_GETTFILTER:
err = tfilter_notify(net, skb, n, tp, fh,
RTM_NEWTFILTER, true);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch net-next] sched: Fix accidental removal of errout goto
2017-02-14 15:27 [patch net-next] sched: Fix accidental removal of errout goto Jiri Pirko
@ 2017-02-14 16:44 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-02-14 16:44 UTC (permalink / raw)
To: jiri; +Cc: netdev, jhs, mlxsw, colin.king
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 14 Feb 2017 16:27:13 +0100
> From: Jiri Pirko <jiri@mellanox.com>
>
> Bring back the goto that was removed by accident.
>
> Reported-by: Colin Ian King <colin.king@canonical.com>
> Fixes: 40c81b25b16c ("sched: check negative err value to safe one level of indent")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Applied, thanks Jiri.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-14 16:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-14 15:27 [patch net-next] sched: Fix accidental removal of errout goto Jiri Pirko
2017-02-14 16:44 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.