* [PATCH linux dev-4.7 2/3] ARM: dts: aspeed: romulus: Add fsi-master GPIO bindings
@ 2017-02-14 7:30 Lei YU
2017-02-16 1:21 ` Andrew Jeffery
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Lei YU @ 2017-02-14 7:30 UTC (permalink / raw)
To: openbmc
Define the pins used on Romulus by the FSI GPIO master.
Signed-off-by: Lei YU <mine260309@gmail.com>
---
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
index f47eb63..bc13ad9 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
@@ -1,7 +1,7 @@
/dts-v1/;
#include "aspeed-g5.dtsi"
-#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/gpio/aspeed-gpio.h>
/ {
model = "Romulus BMC";
@@ -31,6 +31,17 @@
};
};
+ fsi-master {
+ compatible = "ibm,fsi-master", "ibm,fsi-master-gpio";
+
+ status = "disabled";
+
+ clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
+ data-gpios = <&gpio ASPEED_GPIO(AA, 2) GPIO_ACTIVE_HIGH>;
+ mux-gpios = <&gpio ASPEED_GPIO(A, 6) GPIO_ACTIVE_HIGH>;
+ enable-gpios = <&gpio ASPEED_GPIO(D, 0) GPIO_ACTIVE_HIGH>;
+ trans-gpios = <&gpio ASPEED_GPIO(R, 2) GPIO_ACTIVE_HIGH>;
+ };
};
&fmc {
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH linux dev-4.7 2/3] ARM: dts: aspeed: romulus: Add fsi-master GPIO bindings
2017-02-14 7:30 [PATCH linux dev-4.7 2/3] ARM: dts: aspeed: romulus: Add fsi-master GPIO bindings Lei YU
@ 2017-02-16 1:21 ` Andrew Jeffery
2017-02-16 3:28 ` Mine
2017-02-16 1:23 ` Joel Stanley
2017-02-20 23:20 ` Eddie James
2 siblings, 1 reply; 7+ messages in thread
From: Andrew Jeffery @ 2017-02-16 1:21 UTC (permalink / raw)
To: Lei YU, openbmc
[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]
Hi Lei,
On Tue, 2017-02-14 at 15:30 +0800, Lei YU wrote:
> Define the pins used on Romulus by the FSI GPIO master.
>
> > Signed-off-by: Lei YU <mine260309@gmail.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> index f47eb63..bc13ad9 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> @@ -1,7 +1,7 @@
> /dts-v1/;
>
> #include "aspeed-g5.dtsi"
> -#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/gpio/aspeed-gpio.h>
>
> / {
> > model = "Romulus BMC";
> @@ -31,6 +31,17 @@
> > };
> > };
>
> > + fsi-master {
> > + compatible = "ibm,fsi-master", "ibm,fsi-master-gpio";
> +
> > + status = "disabled";
> +
> + clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
This looks okay
> + data-gpios = <&gpio ASPEED_GPIO(AA, 2) GPIO_ACTIVE_HIGH>;
According to my Romulus datasheet, FSI_SOFT_DAT is GPIOE0 and GPIOAA2
doesn't appear to be connected. Am I looking at an out-of-date
datasheet? Did something change here?
> + mux-gpios = <&gpio ASPEED_GPIO(A, 6) GPIO_ACTIVE_HIGH>;
> > + enable-gpios = <&gpio ASPEED_GPIO(D, 0) GPIO_ACTIVE_HIGH>;
> + trans-gpios = <&gpio ASPEED_GPIO(R, 2) GPIO_ACTIVE_HIGH>;
These three also look okay to me.
Andrew
> + };
> };
>
> &fmc {
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH linux dev-4.7 2/3] ARM: dts: aspeed: romulus: Add fsi-master GPIO bindings
2017-02-14 7:30 [PATCH linux dev-4.7 2/3] ARM: dts: aspeed: romulus: Add fsi-master GPIO bindings Lei YU
2017-02-16 1:21 ` Andrew Jeffery
@ 2017-02-16 1:23 ` Joel Stanley
2017-02-20 23:20 ` Eddie James
2 siblings, 0 replies; 7+ messages in thread
From: Joel Stanley @ 2017-02-16 1:23 UTC (permalink / raw)
To: Lei YU; +Cc: OpenBMC Maillist
On Tue, Feb 14, 2017 at 6:00 PM, Lei YU <mine260309@gmail.com> wrote:
> Define the pins used on Romulus by the FSI GPIO master.
I compared these pins to pdbg and they look good.
> Signed-off-by: Lei YU <mine260309@gmail.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> index f47eb63..bc13ad9 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> @@ -1,7 +1,7 @@
> /dts-v1/;
>
> #include "aspeed-g5.dtsi"
> -#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/gpio/aspeed-gpio.h>
>
> / {
> model = "Romulus BMC";
> @@ -31,6 +31,17 @@
> };
> };
>
> + fsi-master {
> + compatible = "ibm,fsi-master", "ibm,fsi-master-gpio";
> +
> + status = "disabled";
> +
> + clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
> + data-gpios = <&gpio ASPEED_GPIO(AA, 2) GPIO_ACTIVE_HIGH>;
> + mux-gpios = <&gpio ASPEED_GPIO(A, 6) GPIO_ACTIVE_HIGH>;
> + enable-gpios = <&gpio ASPEED_GPIO(D, 0) GPIO_ACTIVE_HIGH>;
> + trans-gpios = <&gpio ASPEED_GPIO(R, 2) GPIO_ACTIVE_HIGH>;
> + };
> };
>
> &fmc {
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH linux dev-4.7 2/3] ARM: dts: aspeed: romulus: Add fsi-master GPIO bindings
2017-02-16 1:21 ` Andrew Jeffery
@ 2017-02-16 3:28 ` Mine
2017-02-16 3:32 ` Andrew Jeffery
0 siblings, 1 reply; 7+ messages in thread
From: Mine @ 2017-02-16 3:28 UTC (permalink / raw)
To: Andrew Jeffery; +Cc: OpenBMC Maillist
Hi Andrew,
On Thu, Feb 16, 2017 at 9:21 AM, Andrew Jeffery <andrew@aj.id.au> wrote:
> Hi Lei,
>
> On Tue, 2017-02-14 at 15:30 +0800, Lei YU wrote:
>> Define the pins used on Romulus by the FSI GPIO master.
>>
>> > Signed-off-by: Lei YU <mine260309@gmail.com>
>> ---
>> arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 13 ++++++++++++-
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> index f47eb63..bc13ad9 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> @@ -1,7 +1,7 @@
>> /dts-v1/;
>>
>> #include "aspeed-g5.dtsi"
>> -#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/gpio/aspeed-gpio.h>
>>
>> / {
>> > model = "Romulus BMC";
>> @@ -31,6 +31,17 @@
>> > };
>> > };
>>
>> > + fsi-master {
>> > + compatible = "ibm,fsi-master", "ibm,fsi-master-gpio";
>> +
>> > + status = "disabled";
>> +
>> + clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
>
> This looks okay
>
>> + data-gpios = <&gpio ASPEED_GPIO(AA, 2) GPIO_ACTIVE_HIGH>;
>
> According to my Romulus datasheet, FSI_SOFT_DAT is GPIOE0 and GPIOAA2
> doesn't appear to be connected. Am I looking at an out-of-date
> datasheet? Did something change here?
Romulus FSI_SOFT_DAT is always GPIOAA2 (from GPIO Romulus 20161102.xls
to GPIO Romulus 20170112.xls, and I confirm that FSI is working with
this config.
Maybe you were referring Witherspoon's GPIO, where FSI_SOFT_DAT is GPIOE0?
>
>> + mux-gpios = <&gpio ASPEED_GPIO(A, 6) GPIO_ACTIVE_HIGH>;
>> > + enable-gpios = <&gpio ASPEED_GPIO(D, 0) GPIO_ACTIVE_HIGH>;
>> + trans-gpios = <&gpio ASPEED_GPIO(R, 2) GPIO_ACTIVE_HIGH>;
>
> These three also look okay to me.
>
> Andrew
>
>> + };
>> };
>>
>> &fmc {
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH linux dev-4.7 2/3] ARM: dts: aspeed: romulus: Add fsi-master GPIO bindings
2017-02-16 3:28 ` Mine
@ 2017-02-16 3:32 ` Andrew Jeffery
0 siblings, 0 replies; 7+ messages in thread
From: Andrew Jeffery @ 2017-02-16 3:32 UTC (permalink / raw)
To: Mine; +Cc: OpenBMC Maillist
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
On Thu, 2017-02-16 at 11:28 +0800, Mine wrote:
> > According to my Romulus datasheet, FSI_SOFT_DAT is GPIOE0 and GPIOAA2
> > doesn't appear to be connected. Am I looking at an out-of-date
> > datasheet? Did something change here?
>
s/datasheet/schematic/, pre caffeine.
> Romulus FSI_SOFT_DAT is always GPIOAA2 (from GPIO Romulus 20161102.xls
> to GPIO Romulus 20170112.xls,
The schematic I have has 20160811 in the title, so it's probably a long
way out of date.
> and I confirm that FSI is working with
> this config.
I'll trust you :)
Acked-by: Andrew Jeffery <andrew@aj.id.au>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH linux dev-4.7 2/3] ARM: dts: aspeed: romulus: Add fsi-master GPIO bindings
2017-02-14 7:30 [PATCH linux dev-4.7 2/3] ARM: dts: aspeed: romulus: Add fsi-master GPIO bindings Lei YU
2017-02-16 1:21 ` Andrew Jeffery
2017-02-16 1:23 ` Joel Stanley
@ 2017-02-20 23:20 ` Eddie James
2017-02-20 23:25 ` Joel Stanley
2 siblings, 1 reply; 7+ messages in thread
From: Eddie James @ 2017-02-20 23:20 UTC (permalink / raw)
To: Lei YU, openbmc
Looks good.
Acked-by: Eddie James <eajames@linux.vnet.ibm.com>
On 02/14/2017 01:30 AM, Lei YU wrote:
> Define the pins used on Romulus by the FSI GPIO master.
>
> Signed-off-by: Lei YU <mine260309@gmail.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> index f47eb63..bc13ad9 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> @@ -1,7 +1,7 @@
> /dts-v1/;
>
> #include "aspeed-g5.dtsi"
> -#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/gpio/aspeed-gpio.h>
>
> / {
> model = "Romulus BMC";
> @@ -31,6 +31,17 @@
> };
> };
>
> + fsi-master {
> + compatible = "ibm,fsi-master", "ibm,fsi-master-gpio";
> +
> + status = "disabled";
> +
> + clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
> + data-gpios = <&gpio ASPEED_GPIO(AA, 2) GPIO_ACTIVE_HIGH>;
> + mux-gpios = <&gpio ASPEED_GPIO(A, 6) GPIO_ACTIVE_HIGH>;
> + enable-gpios = <&gpio ASPEED_GPIO(D, 0) GPIO_ACTIVE_HIGH>;
> + trans-gpios = <&gpio ASPEED_GPIO(R, 2) GPIO_ACTIVE_HIGH>;
> + };
> };
>
> &fmc {
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH linux dev-4.7 2/3] ARM: dts: aspeed: romulus: Add fsi-master GPIO bindings
2017-02-20 23:20 ` Eddie James
@ 2017-02-20 23:25 ` Joel Stanley
0 siblings, 0 replies; 7+ messages in thread
From: Joel Stanley @ 2017-02-20 23:25 UTC (permalink / raw)
To: Eddie James; +Cc: Lei YU, OpenBMC Maillist, Andrew Jeffery
On Tue, Feb 21, 2017 at 9:50 AM, Eddie James <eajames@linux.vnet.ibm.com> wrote:
> Looks good.
>
> Acked-by: Eddie James <eajames@linux.vnet.ibm.com>
>
>
>
> On 02/14/2017 01:30 AM, Lei YU wrote:
>>
>> Define the pins used on Romulus by the FSI GPIO master.
>>
>> Signed-off-by: Lei YU <mine260309@gmail.com>
>> ---
>> arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 13 ++++++++++++-
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> index f47eb63..bc13ad9 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> @@ -1,7 +1,7 @@
>> /dts-v1/;
>>
>> #include "aspeed-g5.dtsi"
>> -#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/gpio/aspeed-gpio.h>
>>
>> / {
>> model = "Romulus BMC";
>> @@ -31,6 +31,17 @@
>> };
>> };
>>
>> + fsi-master {
>> + compatible = "ibm,fsi-master", "ibm,fsi-master-gpio";
>> +
>> + status = "disabled";
>> +
>> + clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
>> + data-gpios = <&gpio ASPEED_GPIO(AA, 2) GPIO_ACTIVE_HIGH>;
>> + mux-gpios = <&gpio ASPEED_GPIO(A, 6) GPIO_ACTIVE_HIGH>;
>> + enable-gpios = <&gpio ASPEED_GPIO(D, 0) GPIO_ACTIVE_HIGH>;
>> + trans-gpios = <&gpio ASPEED_GPIO(R, 2) GPIO_ACTIVE_HIGH>;
>> + };
>> };
I just noticed that this is inside the i2c11 node. We want it to be up
the top, so I moved it there.
Applied to dev-4.7.
Thanks to everyone for the review.
Cheers,
Joel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-02-20 23:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-14 7:30 [PATCH linux dev-4.7 2/3] ARM: dts: aspeed: romulus: Add fsi-master GPIO bindings Lei YU
2017-02-16 1:21 ` Andrew Jeffery
2017-02-16 3:28 ` Mine
2017-02-16 3:32 ` Andrew Jeffery
2017-02-16 1:23 ` Joel Stanley
2017-02-20 23:20 ` Eddie James
2017-02-20 23:25 ` Joel Stanley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.