* [PATCHv2 0/1] insane.bbclass: Add missing dependencies
@ 2017-02-10 20:19 mariano.lopez
2017-02-10 20:19 ` [PATCHv2 1/1] " mariano.lopez
0 siblings, 1 reply; 4+ messages in thread
From: mariano.lopez @ 2017-02-10 20:19 UTC (permalink / raw)
To: openembedded-core
From: Mariano Lopez <mariano.lopez@linux.intel.com>
Changes in v2:
- Add binutils as dependency too
The following changes since commit a624cf7f95c8cf4ff764cc997fd1db4601b97dcc:
oeqa/selftest/pkgdata: use m4 instead of bash (2017-02-07 14:50:10 +0000)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib mariano/insane_fix
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=mariano/insane_fix
Mariano Lopez (1):
insane.bbclass: Add missing dependencies
meta/classes/insane.bbclass | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
2.10.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCHv2 1/1] insane.bbclass: Add missing dependencies
2017-02-10 20:19 [PATCHv2 0/1] insane.bbclass: Add missing dependencies mariano.lopez
@ 2017-02-10 20:19 ` mariano.lopez
2017-02-16 4:02 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: mariano.lopez @ 2017-02-10 20:19 UTC (permalink / raw)
To: openembedded-core
From: Mariano Lopez <mariano.lopez@linux.intel.com>
package_qa task requires some tools installed in sysroot; with
the introduction of recipe specific sysroot this task won't
have such tools installed if it's forced to run.
Signed-off-by: Mariano Lopez <mariano.lopez@linux.intel.com>
---
meta/classes/insane.bbclass | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 3cf86c1..0167b14 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -1223,9 +1223,12 @@ python do_package_qa () {
bb.note("DONE with PACKAGE QA")
}
+# binutils is used for most checks, so need to set as dependency
+# POPULATESYSROOTDEPS is defined in staging class.
+do_package_qa[depends] += "${POPULATESYSROOTDEPS}"
do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
do_package_qa[rdeptask] = "do_packagedata"
-addtask do_package_qa after do_packagedata do_package before do_build
+addtask do_package_qa after do_prepare_recipe_sysroot do_packagedata do_package before do_build
SSTATETASKS += "do_package_qa"
do_package_qa[sstate-inputdirs] = ""
--
2.10.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCHv2 1/1] insane.bbclass: Add missing dependencies
2017-02-10 20:19 ` [PATCHv2 1/1] " mariano.lopez
@ 2017-02-16 4:02 ` Richard Purdie
2017-02-21 18:21 ` Mariano Lopez
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2017-02-16 4:02 UTC (permalink / raw)
To: mariano.lopez, openembedded-core
On Fri, 2017-02-10 at 14:19 -0600, mariano.lopez@linux.intel.com wrote:
> From: Mariano Lopez <mariano.lopez@linux.intel.com>
>
> package_qa task requires some tools installed in sysroot; with
> the introduction of recipe specific sysroot this task won't
> have such tools installed if it's forced to run.
>
> Signed-off-by: Mariano Lopez <mariano.lopez@linux.intel.com>
> ---
> meta/classes/insane.bbclass | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/insane.bbclass
> b/meta/classes/insane.bbclass
> index 3cf86c1..0167b14 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -1223,9 +1223,12 @@ python do_package_qa () {
> bb.note("DONE with PACKAGE QA")
> }
>
> +# binutils is used for most checks, so need to set as dependency
> +# POPULATESYSROOTDEPS is defined in staging class.
> +do_package_qa[depends] += "${POPULATESYSROOTDEPS}"
> do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
> do_package_qa[rdeptask] = "do_packagedata"
> -addtask do_package_qa after do_packagedata do_package before
> do_build
> +addtask do_package_qa after do_prepare_recipe_sysroot do_packagedata
> do_package before do_build
This is close but I don't think you need this last addtask change, I
think it should work just fine with the added [depends]?
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv2 1/1] insane.bbclass: Add missing dependencies
2017-02-16 4:02 ` Richard Purdie
@ 2017-02-21 18:21 ` Mariano Lopez
0 siblings, 0 replies; 4+ messages in thread
From: Mariano Lopez @ 2017-02-21 18:21 UTC (permalink / raw)
To: Richard Purdie, openembedded-core
On 15/02/17 22:02, Richard Purdie wrote:
> On Fri, 2017-02-10 at 14:19 -0600, mariano.lopez@linux.intel.com wrote:
>> From: Mariano Lopez <mariano.lopez@linux.intel.com>
>>
>> package_qa task requires some tools installed in sysroot; with
>> the introduction of recipe specific sysroot this task won't
>> have such tools installed if it's forced to run.
>>
>> Signed-off-by: Mariano Lopez <mariano.lopez@linux.intel.com>
>> ---
>> meta/classes/insane.bbclass | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/insane.bbclass
>> b/meta/classes/insane.bbclass
>> index 3cf86c1..0167b14 100644
>> --- a/meta/classes/insane.bbclass
>> +++ b/meta/classes/insane.bbclass
>> @@ -1223,9 +1223,12 @@ python do_package_qa () {
>> bb.note("DONE with PACKAGE QA")
>> }
>>
>> +# binutils is used for most checks, so need to set as dependency
>> +# POPULATESYSROOTDEPS is defined in staging class.
>> +do_package_qa[depends] += "${POPULATESYSROOTDEPS}"
>> do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
>> do_package_qa[rdeptask] = "do_packagedata"
>> -addtask do_package_qa after do_packagedata do_package before
>> do_build
>> +addtask do_package_qa after do_prepare_recipe_sysroot do_packagedata
>> do_package before do_build
> This is close but I don't think you need this last addtask change, I
> think it should work just fine with the added [depends]?
Indeed, it works just with [depends]. Just sent v3 of this patch.
Mariano
>
> Cheers,
>
> Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-21 18:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-10 20:19 [PATCHv2 0/1] insane.bbclass: Add missing dependencies mariano.lopez
2017-02-10 20:19 ` [PATCHv2 1/1] " mariano.lopez
2017-02-16 4:02 ` Richard Purdie
2017-02-21 18:21 ` Mariano Lopez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.