All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Michael Davidsaver" <mdavidsaver@gmail.com>
Subject: [Qemu-devel] [PATCH 1/4] arm: HVC and SMC encodings don't exist for M profile
Date: Mon, 20 Feb 2017 18:41:09 +0000	[thread overview]
Message-ID: <1487616072-9226-2-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1487616072-9226-1-git-send-email-peter.maydell@linaro.org>

M profile doesn't have the HVC or SMC encodings, so make them always
UNDEF rather than generating calls to helper functions that assume
A/R profile.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/translate.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/target/arm/translate.c b/target/arm/translate.c
index 9fded03..895b399 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -10365,6 +10365,9 @@ static int disas_thumb2_insn(CPUARMState *env, DisasContext *s, uint16_t insn_hw
                     goto illegal_op;
 
                 if (insn & (1 << 26)) {
+                    if (arm_dc_feature(s, ARM_FEATURE_M)) {
+                        goto illegal_op;
+                    }
                     if (!(insn & (1 << 20))) {
                         /* Hypervisor call (v7) */
                         int imm16 = extract32(insn, 16, 4) << 12
-- 
2.7.4

  reply	other threads:[~2017-02-20 19:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-20 18:41 [Qemu-devel] [PATCH 0/4] arm: Fix M profile MSR/MRS Peter Maydell
2017-02-20 18:41 ` Peter Maydell [this message]
2017-03-20 10:48   ` [Qemu-devel] [PATCH 1/4] arm: HVC and SMC encodings don't exist for M profile Alex Bennée
2017-02-20 18:41 ` [Qemu-devel] [PATCH 2/4] arm: Don't decode MRS(banked) or MSR(banked) " Peter Maydell
2017-03-20 10:57   ` Alex Bennée
2017-03-20 11:05     ` Peter Maydell
2017-02-20 18:41 ` [Qemu-devel] [PATCH 3/4] arm: Enforce should-be-1 bits in MRS decoding Peter Maydell
2017-03-20 10:59   ` Alex Bennée
2017-02-20 18:41 ` [Qemu-devel] [PATCH 4/4] arm: Fix APSR writes via M profile MSR Peter Maydell
2017-03-20 11:01   ` Alex Bennée
2017-03-14 11:52 ` [Qemu-devel] [Qemu-arm] [PATCH 0/4] arm: Fix M profile MSR/MRS Peter Maydell
2017-03-18 17:36   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487616072-9226-2-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=mdavidsaver@gmail.com \
    --cc=patches@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.