From: no-reply@patchew.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com, tianqing@unitedstack.com, ceph-devel@vger.kernel.org, jazeltq@gmail.com, dillaman@redhat.com Subject: Re: [Qemu-devel] [RFC v6] RBD: Add support readv, writev for rbd Date: Mon, 20 Feb 2017 19:50:18 -0800 (PST) [thread overview] Message-ID: <148764901699.33.10189630070314402937@0e2666bad730> (raw) In-Reply-To: <20170221034336.10097-1-jazeltq@gmail.com> Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [RFC v6] RBD: Add support readv,writev for rbd Message-id: 20170221034336.10097-1-jazeltq@gmail.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20170221034336.10097-1-jazeltq@gmail.com -> patchew/20170221034336.10097-1-jazeltq@gmail.com Switched to a new branch 'test' dc83903 RBD: Add support readv,writev for rbd === OUTPUT BEGIN === Checking PATCH 1/1: RBD: Add support readv,writev for rbd... ERROR: space required before the open brace '{' #36: FILE: block/rbd.c:322: + if(LIBRBD_USE_IOVEC){ ERROR: space required before the open parenthesis '(' #36: FILE: block/rbd.c:322: + if(LIBRBD_USE_IOVEC){ ERROR: trailing whitespace #69: FILE: block/rbd.c:461: + $ ERROR: suspect code indent for conditional statements (4, 9) #70: FILE: block/rbd.c:462: + if(!LIBRBD_USE_IOVEC){ + if (acb->cmd == RBD_AIO_READ) { ERROR: space required before the open brace '{' #70: FILE: block/rbd.c:462: + if(!LIBRBD_USE_IOVEC){ ERROR: space required before the open parenthesis '(' #70: FILE: block/rbd.c:462: + if(!LIBRBD_USE_IOVEC){ ERROR: suspect code indent for conditional statements (9, 13) #71: FILE: block/rbd.c:463: + if (acb->cmd == RBD_AIO_READ) { + qemu_iovec_from_buf(acb->qiov, 0, acb->bounce, acb->qiov->size); ERROR: space required before the open brace '{' #102: FILE: block/rbd.c:690: + if(!LIBRBD_USE_IOVEC){ ERROR: space required before the open parenthesis '(' #102: FILE: block/rbd.c:690: + if(!LIBRBD_USE_IOVEC){ ERROR: space required before the open parenthesis '(' #138: FILE: block/rbd.c:719: + if(!LIBRBD_USE_IOVEC) ERROR: braces {} are necessary for all arms of this statement #138: FILE: block/rbd.c:719: + if(!LIBRBD_USE_IOVEC) [...] + else [...] ERROR: space required before the open parenthesis '(' #145: FILE: block/rbd.c:725: + if(!LIBRBD_USE_IOVEC) ERROR: braces {} are necessary for all arms of this statement #145: FILE: block/rbd.c:725: + if(!LIBRBD_USE_IOVEC) [...] + else [...] ERROR: space required before the open parenthesis '(' #164: FILE: block/rbd.c:749: + if(!LIBRBD_USE_IOVEC) ERROR: braces {} are necessary for all arms of this statement #164: FILE: block/rbd.c:749: + if(!LIBRBD_USE_IOVEC) [...] total: 15 errors, 0 warnings, 146 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
WARNING: multiple messages have this Message-ID (diff)
From: no-reply@patchew.org To: jazeltq@gmail.com Cc: famz@redhat.com, jdurgin@redhat.com, jcody@redhat.com, dillaman@redhat.com, kwolf@redhat.com, mreitz@redhat.com, qemu-block@nongnu.org, tianqing@unitedstack.com, ceph-devel@vger.kernel.org, qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [RFC v6] RBD: Add support readv,writev for rbd Date: Mon, 20 Feb 2017 19:50:18 -0800 (PST) [thread overview] Message-ID: <148764901699.33.10189630070314402937@0e2666bad730> (raw) In-Reply-To: <20170221034336.10097-1-jazeltq@gmail.com> Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [RFC v6] RBD: Add support readv,writev for rbd Message-id: 20170221034336.10097-1-jazeltq@gmail.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20170221034336.10097-1-jazeltq@gmail.com -> patchew/20170221034336.10097-1-jazeltq@gmail.com Switched to a new branch 'test' dc83903 RBD: Add support readv,writev for rbd === OUTPUT BEGIN === Checking PATCH 1/1: RBD: Add support readv,writev for rbd... ERROR: space required before the open brace '{' #36: FILE: block/rbd.c:322: + if(LIBRBD_USE_IOVEC){ ERROR: space required before the open parenthesis '(' #36: FILE: block/rbd.c:322: + if(LIBRBD_USE_IOVEC){ ERROR: trailing whitespace #69: FILE: block/rbd.c:461: + $ ERROR: suspect code indent for conditional statements (4, 9) #70: FILE: block/rbd.c:462: + if(!LIBRBD_USE_IOVEC){ + if (acb->cmd == RBD_AIO_READ) { ERROR: space required before the open brace '{' #70: FILE: block/rbd.c:462: + if(!LIBRBD_USE_IOVEC){ ERROR: space required before the open parenthesis '(' #70: FILE: block/rbd.c:462: + if(!LIBRBD_USE_IOVEC){ ERROR: suspect code indent for conditional statements (9, 13) #71: FILE: block/rbd.c:463: + if (acb->cmd == RBD_AIO_READ) { + qemu_iovec_from_buf(acb->qiov, 0, acb->bounce, acb->qiov->size); ERROR: space required before the open brace '{' #102: FILE: block/rbd.c:690: + if(!LIBRBD_USE_IOVEC){ ERROR: space required before the open parenthesis '(' #102: FILE: block/rbd.c:690: + if(!LIBRBD_USE_IOVEC){ ERROR: space required before the open parenthesis '(' #138: FILE: block/rbd.c:719: + if(!LIBRBD_USE_IOVEC) ERROR: braces {} are necessary for all arms of this statement #138: FILE: block/rbd.c:719: + if(!LIBRBD_USE_IOVEC) [...] + else [...] ERROR: space required before the open parenthesis '(' #145: FILE: block/rbd.c:725: + if(!LIBRBD_USE_IOVEC) ERROR: braces {} are necessary for all arms of this statement #145: FILE: block/rbd.c:725: + if(!LIBRBD_USE_IOVEC) [...] + else [...] ERROR: space required before the open parenthesis '(' #164: FILE: block/rbd.c:749: + if(!LIBRBD_USE_IOVEC) ERROR: braces {} are necessary for all arms of this statement #164: FILE: block/rbd.c:749: + if(!LIBRBD_USE_IOVEC) [...] total: 15 errors, 0 warnings, 146 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
next prev parent reply other threads:[~2017-02-21 3:50 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-21 3:43 [RFC v6] RBD: Add support readv,writev for rbd jazeltq 2017-02-21 3:43 ` [Qemu-devel] " jazeltq 2017-02-21 3:50 ` no-reply [this message] 2017-02-21 3:50 ` no-reply 2017-02-21 4:01 ` no-reply 2017-02-21 4:01 ` no-reply 2017-02-21 4:50 ` Jeff Cody 2017-02-21 4:50 ` [Qemu-devel] " Jeff Cody 2017-02-21 6:50 jazeltq 2017-02-24 3:52 ` Jeff Cody 2017-02-24 6:09 ` Jaze Lee 2017-02-24 11:42 ` Jeff Cody 2017-02-24 12:51 ` Jaze Lee
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=148764901699.33.10189630070314402937@0e2666bad730 \ --to=no-reply@patchew.org \ --cc=ceph-devel@vger.kernel.org \ --cc=dillaman@redhat.com \ --cc=famz@redhat.com \ --cc=jazeltq@gmail.com \ --cc=kwolf@redhat.com \ --cc=mreitz@redhat.com \ --cc=qemu-block@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=tianqing@unitedstack.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.