* [Qemu-devel] [PATCH] spice: set merge-lists
@ 2017-02-21 7:57 Gerd Hoffmann
2017-02-21 8:15 ` Marc-André Lureau
0 siblings, 1 reply; 3+ messages in thread
From: Gerd Hoffmann @ 2017-02-21 7:57 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
This way you can use -spice multiple times on the command line
and qemu will actually pick up all options.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/spice-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 39ccab7..d613f1a 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -412,6 +412,7 @@ static SpiceChannelList *qmp_query_spice_channels(void)
static QemuOptsList qemu_spice_opts = {
.name = "spice",
+ .merge_lists = true,
.head = QTAILQ_HEAD_INITIALIZER(qemu_spice_opts.head),
.desc = {
{
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] spice: set merge-lists
2017-02-21 7:57 [Qemu-devel] [PATCH] spice: set merge-lists Gerd Hoffmann
@ 2017-02-21 8:15 ` Marc-André Lureau
2017-02-21 8:25 ` Gerd Hoffmann
0 siblings, 1 reply; 3+ messages in thread
From: Marc-André Lureau @ 2017-02-21 8:15 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel
Hi
On Tue, Feb 21, 2017 at 12:00 PM Gerd Hoffmann <kraxel@redhat.com> wrote:
> This way you can use -spice multiple times on the command line
> and qemu will actually pick up all options.
>
>
Is this actually a good thing to have? vnc doesn't have it for example.
Perhaps some day we may want to have -spice for difference server
instances? (although there are some parameters that would be global, like
gl/rendernode)
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> ui/spice-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 39ccab7..d613f1a 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -412,6 +412,7 @@ static SpiceChannelList *qmp_query_spice_channels(void)
>
> static QemuOptsList qemu_spice_opts = {
> .name = "spice",
> + .merge_lists = true,
> .head = QTAILQ_HEAD_INITIALIZER(qemu_spice_opts.head),
> .desc = {
> {
> --
> 1.8.3.1
>
>
> --
Marc-André Lureau
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] spice: set merge-lists
2017-02-21 8:15 ` Marc-André Lureau
@ 2017-02-21 8:25 ` Gerd Hoffmann
0 siblings, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2017-02-21 8:25 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel
On Di, 2017-02-21 at 08:15 +0000, Marc-André Lureau wrote:
> Hi
>
> On Tue, Feb 21, 2017 at 12:00 PM Gerd Hoffmann <kraxel@redhat.com>
> wrote:
>
> This way you can use -spice multiple times on the command line
> and qemu will actually pick up all options.
>
>
>
> Is this actually a good thing to have? vnc doesn't have it for
> example. Perhaps some day we may want to have -spice for difference
> server instances?
Is that likely? The use case for multiple vnc server instances is
multiple displays, which is not a problem for spice because it has
better multihead support. Also spice-server library doesn't support
multiple instances today, are there plans to actually change that?
But, yes, if we want multiple instances some day this is probably a bad
idea ...
cheers,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-21 8:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-21 7:57 [Qemu-devel] [PATCH] spice: set merge-lists Gerd Hoffmann
2017-02-21 8:15 ` Marc-André Lureau
2017-02-21 8:25 ` Gerd Hoffmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.