[PATCH v2] gitignore: add two generated files in purgatory

[PATCH v2] gitignore: add two generated files in purgatory

[Eric DeVolder]

This patch adds the two generated files below to .gitignore,
so that 'git status' does not complain about them.

purgatory/purgatory.map
purgatory/purgatory.ro.sym

Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
---
v2: Incorporated feedback
    - A bit more specific why these files added to .gitignore
v1: Posted to kexec-tools mailing list
---
 .gitignore | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.gitignore b/.gitignore
index 81e03ab..1ab52d9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -17,3 +17,5 @@
 /configure
 /include/config.h.in
 /include/config.h
+/purgatory/purgatory.map
+/purgatory/purgatory.ro.sym
-- 
2.7.4


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v2] gitignore: add two generated files in purgatory

[Daniel Kiper]

On Tue, Feb 21, 2017 at 10:18:24AM -0600, Eric DeVolder wrote:
> This patch adds the two generated files below to .gitignore,
> so that 'git status' does not complain about them.

This is not a problem. Do you have issues during 'git checkout'
or so? If yes then I think it is worth considering.

Daniel

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v2] gitignore: add two generated files in purgatory

[Eric DeVolder]

On 02/21/2017 01:48 PM, Daniel Kiper wrote:
> On Tue, Feb 21, 2017 at 10:18:24AM -0600, Eric DeVolder wrote:
>> This patch adds the two generated files below to .gitignore,
>> so that 'git status' does not complain about them.
>
> This is not a problem. Do you have issues during 'git checkout'
> or so? If yes then I think it is worth considering.
>
> Daniel

The contents of .gitignore are as follows. There are other generated 
files in the file list. It's not that there is a problem, but rather I 
added these two files for the likely same reason the other generated 
files are in the list, to cease the complaints from git about those files.

eric

=== contents of .gitignore ===

#
# Normal rules
#
*~
*.a
*.d
*.o
*.ro

# generated files
/Makefile
/autom4te.cache/
/bin/
/build/
/config.log
/config.status
/configure
/include/config.h.in
/include/config.h


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v2] gitignore: add two generated files in purgatory

[Pratyush Anand]

On Tuesday 21 February 2017 09:48 PM, Eric DeVolder wrote:
> This patch adds the two generated files below to .gitignore,
> so that 'git status' does not complain about them.
>
> purgatory/purgatory.map
> purgatory/purgatory.ro.sym
>
> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>

I think, it will be good to have these two files in .gitignore.

Reviewed-by: Pratyush Anand <panand@redhat.com>

Infact, there should be few more which is generated by developer like 
tags etc..

/tags
cscope.*
*.patch

> ---
> v2: Incorporated feedback
>     - A bit more specific why these files added to .gitignore
> v1: Posted to kexec-tools mailing list
> ---
>  .gitignore | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 81e03ab..1ab52d9 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -17,3 +17,5 @@
>  /configure
>  /include/config.h.in
>  /include/config.h
> +/purgatory/purgatory.map
> +/purgatory/purgatory.ro.sym
>


~Pratyush

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec