[Buildroot] [PATCH 1/1] libimxvpuapi: bump to version 0.10.3

[Buildroot] [PATCH 1/1] libimxvpuapi: bump to version 0.10.3

[Danomi Manchego]

Because with libimxvpuapi older than 0.10.3, the gst1-imx-0.12.3 "imxvpu"
plugin will not build:

Checking for 'libimxvpuapi >= 0.10.3'                            : not found
could not find installed imxvpuapi library - VPU elements will not be built

After this mod:

Checking for 'libimxvpuapi >= 0.10.3'                            : yes
found installed imxvpuapi library - VPU elements will be built

Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
---
 package/libimxvpuapi/libimxvpuapi.hash | 2 +-
 package/libimxvpuapi/libimxvpuapi.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/libimxvpuapi/libimxvpuapi.hash b/package/libimxvpuapi/libimxvpuapi.hash
index c8cabcf..cd0c8f1 100644
--- a/package/libimxvpuapi/libimxvpuapi.hash
+++ b/package/libimxvpuapi/libimxvpuapi.hash
@@ -1,2 +1,2 @@
 # locally computed hash
-sha256 8e6dc4105db6164c0de72fd60eb73f4ba1632f7ba5052b1abc834b462b566da2  libimxvpuapi-0.10.2.tar.gz
+sha256 7151e10a24929935bada1d3d87626f17e411575b3a4ac0d86440999ad0100a55  libimxvpuapi-0.10.3.tar.gz
diff --git a/package/libimxvpuapi/libimxvpuapi.mk b/package/libimxvpuapi/libimxvpuapi.mk
index fde4429..d368d3d 100644
--- a/package/libimxvpuapi/libimxvpuapi.mk
+++ b/package/libimxvpuapi/libimxvpuapi.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBIMXVPUAPI_VERSION = 0.10.2
+LIBIMXVPUAPI_VERSION = 0.10.3
 LIBIMXVPUAPI_SITE = $(call github,Freescale,libimxvpuapi,$(LIBIMXVPUAPI_VERSION))
 LIBIMXVPUAPI_LICENSE = LGPLv2.1+
 LIBIMXVPUAPI_LICENSE_FILES = LICENSE
-- 
2.7.4

[Buildroot] [PATCH 1/1] libimxvpuapi: bump to version 0.10.3

[Gary Bisson]

Hi Danomi,

On Wed, Feb 22, 2017 at 3:56 AM, Danomi Manchego
<danomimanchego123@gmail.com> wrote:
>
> Because with libimxvpuapi older than 0.10.3, the gst1-imx-0.12.3 "imxvpu"
> plugin will not build:

Good catch, I wasn't aware gst1-imx got bumped in the first place (not
in the loop).

> Checking for 'libimxvpuapi >= 0.10.3'                            : not found
> could not find installed imxvpuapi library - VPU elements will not be built
>
> After this mod:
>
> Checking for 'libimxvpuapi >= 0.10.3'                            : yes
> found installed imxvpuapi library - VPU elements will be built

I'd remove that part of the commit log, I think the first sentence is
explicit enough.

However, I would add the version changelog so people know what this
bump brings to the table.

You can have the changelog list from the release commit:
https://github.com/Freescale/libimxvpuapi/commit/81a2bbd8

Otherwise:
Reviewed-by: Gary Bisson <gary.bisson@boundarydevices.com>

Regards,
Gary

[Buildroot] [PATCH 1/1] libimxvpuapi: bump to version 0.10.3

[Danomi Manchego]

Hi Gary,

On Wed, Feb 22, 2017 at 12:37 AM, Gary Bisson
<gary.bisson@boundarydevices.com> wrote:
> Hi Danomi,
>
> On Wed, Feb 22, 2017 at 3:56 AM, Danomi Manchego
> <danomimanchego123@gmail.com> wrote:
>>
>> Because with libimxvpuapi older than 0.10.3, the gst1-imx-0.12.3 "imxvpu"
>> plugin will not build:
>
> Good catch, I wasn't aware gst1-imx got bumped in the first place (not
> in the loop).
>
>> Checking for 'libimxvpuapi >= 0.10.3'                            : not found
>> could not find installed imxvpuapi library - VPU elements will not be built
>>
>> After this mod:
>>
>> Checking for 'libimxvpuapi >= 0.10.3'                            : yes
>> found installed imxvpuapi library - VPU elements will be built
>
> I'd remove that part of the commit log, I think the first sentence is
> explicit enough.

Okay.

> However, I would add the version changelog so people know what this
> bump brings to the table.
>
> You can have the changelog list from the release commit:
> https://github.com/Freescale/libimxvpuapi/commit/81a2bbd8

I'm not really in agreement with this - it does not seem like normal
buildroot practice to add much detail on the package bumps that are
not security related.  But that said, it does not hurt to do so, and
unbreaking the gst1-imx VPU plugin is more important than the commit
log, so I'll spin a V2 tonight as you advised.

Thanks,
Danomi -


> Otherwise:
> Reviewed-by: Gary Bisson <gary.bisson@boundarydevices.com>
>
> Regards,
> Gary