bug in DT docs vs mcp251x.c driver

bug in DT docs vs mcp251x.c driver

[Janusz Użycki]

Hi,

We've noticed the inconsistency in DT which still exist in kernel v4.10:

devm_regulator_get(&spi->dev, "vdd") in drivers/net/can/mcp251x.c

vs vdd-supply: Regulator that powers the CAN controller. in
bindings/net/can/microchip,mcp251x.txt
Eg. https://patchwork.ozlabs.org/patch/304371/ best regards Janusz 
Użycki ELPROMA

Re: bug in DT docs vs mcp251x.c driver

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 716 bytes --]

On 02/21/2017 07:08 PM, Janusz Użycki wrote:
> Hi,
> 
> We've noticed the inconsistency in DT which still exist in kernel v4.10:
> 
> devm_regulator_get(&spi->dev, "vdd") in drivers/net/can/mcp251x.c
> 
> vs vdd-supply: Regulator that powers the CAN controller. in
> bindings/net/can/microchip,mcp251x.txt
> Eg. https://patchwork.ozlabs.org/patch/304371/ best regards Janusz 

Can you create a patch to fix the issue?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: bug in DT docs vs mcp251x.c driver

[Fabio Estevam]

Hi Janusz,

On Tue, Feb 21, 2017 at 3:08 PM, Janusz Użycki
<j.uzycki-cjVIcFy54eMe9JSWTWOYM+658FiBabzs@public.gmane.org> wrote:
> Hi,
>
> We've noticed the inconsistency in DT which still exist in kernel v4.10:
>
> devm_regulator_get(&spi->dev, "vdd") in drivers/net/can/mcp251x.c
>
> vs vdd-supply: Regulator that powers the CAN controller. in
> bindings/net/can/microchip,mcp251x.txt

This is correct.

When the regulator is retrieved as devm_regulator_get(dev, "xyz") then
it searches for a xyz-supply in the dts.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: bug in DT docs vs mcp251x.c driver

[Alexander Shiyan]

>Вторник, 21 февраля 2017, 21:08 +03:00 от Janusz Użycki <j.uzycki@elpromaelectronics.com>:

>We've noticed the inconsistency in DT which still exist in kernel v4.10:
>
>devm_regulator_get(&spi->dev, "vdd") in drivers/net/can/mcp251x.c
>
>vs vdd-supply: Regulator that powers the CAN controller. in
>bindings/net/can/microchip,mcp251x.txt

I do not see the bug here, could you clarify?

---

Re: bug in DT docs vs mcp251x.c driver

[Janusz Użycki]

Hi Fabio.

You are right. Thanks.
According to the source code printf adds the "-supply" indeed.
I've not verified the code as I got a report for 3.14 that the driver
does not work with vdd-supply in DT, works with vdd property
and the supply was verified electrically.
Now I have to investigate the problem better.

best regards

Janusz


W dniu 2017-02-21 o 19:47, Fabio Estevam pisze:
> Hi Janusz,
>
> On Tue, Feb 21, 2017 at 3:08 PM, Janusz Użycki
> <j.uzycki@elpromaelectronics.com> wrote:
>> Hi,
>>
>> We've noticed the inconsistency in DT which still exist in kernel v4.10:
>>
>> devm_regulator_get(&spi->dev, "vdd") in drivers/net/can/mcp251x.c
>>
>> vs vdd-supply: Regulator that powers the CAN controller. in
>> bindings/net/can/microchip,mcp251x.txt
> This is correct.
>
> When the regulator is retrieved as devm_regulator_get(dev, "xyz") then
> it searches for a xyz-supply in the dts.

Re: bug in DT docs vs mcp251x.c driver

[Janusz Użycki]

Hi Alexander.

You are right.
According to the source code printf adds the "-supply" indeed.
I've not verified the code as I got a report for 3.14 that the driver
does not work with vdd-supply in DT, works with vdd property
and the supply was verified electrically.
Now I have to investigate the problem better.

best regards

Janusz


W dniu 2017-02-22 o 06:53, Alexander Shiyan pisze:
>> Вторник, 21 февраля 2017, 21:08 +03:00 от Janusz Użycki <j.uzycki-cjVIcFy54eMe9JSWTWOYM+658FiBabzs@public.gmane.org>:
>> We've noticed the inconsistency in DT which still exist in kernel v4.10:
>>
>> devm_regulator_get(&spi->dev, "vdd") in drivers/net/can/mcp251x.c
>>
>> vs vdd-supply: Regulator that powers the CAN controller. in
>> bindings/net/can/microchip,mcp251x.txt
> I do not see the bug here, could you clarify?
>
> ---

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html