All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] check: fix incorrect interrupt detection
@ 2017-02-22  9:48 Dmitry Monakhov
  0 siblings, 0 replies; only message in thread
From: Dmitry Monakhov @ 2017-02-22  9:48 UTC (permalink / raw)
  To: fstests; +Cc: Dmitry Monakhov

Currently "Interrupted!" string always appeared in check.log because
flag cleared at very end after summary was dumped already.
It looks strange strange, but it was broken from very beginning 27fba05e (2001-01-15)

- update interrupt flag at the end of a section loop, but before _wrapup
- dump 'Interrupted' to stdout

Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
 check | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/check b/check
index 5a93c94..5d7f75c 100755
--- a/check
+++ b/check
@@ -405,7 +405,7 @@ _wrapup()
 			echo "Ran:$try" >>$check.log
 		fi
 
-		$interrupt && echo "Interrupted!" >>$check.log
+		$interrupt && echo "Interrupted!" | tee -a $check.log
 
 		if [ ! -z "$notrun" ]; then
 			if [ $brief_test_summary == "false" ]; then
@@ -755,7 +755,9 @@ for section in $HOST_OPTIONS_SECTIONS; do
 
 	    seq="after_$seqnum"
 	done
+	interrupt=false
 	_wrapup
+	interrupt=true
 	echo
 
 	_test_unmount 2> /dev/null
-- 
2.9.3


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-02-22  9:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-22  9:48 [PATCH] check: fix incorrect interrupt detection Dmitry Monakhov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.