* [PATCH] speakup: synth: Fix checkpatch warning
@ 2017-02-26 5:22 Man Choy
2017-02-27 14:42 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Man Choy @ 2017-02-26 5:22 UTC (permalink / raw)
To: gregkh
Cc: Man Choy, William Hubbs, Chris Brannon, Kirk Reiser,
Samuel Thibault, Walt Feasel, Katie Dunne, Colin Ian King,
Amitoj Kaur Chawla, speakup, devel, linux-kernel
Fix following checkpatch warning:
WARNING: line over 80 characters
+ &synth->attributes) < 0)
total: 0 errors, 1 warnings, 485 lines checked
Signed-off-by: Man Choy <manchoyy@gmail.com>
---
drivers/staging/speakup/synth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index a61c02b..d984312 100644
--- a/drivers/staging/speakup/synth.c
+++ b/drivers/staging/speakup/synth.c
@@ -406,8 +406,8 @@ static int do_synth_init(struct spk_synth *in_synth)
speakup_register_var(var);
if (!spk_quiet_boot)
synth_printf("%s found\n", synth->long_name);
- if (synth->attributes.name && sysfs_create_group(speakup_kobj,
- &synth->attributes) < 0)
+ if (synth->attributes.name &&
+ sysfs_create_group(speakup_kobj, &synth->attributes) < 0)
return -ENOMEM;
synth_flags = synth->flags;
wake_up_interruptible_all(&speakup_event);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] speakup: synth: Fix checkpatch warning
2017-02-26 5:22 [PATCH] speakup: synth: Fix checkpatch warning Man Choy
@ 2017-02-27 14:42 ` Greg KH
2017-02-28 1:07 ` Man Choy
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2017-02-27 14:42 UTC (permalink / raw)
To: Man Choy
Cc: devel, Kirk Reiser, Walt Feasel, Katie Dunne, speakup,
linux-kernel, Colin Ian King, Samuel Thibault, Chris Brannon
On Sun, Feb 26, 2017 at 01:22:18PM +0800, Man Choy wrote:
> Fix following checkpatch warning:
>
> WARNING: line over 80 characters
> + &synth->attributes) < 0)
>
> total: 0 errors, 1 warnings, 485 lines checked
> Signed-off-by: Man Choy <manchoyy@gmail.com>
> ---
> drivers/staging/speakup/synth.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Someone else already did this before you did, sorry :(
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] speakup: synth: Fix checkpatch warning
2017-02-27 14:42 ` Greg KH
@ 2017-02-28 1:07 ` Man Choy
0 siblings, 0 replies; 3+ messages in thread
From: Man Choy @ 2017-02-28 1:07 UTC (permalink / raw)
To: Greg KH
Cc: devel, Kirk Reiser, Walt Feasel, Katie Dunne, speakup,
linux-kernel, Colin Ian King, Samuel Thibault, Chris Brannon
On Mon, Feb 27, 2017 at 10:42 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Feb 26, 2017 at 01:22:18PM +0800, Man Choy wrote:
>> Fix following checkpatch warning:
>>
>> WARNING: line over 80 characters
>> + &synth->attributes) < 0)
>>
>> total: 0 errors, 1 warnings, 485 lines checked
>> Signed-off-by: Man Choy <manchoyy@gmail.com>
>> ---
>> drivers/staging/speakup/synth.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Someone else already did this before you did, sorry :(
>
> greg k-h
No worries. Thanks Greg.
Will look up other problem to solve.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-28 1:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-26 5:22 [PATCH] speakup: synth: Fix checkpatch warning Man Choy
2017-02-27 14:42 ` Greg KH
2017-02-28 1:07 ` Man Choy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.