* [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision
@ 2017-02-28 3:24 ` Timur Tabi
0 siblings, 0 replies; 12+ messages in thread
From: Timur Tabi @ 2017-02-28 3:24 UTC (permalink / raw)
To: linux-arm-kernel, linux-serial, Greg Kroah-Hartman, cov, manoj.iyer
For Qualcomm Technologies QDF2400 SOCs that are affected by
erratum E44, the ACPI oem_revision field is actually set to 1,
not 0.
Signed-off-by: Timur Tabi <timur@codeaurora.org>
---
drivers/acpi/spcr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
index 2b5d0fa..2051a8c 100644
--- a/drivers/acpi/spcr.c
+++ b/drivers/acpi/spcr.c
@@ -30,7 +30,7 @@ static bool qdf2400_erratum_44_present(struct acpi_table_header *h)
return true;
if (!memcmp(h->oem_table_id, "QDF2400 ", ACPI_OEM_TABLE_ID_SIZE) &&
- h->oem_revision == 0)
+ h->oem_revision == 1)
return true;
return false;
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision
@ 2017-02-28 3:24 ` Timur Tabi
0 siblings, 0 replies; 12+ messages in thread
From: Timur Tabi @ 2017-02-28 3:24 UTC (permalink / raw)
To: linux-arm-kernel
For Qualcomm Technologies QDF2400 SOCs that are affected by
erratum E44, the ACPI oem_revision field is actually set to 1,
not 0.
Signed-off-by: Timur Tabi <timur@codeaurora.org>
---
drivers/acpi/spcr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
index 2b5d0fa..2051a8c 100644
--- a/drivers/acpi/spcr.c
+++ b/drivers/acpi/spcr.c
@@ -30,7 +30,7 @@ static bool qdf2400_erratum_44_present(struct acpi_table_header *h)
return true;
if (!memcmp(h->oem_table_id, "QDF2400 ", ACPI_OEM_TABLE_ID_SIZE) &&
- h->oem_revision == 0)
+ h->oem_revision == 1)
return true;
return false;
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision
2017-02-28 3:24 ` Timur Tabi
@ 2017-02-28 4:02 ` Christopher Covington
-1 siblings, 0 replies; 12+ messages in thread
From: Christopher Covington @ 2017-02-28 4:02 UTC (permalink / raw)
To: Timur Tabi, linux-arm-kernel, linux-serial, Greg Kroah-Hartman,
manoj.iyer
>--- a/drivers/acpi/spcr.c
>+++ b/drivers/acpi/spcr.c
>@@ -30,7 +30,7 @@ static bool qdf2400_erratum_44_present(struct
>acpi_table_header *h)
> return true;
>
> if (!memcmp(h->oem_table_id, "QDF2400 ", ACPI_OEM_TABLE_ID_SIZE) &&
>- h->oem_revision == 0)
>+ h->oem_revision == 1)
You might want to make this <= 1 and also change firmware to 0 so that new firmware with old kernels, new kernels with old firmware, and new kernels with new firmware all get the workaround applied.
Regards,
Cov
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision
@ 2017-02-28 4:02 ` Christopher Covington
0 siblings, 0 replies; 12+ messages in thread
From: Christopher Covington @ 2017-02-28 4:02 UTC (permalink / raw)
To: linux-arm-kernel
>--- a/drivers/acpi/spcr.c
>+++ b/drivers/acpi/spcr.c
>@@ -30,7 +30,7 @@ static bool qdf2400_erratum_44_present(struct
>acpi_table_header *h)
> return true;
>
> if (!memcmp(h->oem_table_id, "QDF2400 ", ACPI_OEM_TABLE_ID_SIZE) &&
>- h->oem_revision == 0)
>+ h->oem_revision == 1)
You might want to make this <= 1 and also change firmware to 0 so that new firmware with old kernels, new kernels with old firmware, and new kernels with new firmware all get the workaround applied.
Regards,
Cov
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision
2017-02-28 4:02 ` Christopher Covington
@ 2017-02-28 4:11 ` Timur Tabi
-1 siblings, 0 replies; 12+ messages in thread
From: Timur Tabi @ 2017-02-28 4:11 UTC (permalink / raw)
To: Christopher Covington, linux-arm-kernel, linux-serial,
Greg Kroah-Hartman, manoj.iyer
Christopher Covington wrote:
> You might want to make this <= 1 and also change firmware to 0 so that new
> firmware with old kernels, new kernels with old firmware, and new kernels
> with new firmware all get the workaround applied.
I thought about that, but there is apparently no firmware that sets the value to 0.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision
@ 2017-02-28 4:11 ` Timur Tabi
0 siblings, 0 replies; 12+ messages in thread
From: Timur Tabi @ 2017-02-28 4:11 UTC (permalink / raw)
To: linux-arm-kernel
Christopher Covington wrote:
> You might want to make this <= 1 and also change firmware to 0 so that new
> firmware with old kernels, new kernels with old firmware, and new kernels
> with new firmware all get the workaround applied.
I thought about that, but there is apparently no firmware that sets the value to 0.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision
2017-02-28 3:24 ` Timur Tabi
@ 2017-02-28 20:19 ` dann frazier
-1 siblings, 0 replies; 12+ messages in thread
From: dann frazier @ 2017-02-28 20:19 UTC (permalink / raw)
To: Timur Tabi
Cc: Greg Kroah-Hartman, Manoj Iyer, linux-serial, linux-arm-kernel, cov
On Mon, Feb 27, 2017 at 8:24 PM, Timur Tabi <timur@codeaurora.org> wrote:
> For Qualcomm Technologies QDF2400 SOCs that are affected by
> erratum E44, the ACPI oem_revision field is actually set to 1,
> not 0.
Should this 'Fixes: d8a4995bcea1 ("PCI: Add ACS quirk for Qualcomm
QDF2400 and QDF2432")' ?
-dann
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision
@ 2017-02-28 20:19 ` dann frazier
0 siblings, 0 replies; 12+ messages in thread
From: dann frazier @ 2017-02-28 20:19 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Feb 27, 2017 at 8:24 PM, Timur Tabi <timur@codeaurora.org> wrote:
> For Qualcomm Technologies QDF2400 SOCs that are affected by
> erratum E44, the ACPI oem_revision field is actually set to 1,
> not 0.
Should this 'Fixes: d8a4995bcea1 ("PCI: Add ACS quirk for Qualcomm
QDF2400 and QDF2432")' ?
-dann
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision
2017-02-28 20:19 ` dann frazier
@ 2017-02-28 20:23 ` Timur Tabi
-1 siblings, 0 replies; 12+ messages in thread
From: Timur Tabi @ 2017-02-28 20:23 UTC (permalink / raw)
To: dann frazier
Cc: Greg Kroah-Hartman, Manoj Iyer, linux-serial, linux-arm-kernel, cov
On 02/28/2017 02:19 PM, dann frazier wrote:
> On Mon, Feb 27, 2017 at 8:24 PM, Timur Tabi <timur@codeaurora.org> wrote:
>> For Qualcomm Technologies QDF2400 SOCs that are affected by
>> erratum E44, the ACPI oem_revision field is actually set to 1,
>> not 0.
>
> Should this 'Fixes: d8a4995bcea1 ("PCI: Add ACS quirk for Qualcomm
> QDF2400 and QDF2432")' ?
Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
I will post a v2.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision
@ 2017-02-28 20:23 ` Timur Tabi
0 siblings, 0 replies; 12+ messages in thread
From: Timur Tabi @ 2017-02-28 20:23 UTC (permalink / raw)
To: linux-arm-kernel
On 02/28/2017 02:19 PM, dann frazier wrote:
> On Mon, Feb 27, 2017 at 8:24 PM, Timur Tabi <timur@codeaurora.org> wrote:
>> For Qualcomm Technologies QDF2400 SOCs that are affected by
>> erratum E44, the ACPI oem_revision field is actually set to 1,
>> not 0.
>
> Should this 'Fixes: d8a4995bcea1 ("PCI: Add ACS quirk for Qualcomm
> QDF2400 and QDF2432")' ?
Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
I will post a v2.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision
2017-02-28 20:23 ` Timur Tabi
@ 2017-02-28 20:25 ` dann frazier
-1 siblings, 0 replies; 12+ messages in thread
From: dann frazier @ 2017-02-28 20:25 UTC (permalink / raw)
To: Timur Tabi
Cc: Greg Kroah-Hartman, Manoj Iyer, linux-serial, linux-arm-kernel, cov
On Tue, Feb 28, 2017 at 1:23 PM, Timur Tabi <timur@codeaurora.org> wrote:
> On 02/28/2017 02:19 PM, dann frazier wrote:
>>
>> On Mon, Feb 27, 2017 at 8:24 PM, Timur Tabi <timur@codeaurora.org> wrote:
>>>
>>> For Qualcomm Technologies QDF2400 SOCs that are affected by
>>> erratum E44, the ACPI oem_revision field is actually set to 1,
>>> not 0.
>>
>>
>> Should this 'Fixes: d8a4995bcea1 ("PCI: Add ACS quirk for Qualcomm
>> QDF2400 and QDF2432")' ?
>
>
> Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
oops.. right. Pulled the long line from my git --grep QDF2400 :(
-dann
> I will post a v2.
>
>
> --
> Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
> Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
> Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision
@ 2017-02-28 20:25 ` dann frazier
0 siblings, 0 replies; 12+ messages in thread
From: dann frazier @ 2017-02-28 20:25 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Feb 28, 2017 at 1:23 PM, Timur Tabi <timur@codeaurora.org> wrote:
> On 02/28/2017 02:19 PM, dann frazier wrote:
>>
>> On Mon, Feb 27, 2017 at 8:24 PM, Timur Tabi <timur@codeaurora.org> wrote:
>>>
>>> For Qualcomm Technologies QDF2400 SOCs that are affected by
>>> erratum E44, the ACPI oem_revision field is actually set to 1,
>>> not 0.
>>
>>
>> Should this 'Fixes: d8a4995bcea1 ("PCI: Add ACS quirk for Qualcomm
>> QDF2400 and QDF2432")' ?
>
>
> Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
oops.. right. Pulled the long line from my git --grep QDF2400 :(
-dann
> I will post a v2.
>
>
> --
> Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
> Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
> Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-02-28 20:25 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-28 3:24 [PATCH] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision Timur Tabi
2017-02-28 3:24 ` Timur Tabi
2017-02-28 4:02 ` Christopher Covington
2017-02-28 4:02 ` Christopher Covington
2017-02-28 4:11 ` Timur Tabi
2017-02-28 4:11 ` Timur Tabi
2017-02-28 20:19 ` dann frazier
2017-02-28 20:19 ` dann frazier
2017-02-28 20:23 ` Timur Tabi
2017-02-28 20:23 ` Timur Tabi
2017-02-28 20:25 ` dann frazier
2017-02-28 20:25 ` dann frazier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.