[PATCH] selinux: fix kernel BUG on prlimit(..., NULL, NULL)

* [PATCH] selinux: fix kernel BUG on prlimit(..., NULL, NULL)
@ 2017-02-28 14:35 Stephen Smalley
  2017-02-28 21:39 ` Paul Moore
  2017-03-01  2:11 ` James Morris
  0 siblings, 2 replies; 4+ messages in thread
From: Stephen Smalley @ 2017-02-28 14:35 UTC (permalink / raw)
  To: james.l.morris
  Cc: linux-security-module, paul, jslaby, selinux, xiaolong.ye,
	Stephen Smalley

commit 79bcf325e6b32b3c ("prlimit,security,selinux: add a security hook
for prlimit") introduced a security hook for prlimit() and implemented it
for SELinux.  However, if prlimit() is called with NULL arguments for both
the new limit and the old limit, then the hook is called with 0 for the
read/write flags, since the prlimit() will neither read nor write the
process' limits.  This would in turn lead to calling avc_has_perm() with 0
for the requested permissions, which triggers a BUG_ON() in
avc_has_perm_noaudit() since the kernel should never be invoking
avc_has_perm() with no permissions.  Fix this in the SELinux hook by
returning immediately if the flags are 0.  Arguably prlimit64() itself
ought to return immediately if both old_rlim and new_rlim are NULL since
it is effectively a no-op in that case.

Reported by the lkp-robot based on trinity testing.

Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
---
 security/selinux/hooks.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 4a80bd8..af1ff15 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -3922,6 +3922,8 @@ int selinux_task_prlimit(const struct cred *cred, const struct cred *tcred,
 {
 	u32 av = 0;
 
+	if (!flags)
+		return 0;
 	if (flags & LSM_PRLIMIT_WRITE)
 		av |= PROCESS__SETRLIMIT;
 	if (flags & LSM_PRLIMIT_READ)
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread