From: Johannes Berg <johannes@sipsolutions.net>
To: Marcel Holtmann <marcel@holtmann.org>,
"David S. Miller" <davem@davemloft.net>
Cc: Network Development <netdev@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Removing GENL_ID_GENERATE breaks userspace API
Date: Thu, 02 Mar 2017 19:11:22 +0100 [thread overview]
Message-ID: <1488478282.23555.0.camel@sipsolutions.net> (raw)
In-Reply-To: <E04592A3-747F-4C80-8650-5F1AEE28F92B@holtmann.org>
On Thu, 2017-03-02 at 17:50 +0100, Marcel Holtmann wrote:
> Hi Johannes,
>
> you have removed GENL_ID_GENERATE in 4.10, but that is actually
> breaking userspace API.
>
> commit a07ea4d9941af5a0c6f0be2a71b51ac9c083c5e5
> Author: Johannes Berg <johannes.berg@intel.com>
> Date: Mon Oct 24 14:40:02 2016 +0200
>
> genetlink: no longer support using static family IDs
>
> diff --git a/include/uapi/linux/genetlink.h
> b/include/uapi/linux/genetlink.h
> index 5512c90af7e3..d9b2db4a29c6 100644
> --- a/include/uapi/linux/genetlink.h
> +++ b/include/uapi/linux/genetlink.h
> @@ -26,7 +26,6 @@ struct genlmsghdr {
> /*
> * List of reserved static generic netlink identifiers:
> */
> -#define GENL_ID_GENERATE 0
> #define GENL_ID_CTRL NLMSG_MIN_TYPE
>
> Since the GENL_ID_GENERATE is in include/uapi/ I would have expected
> that you leave this in. For us, you just broke userspace API with
> this change.
Huh. It makes no sense to be using it nor ever did, but I guess we can
add it back with a comment saying that it's actually needed - send a
patch?
johannes
prev parent reply other threads:[~2017-03-02 19:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 16:50 Removing GENL_ID_GENERATE breaks userspace API Marcel Holtmann
2017-03-02 18:11 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488478282.23555.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.