* Removing GENL_ID_GENERATE breaks userspace API
@ 2017-03-02 16:50 Marcel Holtmann
2017-03-02 18:11 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Marcel Holtmann @ 2017-03-02 16:50 UTC (permalink / raw)
To: Johannes Berg, David S. Miller; +Cc: Network Development, Linus Torvalds
Hi Johannes,
you have removed GENL_ID_GENERATE in 4.10, but that is actually breaking userspace API.
commit a07ea4d9941af5a0c6f0be2a71b51ac9c083c5e5
Author: Johannes Berg <johannes.berg@intel.com>
Date: Mon Oct 24 14:40:02 2016 +0200
genetlink: no longer support using static family IDs
diff --git a/include/uapi/linux/genetlink.h b/include/uapi/linux/genetlink.h
index 5512c90af7e3..d9b2db4a29c6 100644
--- a/include/uapi/linux/genetlink.h
+++ b/include/uapi/linux/genetlink.h
@@ -26,7 +26,6 @@ struct genlmsghdr {
/*
* List of reserved static generic netlink identifiers:
*/
-#define GENL_ID_GENERATE 0
#define GENL_ID_CTRL NLMSG_MIN_TYPE
Since the GENL_ID_GENERATE is in include/uapi/ I would have expected that you leave this in. For us, you just broke userspace API with this change.
Regards
Marcel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Removing GENL_ID_GENERATE breaks userspace API
2017-03-02 16:50 Removing GENL_ID_GENERATE breaks userspace API Marcel Holtmann
@ 2017-03-02 18:11 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2017-03-02 18:11 UTC (permalink / raw)
To: Marcel Holtmann, David S. Miller; +Cc: Network Development, Linus Torvalds
On Thu, 2017-03-02 at 17:50 +0100, Marcel Holtmann wrote:
> Hi Johannes,
>
> you have removed GENL_ID_GENERATE in 4.10, but that is actually
> breaking userspace API.
>
> commit a07ea4d9941af5a0c6f0be2a71b51ac9c083c5e5
> Author: Johannes Berg <johannes.berg@intel.com>
> Date: Mon Oct 24 14:40:02 2016 +0200
>
> genetlink: no longer support using static family IDs
>
> diff --git a/include/uapi/linux/genetlink.h
> b/include/uapi/linux/genetlink.h
> index 5512c90af7e3..d9b2db4a29c6 100644
> --- a/include/uapi/linux/genetlink.h
> +++ b/include/uapi/linux/genetlink.h
> @@ -26,7 +26,6 @@ struct genlmsghdr {
> /*
> * List of reserved static generic netlink identifiers:
> */
> -#define GENL_ID_GENERATE 0
> #define GENL_ID_CTRL NLMSG_MIN_TYPE
>
> Since the GENL_ID_GENERATE is in include/uapi/ I would have expected
> that you leave this in. For us, you just broke userspace API with
> this change.
Huh. It makes no sense to be using it nor ever did, but I guess we can
add it back with a comment saying that it's actually needed - send a
patch?
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-02 19:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-02 16:50 Removing GENL_ID_GENERATE breaks userspace API Marcel Holtmann
2017-03-02 18:11 ` Johannes Berg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.