From: Leo Yan <leo.yan@linaro.org> To: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Wei Xu <xuwei5@hisilicon.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, Mathieu Poirier <mathieu.poirier@linaro.org>, John Stultz <john.stultz@linaro.org>, Guodong Xu <guodong.xu@linaro.org>, Haojian Zhuang <haojian.zhuang@linaro.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, mike.leach@linaro.org Cc: Leo Yan <leo.yan@linaro.org> Subject: [PATCH v3 0/5] coresight: enable debug module Date: Fri, 3 Mar 2017 14:00:04 +0800 [thread overview] Message-ID: <1488520809-31670-1-git-send-email-leo.yan@linaro.org> (raw) ARMv8 architecture reference manual (ARM DDI 0487A.k) Chapter H7 "The Sample-based Profiling Extension" has description for sampling registers, we can utilize these registers to check program counter value with combined CPU exception level, secure state, etc. So this is helpful for CPU lockup bugs, e.g. if one CPU has run into infinite loop with IRQ disabled; the 'hang' CPU cannot switch context and handle any interrupt, so it cannot handle SMP call for stack dump, etc. This patch series is to enable coresight debug module with sample-based registers and register call back notifier for PCSR register dumping when panic happens, so we can see below dumping info for panic; and this patch series has considered the conditions for access permission for debug registers self, so this can avoid access debug registers when CPU power domain is off; the driver also try to figure out the CPU is in secure or non-secure state. The last two patches in this series is to enable debug unit on 96boards Hikey, the first patch is to add apb clock for debug unit and the second patch is to add DT nodes for debug unit. As result we can below log after input command: echo c > /proc/sysrq-trigger: ARM external debug module: CPU[0]: EDPRSR: 0000000b (Power:On DLK:Unlock) EDPCSR: [<ffff00000808eb54>] handle_IPI+0xe4/0x150 EDCIDSR: 00000000 EDVIDSR: 90000000 (State:Non-secure Mode:EL1/0 Width:64bits VMID:0) CPU[1]: EDPRSR: 0000000b (Power:On DLK:Unlock) EDPCSR: [<ffff0000087a64c0>] debug_notifier_call+0x108/0x288 EDCIDSR: 00000000 EDVIDSR: 90000000 (State:Non-secure Mode:EL1/0 Width:64bits VMID:0) [...] Changes from v2: * According to Mathieu Poirier suggestion, applied some minor fixes. * Added two extra patches for enabling debug module on Hikey. Changes from v1: * According to Mike Leach suggestion, removed the binding for debug module clocks which have been directly provided by CPU clocks. * According to Mathieu Poirier suggestion, added function of_coresight_get_cpu() and some minor refactors for debug module driver. Changes from RFC: * According to Mike Leach suggestion, added check for EDPRSR to avoid lockup; added supporting EDVIDSR and EDCIDSR registers. * According to Mark Rutland and Mathieu Poirier suggestion, rewrote the documentation for DT binding. * According to Mark and Mathieu suggestion, refined debug driver. Leo Yan (5): coresight: bindings for debug module coresight: refactor with function of_coresight_get_cpu coresight: add support for debug module clk: hi6220: add debug APB clock arm64: dts: hi6220: register debug module .../devicetree/bindings/arm/coresight-debug.txt | 40 +++ arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 64 ++++ drivers/clk/hisilicon/clk-hi6220.c | 1 + drivers/hwtracing/coresight/Kconfig | 10 + drivers/hwtracing/coresight/Makefile | 1 + drivers/hwtracing/coresight/coresight-debug.c | 377 +++++++++++++++++++++ drivers/hwtracing/coresight/of_coresight.c | 37 +- include/dt-bindings/clock/hi6220-clock.h | 5 +- include/linux/coresight.h | 2 + 9 files changed, 524 insertions(+), 13 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/coresight-debug.txt create mode 100644 drivers/hwtracing/coresight/coresight-debug.c -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: leo.yan@linaro.org (Leo Yan) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 0/5] coresight: enable debug module Date: Fri, 3 Mar 2017 14:00:04 +0800 [thread overview] Message-ID: <1488520809-31670-1-git-send-email-leo.yan@linaro.org> (raw) ARMv8 architecture reference manual (ARM DDI 0487A.k) Chapter H7 "The Sample-based Profiling Extension" has description for sampling registers, we can utilize these registers to check program counter value with combined CPU exception level, secure state, etc. So this is helpful for CPU lockup bugs, e.g. if one CPU has run into infinite loop with IRQ disabled; the 'hang' CPU cannot switch context and handle any interrupt, so it cannot handle SMP call for stack dump, etc. This patch series is to enable coresight debug module with sample-based registers and register call back notifier for PCSR register dumping when panic happens, so we can see below dumping info for panic; and this patch series has considered the conditions for access permission for debug registers self, so this can avoid access debug registers when CPU power domain is off; the driver also try to figure out the CPU is in secure or non-secure state. The last two patches in this series is to enable debug unit on 96boards Hikey, the first patch is to add apb clock for debug unit and the second patch is to add DT nodes for debug unit. As result we can below log after input command: echo c > /proc/sysrq-trigger: ARM external debug module: CPU[0]: EDPRSR: 0000000b (Power:On DLK:Unlock) EDPCSR: [<ffff00000808eb54>] handle_IPI+0xe4/0x150 EDCIDSR: 00000000 EDVIDSR: 90000000 (State:Non-secure Mode:EL1/0 Width:64bits VMID:0) CPU[1]: EDPRSR: 0000000b (Power:On DLK:Unlock) EDPCSR: [<ffff0000087a64c0>] debug_notifier_call+0x108/0x288 EDCIDSR: 00000000 EDVIDSR: 90000000 (State:Non-secure Mode:EL1/0 Width:64bits VMID:0) [...] Changes from v2: * According to Mathieu Poirier suggestion, applied some minor fixes. * Added two extra patches for enabling debug module on Hikey. Changes from v1: * According to Mike Leach suggestion, removed the binding for debug module clocks which have been directly provided by CPU clocks. * According to Mathieu Poirier suggestion, added function of_coresight_get_cpu() and some minor refactors for debug module driver. Changes from RFC: * According to Mike Leach suggestion, added check for EDPRSR to avoid lockup; added supporting EDVIDSR and EDCIDSR registers. * According to Mark Rutland and Mathieu Poirier suggestion, rewrote the documentation for DT binding. * According to Mark and Mathieu suggestion, refined debug driver. Leo Yan (5): coresight: bindings for debug module coresight: refactor with function of_coresight_get_cpu coresight: add support for debug module clk: hi6220: add debug APB clock arm64: dts: hi6220: register debug module .../devicetree/bindings/arm/coresight-debug.txt | 40 +++ arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 64 ++++ drivers/clk/hisilicon/clk-hi6220.c | 1 + drivers/hwtracing/coresight/Kconfig | 10 + drivers/hwtracing/coresight/Makefile | 1 + drivers/hwtracing/coresight/coresight-debug.c | 377 +++++++++++++++++++++ drivers/hwtracing/coresight/of_coresight.c | 37 +- include/dt-bindings/clock/hi6220-clock.h | 5 +- include/linux/coresight.h | 2 + 9 files changed, 524 insertions(+), 13 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/coresight-debug.txt create mode 100644 drivers/hwtracing/coresight/coresight-debug.c -- 2.7.4
next reply other threads:[~2017-03-03 7:09 UTC|newest] Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-03 6:00 Leo Yan [this message] 2017-03-03 6:00 ` [PATCH v3 0/5] coresight: enable debug module Leo Yan 2017-03-03 6:00 ` [PATCH v3 1/5] coresight: bindings for " Leo Yan 2017-03-03 6:00 ` Leo Yan 2017-03-09 13:27 ` [v3 " Suzuki K Poulose 2017-03-09 13:27 ` Suzuki K Poulose 2017-03-09 13:27 ` Suzuki K Poulose 2017-03-03 6:00 ` [PATCH v3 2/5] coresight: refactor with function of_coresight_get_cpu Leo Yan 2017-03-03 6:00 ` Leo Yan 2017-03-03 6:00 ` [PATCH v3 3/5] coresight: add support for debug module Leo Yan 2017-03-03 6:00 ` Leo Yan 2017-03-09 16:53 ` [v3 " Suzuki K Poulose 2017-03-09 16:53 ` Suzuki K Poulose 2017-03-09 16:53 ` Suzuki K Poulose 2017-03-09 17:59 ` Leo Yan 2017-03-09 17:59 ` Leo Yan 2017-03-09 17:59 ` Leo Yan 2017-03-10 14:29 ` Suzuki K Poulose 2017-03-10 14:29 ` Suzuki K Poulose 2017-03-13 8:12 ` Leo Yan 2017-03-13 8:12 ` Leo Yan 2017-03-13 8:12 ` Leo Yan 2017-03-13 16:56 ` Mathieu Poirier 2017-03-13 16:56 ` Mathieu Poirier 2017-03-13 16:56 ` Mathieu Poirier 2017-03-15 16:44 ` Suzuki K Poulose 2017-03-15 16:44 ` Suzuki K Poulose 2017-03-15 16:44 ` Suzuki K Poulose 2017-03-15 20:41 ` Mathieu Poirier 2017-03-15 20:41 ` Mathieu Poirier 2017-03-15 20:41 ` Mathieu Poirier 2017-03-15 20:41 ` Mathieu Poirier 2017-03-17 10:13 ` Leo Yan 2017-03-17 10:13 ` Leo Yan 2017-03-17 10:13 ` Leo Yan 2017-03-17 10:13 ` Leo Yan 2017-03-17 15:50 ` Mathieu Poirier 2017-03-17 15:50 ` Mathieu Poirier 2017-03-17 15:50 ` Mathieu Poirier 2017-03-17 15:50 ` Mathieu Poirier 2017-03-17 16:28 ` Leo Yan 2017-03-17 16:28 ` Leo Yan 2017-03-17 16:28 ` Leo Yan 2017-03-17 16:28 ` Leo Yan 2017-03-17 16:47 ` Suzuki K Poulose 2017-03-17 16:47 ` Suzuki K Poulose 2017-03-17 16:47 ` Suzuki K Poulose 2017-03-17 16:47 ` Suzuki K Poulose 2017-03-20 12:30 ` Leo Yan 2017-03-20 12:30 ` Leo Yan 2017-03-20 12:30 ` Leo Yan 2017-03-20 12:30 ` Leo Yan 2017-03-20 16:40 ` Mathieu Poirier 2017-03-20 16:40 ` Mathieu Poirier 2017-03-20 16:40 ` Mathieu Poirier 2017-03-20 16:40 ` Mathieu Poirier 2017-03-21 2:59 ` Leo Yan 2017-03-21 2:59 ` Leo Yan 2017-03-21 2:59 ` Leo Yan 2017-03-21 2:59 ` Leo Yan 2017-03-21 10:16 ` Suzuki K Poulose 2017-03-21 10:16 ` Suzuki K Poulose 2017-03-21 10:16 ` Suzuki K Poulose 2017-03-21 11:47 ` Leo Yan 2017-03-21 11:47 ` Leo Yan 2017-03-21 11:47 ` Leo Yan 2017-03-21 11:47 ` Leo Yan 2017-03-21 15:15 ` Mathieu Poirier 2017-03-21 15:15 ` Mathieu Poirier 2017-03-21 15:15 ` Mathieu Poirier 2017-03-21 15:15 ` Mathieu Poirier 2017-03-13 16:29 ` Mathieu Poirier 2017-03-13 16:29 ` Mathieu Poirier 2017-03-13 16:29 ` Mathieu Poirier 2017-03-21 15:39 ` [PATCH v3 " Sudeep Holla 2017-03-21 15:39 ` Sudeep Holla 2017-03-22 12:54 ` Mike Leach 2017-03-22 14:07 ` Sudeep Holla 2017-03-22 14:07 ` Sudeep Holla 2017-03-22 14:07 ` Sudeep Holla 2017-03-22 15:45 ` Mike Leach 2017-03-22 15:45 ` Mike Leach 2017-03-22 15:45 ` Mike Leach 2017-03-22 16:17 ` Sudeep Holla 2017-03-22 16:17 ` Sudeep Holla 2017-03-22 17:09 ` Suzuki K Poulose 2017-03-22 17:09 ` Suzuki K Poulose 2017-03-22 17:09 ` Suzuki K Poulose 2017-03-22 17:25 ` Sudeep Holla 2017-03-22 17:25 ` Sudeep Holla 2017-03-22 17:25 ` Sudeep Holla 2017-03-23 5:43 ` Leo Yan 2017-03-23 5:43 ` Leo Yan 2017-03-23 5:43 ` Leo Yan 2017-03-23 12:27 ` Mike Leach 2017-03-23 12:27 ` Mike Leach 2017-03-22 16:01 ` Leo Yan 2017-03-22 16:01 ` Leo Yan 2017-03-22 16:53 ` Sudeep Holla 2017-03-22 16:53 ` Sudeep Holla 2017-03-22 16:53 ` Sudeep Holla 2017-03-03 6:00 ` [PATCH v3 4/5] clk: hi6220: add debug APB clock Leo Yan 2017-03-03 6:00 ` Leo Yan 2017-03-03 23:58 ` Stephen Boyd 2017-03-03 23:58 ` Stephen Boyd 2017-03-03 23:58 ` Stephen Boyd 2017-03-17 15:22 ` Leo Yan 2017-03-17 15:22 ` Leo Yan 2017-03-17 15:22 ` Leo Yan 2017-03-03 6:00 ` [PATCH v3 5/5] arm64: dts: hi6220: register debug module Leo Yan 2017-03-03 6:00 ` Leo Yan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1488520809-31670-1-git-send-email-leo.yan@linaro.org \ --to=leo.yan@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=guodong.xu@linaro.org \ --cc=haojian.zhuang@linaro.org \ --cc=john.stultz@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mathieu.poirier@linaro.org \ --cc=mike.leach@linaro.org \ --cc=mturquette@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@codeaurora.org \ --cc=will.deacon@arm.com \ --cc=xuwei5@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.