All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86/apic: Fix a comment in init_apic_mappings()
@ 2017-03-06 13:08 Dou Liyang
  2017-03-13 20:42 ` [tip:timers/core] " tip-bot for Dou Liyang
  2017-03-13 20:45 ` [tip:x86/apic] " tip-bot for Dou Liyang
  0 siblings, 2 replies; 3+ messages in thread
From: Dou Liyang @ 2017-03-06 13:08 UTC (permalink / raw)
  To: mingo, tglx, hpa, yinghai; +Cc: x86, linux-kernel, Dou Liyang

The commit c0104d38a740 ("x86, apic: Unify identical
register_lapic_address() functions") renames acpi_register_lapic_address
to register_lapic_address.

But acpi_register_lapic_address remains in a comment, and renaming it
to register_lapic_address is not suitable for this comment.

Remove acpi_register_lapic_address and rewrite the comment.

Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
---
 arch/x86/kernel/apic/apic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 4261b32..70b0243 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1798,8 +1798,8 @@ void __init init_apic_mappings(void)
 		apic_phys = mp_lapic_addr;
 
 		/*
-		 * acpi lapic path already maps that address in
-		 * acpi_register_lapic_address()
+		 * ACPI LAPIC path already maps that address during
+		 * early parsing LAPIC address in MADT
 		 */
 		if (!acpi_lapic && !smp_found_config)
 			register_lapic_address(apic_phys);
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [tip:timers/core] x86/apic: Fix a comment in init_apic_mappings()
  2017-03-06 13:08 [PATCH] x86/apic: Fix a comment in init_apic_mappings() Dou Liyang
@ 2017-03-13 20:42 ` tip-bot for Dou Liyang
  2017-03-13 20:45 ` [tip:x86/apic] " tip-bot for Dou Liyang
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Dou Liyang @ 2017-03-13 20:42 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: mingo, tglx, douly.fnst, linux-kernel, hpa

Commit-ID:  ad258524b64756834f5fe23620beedb7c3609dc8
Gitweb:     http://git.kernel.org/tip/ad258524b64756834f5fe23620beedb7c3609dc8
Author:     Dou Liyang <douly.fnst@cn.fujitsu.com>
AuthorDate: Mon, 6 Mar 2017 21:08:10 +0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 13 Mar 2017 21:40:14 +0100

x86/apic: Fix a comment in init_apic_mappings()

commit c0104d38a740 ("x86, apic: Unify identical register_lapic_address()
functions") renames acpi_register_lapic_address to register_lapic_address.

But acpi_register_lapic_address remains in a comment, and renaming it to
register_lapic_address is not suitable for this comment.

Remove acpi_register_lapic_address and rewrite the comment.

[ tglx: LAPIC address can be registered either by ACPI/MADT or MP info ]

Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
Cc: yinghai@kernel.org
Link: http://lkml.kernel.org/r/1488805690-5055-1-git-send-email-douly.fnst@cn.fujitsu.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 arch/x86/kernel/apic/apic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index aee7ded..100c43f 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1789,8 +1789,8 @@ void __init init_apic_mappings(void)
 		apic_phys = mp_lapic_addr;
 
 		/*
-		 * acpi lapic path already maps that address in
-		 * acpi_register_lapic_address()
+		 * If the system has ACPI MADT tables or MP info, the LAPIC
+		 * address is already registered.
 		 */
 		if (!acpi_lapic && !smp_found_config)
 			register_lapic_address(apic_phys);

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [tip:x86/apic] x86/apic: Fix a comment in init_apic_mappings()
  2017-03-06 13:08 [PATCH] x86/apic: Fix a comment in init_apic_mappings() Dou Liyang
  2017-03-13 20:42 ` [tip:timers/core] " tip-bot for Dou Liyang
@ 2017-03-13 20:45 ` tip-bot for Dou Liyang
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Dou Liyang @ 2017-03-13 20:45 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: tglx, hpa, linux-kernel, mingo, douly.fnst

Commit-ID:  5ba039a55498d78a787edaf8cc915f29a17cecf3
Gitweb:     http://git.kernel.org/tip/5ba039a55498d78a787edaf8cc915f29a17cecf3
Author:     Dou Liyang <douly.fnst@cn.fujitsu.com>
AuthorDate: Mon, 6 Mar 2017 21:08:10 +0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 13 Mar 2017 21:42:11 +0100

x86/apic: Fix a comment in init_apic_mappings()

commit c0104d38a740 ("x86, apic: Unify identical register_lapic_address()
functions") renames acpi_register_lapic_address to register_lapic_address.

But acpi_register_lapic_address remains in a comment, and renaming it to
register_lapic_address is not suitable for this comment.

Remove acpi_register_lapic_address and rewrite the comment.

[ tglx: LAPIC address can be registered either by ACPI/MADT or MP info ]

Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
Cc: yinghai@kernel.org
Link: http://lkml.kernel.org/r/1488805690-5055-1-git-send-email-douly.fnst@cn.fujitsu.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 arch/x86/kernel/apic/apic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index f3034ba..192e909 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1789,8 +1789,8 @@ void __init init_apic_mappings(void)
 		apic_phys = mp_lapic_addr;
 
 		/*
-		 * acpi lapic path already maps that address in
-		 * acpi_register_lapic_address()
+		 * If the system has ACPI MADT tables or MP info, the LAPIC
+		 * address is already registered.
 		 */
 		if (!acpi_lapic && !smp_found_config)
 			register_lapic_address(apic_phys);

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-13 20:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-06 13:08 [PATCH] x86/apic: Fix a comment in init_apic_mappings() Dou Liyang
2017-03-13 20:42 ` [tip:timers/core] " tip-bot for Dou Liyang
2017-03-13 20:45 ` [tip:x86/apic] " tip-bot for Dou Liyang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.